From: Dmitry Lavnikevich <d.lavnikevich-H6HfJ9slvY2ikuSvNLsyVV6hYfS7NtTn@public.gmane.org>
To: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Dmitry Lavnikevich
<d.lavnikevich-H6HfJ9slvY0Aspv4Qr0y0gC/G2K4zDHf@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
perex-/Fr2/VpizcU@public.gmane.org,
tiwai-l3A5Bk7waGM@public.gmane.org,
timur-N01EOCouUvQ@public.gmane.org,
nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org
Subject: Re: [PATCH 1/5] ARM: dts: pbab01: move i2c pins and frequency configuration into pfla02
Date: Fri, 12 Sep 2014 18:55:46 +0300 [thread overview]
Message-ID: <54131782.2000204@sam-solutions.net> (raw)
In-Reply-To: <1410425238.4011.18.camel-+qGW7pzALmz7o/J7KWpOmN53zsg1cpMQ@public.gmane.org>
On 11/09/14 11:47, Philipp Zabel wrote:
> Am Mittwoch, den 10.09.2014, 16:46 +0300 schrieb Dmitry Lavnikevich:
>> Since pins and frequency are specific to module (pfla02), not base board
>> (pbab02), it is better to be initialized in corresponding dts file.
>>
>> Signed-off-by: Dmitry Lavnikevich <d.lavnikevich-H6HfJ9slvY0Aspv4Qr0y0gC/G2K4zDHf@public.gmane.org>
> I have seen boards use the GPIO_3/6 pads instead of EIM_D17/D18 for
> I2C3, but the EIM_D17/D18 are indeed documented as "I2C1" pins at the
> pfla02 connector level.
>
> regards
> Philipp
>
Yes, that is why I thought about moving it into pfla02. But apart from
it, i2c2grp i2c3grp nodes was wrongly placed under iomuxc node while
it should be grouped inside of it, like in imx6q-phytec-pfla02 to
which it was moved with this patch.
Because of this specified i2c wasn't working correctly and caused
messages:
imx6q-pinctrl 20e0000.iomuxc: no groups defined in
/soc/aips-bus@02000000/iomuxc@020e0000/i2c2grp
imx6q-pinctrl 20e0000.iomuxc: no groups defined in
/soc/aips-bus@02000000/iomuxc@020e0000/i2c3grp
imx6q-pinctrl 20e0000.iomuxc: unable to find group for node i2c2grp
imx6q-pinctrl 20e0000.iomuxc: unable to find group for node i2c3grp
Added this into commit message with new patchset.
Best regards,
Lavnikevich Dmitry
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: d.lavnikevich@sam-solutions.net (Dmitry Lavnikevich)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: dts: pbab01: move i2c pins and frequency configuration into pfla02
Date: Fri, 12 Sep 2014 18:55:46 +0300 [thread overview]
Message-ID: <54131782.2000204@sam-solutions.net> (raw)
In-Reply-To: <1410425238.4011.18.camel@paszta.hi.pengutronix.de>
On 11/09/14 11:47, Philipp Zabel wrote:
> Am Mittwoch, den 10.09.2014, 16:46 +0300 schrieb Dmitry Lavnikevich:
>> Since pins and frequency are specific to module (pfla02), not base board
>> (pbab02), it is better to be initialized in corresponding dts file.
>>
>> Signed-off-by: Dmitry Lavnikevich <d.lavnikevich@sam-solutions.com>
> I have seen boards use the GPIO_3/6 pads instead of EIM_D17/D18 for
> I2C3, but the EIM_D17/D18 are indeed documented as "I2C1" pins at the
> pfla02 connector level.
>
> regards
> Philipp
>
Yes, that is why I thought about moving it into pfla02. But apart from
it, i2c2grp i2c3grp nodes was wrongly placed under iomuxc node while
it should be grouped inside of it, like in imx6q-phytec-pfla02 to
which it was moved with this patch.
Because of this specified i2c wasn't working correctly and caused
messages:
imx6q-pinctrl 20e0000.iomuxc: no groups defined in
/soc/aips-bus at 02000000/iomuxc at 020e0000/i2c2grp
imx6q-pinctrl 20e0000.iomuxc: no groups defined in
/soc/aips-bus at 02000000/iomuxc at 020e0000/i2c3grp
imx6q-pinctrl 20e0000.iomuxc: unable to find group for node i2c2grp
imx6q-pinctrl 20e0000.iomuxc: unable to find group for node i2c3grp
Added this into commit message with new patchset.
Best regards,
Lavnikevich Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Lavnikevich <d.lavnikevich@sam-solutions.net>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Dmitry Lavnikevich <d.lavnikevich@sam-solutions.com>
Cc: <robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <shawn.guo@freescale.com>,
<kernel@pengutronix.de>, <linux@arm.linux.org.uk>,
<perex@perex.cz>, <tiwai@suse.de>, <timur@tabi.org>,
<nicoleotsuka@gmail.com>, <Li.Xiubo@freescale.com>,
<grant.likely@linaro.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<alsa-devel@alsa-project.org>
Subject: Re: [PATCH 1/5] ARM: dts: pbab01: move i2c pins and frequency configuration into pfla02
Date: Fri, 12 Sep 2014 18:55:46 +0300 [thread overview]
Message-ID: <54131782.2000204@sam-solutions.net> (raw)
In-Reply-To: <1410425238.4011.18.camel@paszta.hi.pengutronix.de>
On 11/09/14 11:47, Philipp Zabel wrote:
> Am Mittwoch, den 10.09.2014, 16:46 +0300 schrieb Dmitry Lavnikevich:
>> Since pins and frequency are specific to module (pfla02), not base board
>> (pbab02), it is better to be initialized in corresponding dts file.
>>
>> Signed-off-by: Dmitry Lavnikevich <d.lavnikevich@sam-solutions.com>
> I have seen boards use the GPIO_3/6 pads instead of EIM_D17/D18 for
> I2C3, but the EIM_D17/D18 are indeed documented as "I2C1" pins at the
> pfla02 connector level.
>
> regards
> Philipp
>
Yes, that is why I thought about moving it into pfla02. But apart from
it, i2c2grp i2c3grp nodes was wrongly placed under iomuxc node while
it should be grouped inside of it, like in imx6q-phytec-pfla02 to
which it was moved with this patch.
Because of this specified i2c wasn't working correctly and caused
messages:
imx6q-pinctrl 20e0000.iomuxc: no groups defined in
/soc/aips-bus@02000000/iomuxc@020e0000/i2c2grp
imx6q-pinctrl 20e0000.iomuxc: no groups defined in
/soc/aips-bus@02000000/iomuxc@020e0000/i2c3grp
imx6q-pinctrl 20e0000.iomuxc: unable to find group for node i2c2grp
imx6q-pinctrl 20e0000.iomuxc: unable to find group for node i2c3grp
Added this into commit message with new patchset.
Best regards,
Lavnikevich Dmitry
next prev parent reply other threads:[~2014-09-12 15:55 UTC|newest]
Thread overview: 137+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 13:46 [PATCH 0/5] Add Phytec pbab01 audio support Dmitry Lavnikevich
2014-09-10 13:46 ` Dmitry Lavnikevich
2014-09-10 13:46 ` Dmitry Lavnikevich
2014-09-10 13:46 ` [PATCH 1/5] ARM: dts: pbab01: move i2c pins and frequency configuration into pfla02 Dmitry Lavnikevich
2014-09-10 13:46 ` Dmitry Lavnikevich
2014-09-10 13:46 ` Dmitry Lavnikevich
[not found] ` <1410356809-26179-2-git-send-email-d.lavnikevich-H6HfJ9slvY0Aspv4Qr0y0gC/G2K4zDHf@public.gmane.org>
2014-09-11 8:47 ` Philipp Zabel
2014-09-11 8:47 ` Philipp Zabel
2014-09-11 8:47 ` Philipp Zabel
[not found] ` <1410425238.4011.18.camel-+qGW7pzALmz7o/J7KWpOmN53zsg1cpMQ@public.gmane.org>
2014-09-12 15:55 ` Dmitry Lavnikevich [this message]
2014-09-12 15:55 ` Dmitry Lavnikevich
2014-09-12 15:55 ` Dmitry Lavnikevich
2014-09-10 13:46 ` [PATCH 2/5] ASoC: fsl: add imx-tlv320aic3x machine driver Dmitry Lavnikevich
2014-09-10 13:46 ` Dmitry Lavnikevich
2014-09-10 13:46 ` Dmitry Lavnikevich
2014-09-10 14:19 ` Lothar Waßmann
2014-09-10 14:19 ` Lothar Waßmann
2014-09-10 14:19 ` Lothar Waßmann
2014-09-10 14:27 ` Markus Pargmann
2014-09-10 14:27 ` [alsa-devel] " Markus Pargmann
2014-09-10 14:27 ` Markus Pargmann
2014-09-10 18:14 ` Nicolin Chen
2014-09-10 18:14 ` Nicolin Chen
[not found] ` <CAGoOwPSpkNy6uNVAjG2HgiHHscKZjL5wgVrkyGwWCmyU7x+gWg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-11 6:40 ` Markus Pargmann
2014-09-11 6:40 ` Markus Pargmann
2014-09-11 6:40 ` Markus Pargmann
2014-09-11 12:41 ` Dmitry Lavnikevich
2014-09-11 12:41 ` Dmitry Lavnikevich
2014-09-11 12:41 ` Dmitry Lavnikevich
[not found] ` <1410356809-26179-3-git-send-email-d.lavnikevich-H6HfJ9slvY0Aspv4Qr0y0gC/G2K4zDHf@public.gmane.org>
2014-09-10 18:07 ` Nicolin Chen
2014-09-10 18:07 ` Nicolin Chen
2014-09-10 18:07 ` Nicolin Chen
2014-09-10 13:46 ` [PATCH 3/5] ARM: imx_v6_v7_defconfig: enable imx-tlv320aic3x by default Dmitry Lavnikevich
2014-09-10 13:46 ` Dmitry Lavnikevich
2014-09-10 13:46 ` Dmitry Lavnikevich
2014-09-10 13:46 ` [PATCH 4/5] ARM: dts: pbab01: enable I2S audio on phyFLEX-i.MX6 boards Dmitry Lavnikevich
2014-09-10 13:46 ` Dmitry Lavnikevich
2014-09-10 13:46 ` Dmitry Lavnikevich
2014-09-10 13:46 ` [PATCH 5/5] ASoC: tlv320aic3x: fix PLL D configuration Dmitry Lavnikevich
2014-09-10 13:46 ` Dmitry Lavnikevich
2014-09-10 13:46 ` Dmitry Lavnikevich
2014-09-12 16:04 ` [PATCH v2 0/5] Add Phytec pbab01 audio support Dmitry Lavnikevich
2014-09-12 16:04 ` Dmitry Lavnikevich
2014-09-12 16:04 ` Dmitry Lavnikevich
2014-09-12 16:04 ` Dmitry Lavnikevich
2014-09-12 16:04 ` [PATCH v2 1/4] ARM: dts: pbab01: move i2c pins and frequency configuration into pfla02 Dmitry Lavnikevich
2014-09-12 16:04 ` Dmitry Lavnikevich
2014-09-12 16:04 ` Dmitry Lavnikevich
2014-09-12 16:04 ` Dmitry Lavnikevich
2014-09-12 16:04 ` [PATCH v2 2/4] ARM: dts: pbab01: enable I2S audio on phyFLEX-i.MX6 boards Dmitry Lavnikevich
2014-09-12 16:04 ` Dmitry Lavnikevich
2014-09-12 16:04 ` Dmitry Lavnikevich
2014-09-12 16:14 ` Alexander Shiyan
2014-09-12 16:14 ` Alexander Shiyan
2014-09-12 16:14 ` Alexander Shiyan
2014-09-12 16:14 ` Alexander Shiyan
2014-09-15 12:04 ` Dmitry Lavnikevich
2014-09-15 12:04 ` Dmitry Lavnikevich
2014-09-15 12:04 ` Dmitry Lavnikevich
2014-09-12 16:26 ` Alexander Shiyan
2014-09-12 16:26 ` Alexander Shiyan
2014-09-12 16:26 ` Alexander Shiyan
2014-09-12 16:40 ` [alsa-devel] " Fabio Estevam
2014-09-12 16:40 ` Fabio Estevam
2014-09-15 12:07 ` Dmitry Lavnikevich
2014-09-15 12:07 ` Dmitry Lavnikevich
2014-09-15 12:07 ` Dmitry Lavnikevich
2014-09-16 1:46 ` Shawn Guo
2014-09-16 1:46 ` Shawn Guo
2014-09-16 1:46 ` Shawn Guo
2014-09-12 16:04 ` [PATCH v2 3/4] ARM: imx_v6_v7_defconfig: enable tlv320aic3x and simple-audio-card by default Dmitry Lavnikevich
2014-09-12 16:04 ` Dmitry Lavnikevich
2014-09-12 16:04 ` Dmitry Lavnikevich
2014-09-12 16:04 ` [PATCH v2 4/4] ASoC: tlv320aic3x: fix PLL D configuration Dmitry Lavnikevich
2014-09-12 16:04 ` Dmitry Lavnikevich
2014-09-12 16:04 ` Dmitry Lavnikevich
2014-09-16 8:08 ` [PATCH v3 0/4] Add Phytec pbab01 audio support Dmitry Lavnikevich
2014-09-16 8:08 ` Dmitry Lavnikevich
2014-09-16 8:08 ` Dmitry Lavnikevich
2014-09-16 8:08 ` [PATCH v3 1/4] ARM: dts: pbab01: move i2c pins and frequency configuration into pfla02 Dmitry Lavnikevich
2014-09-16 8:08 ` Dmitry Lavnikevich
2014-09-16 8:08 ` Dmitry Lavnikevich
2014-09-16 8:08 ` Dmitry Lavnikevich
2014-09-16 8:08 ` [PATCH v3 2/4] ARM: dts: pbab01: enable I2S audio on phyFLEX-i.MX6 boards Dmitry Lavnikevich
2014-09-16 8:08 ` Dmitry Lavnikevich
2014-09-16 8:08 ` Dmitry Lavnikevich
2014-09-16 8:08 ` Dmitry Lavnikevich
2014-10-01 12:11 ` Fabio Estevam
2014-10-01 12:11 ` Fabio Estevam
[not found] ` <CAOMZO5CgrQ6Wf6kStga40TUKx9dARygCNB4OYSUoG3c8eUYbrA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-01 13:40 ` Dmitry Lavnikevich
2014-10-01 13:40 ` Dmitry Lavnikevich
2014-10-01 13:40 ` Dmitry Lavnikevich
[not found] ` <542C0441.5080508-H6HfJ9slvY0Aspv4Qr0y0gC/G2K4zDHf@public.gmane.org>
2014-10-01 13:45 ` Fabio Estevam
2014-10-01 13:45 ` Fabio Estevam
2014-10-01 13:45 ` Fabio Estevam
2014-10-01 13:52 ` Dmitry Lavnikevich
2014-10-01 13:52 ` Dmitry Lavnikevich
2014-10-01 13:52 ` Dmitry Lavnikevich
2014-09-16 8:08 ` [PATCH v3 3/4] ARM: imx_v6_v7_defconfig: enable tlv320aic3x audio codec by default Dmitry Lavnikevich
2014-09-16 8:08 ` Dmitry Lavnikevich
2014-09-16 8:08 ` Dmitry Lavnikevich
2014-09-16 8:08 ` Dmitry Lavnikevich
2014-09-16 8:09 ` [PATCH v3 4/4] ASoC: tlv320aic3x: fix PLL D configuration Dmitry Lavnikevich
2014-09-16 8:09 ` Dmitry Lavnikevich
2014-09-16 8:09 ` Dmitry Lavnikevich
2014-09-16 8:09 ` Dmitry Lavnikevich
2014-10-03 13:18 ` [PATCH v4 0/4] Add Phytec pbab01 audio support Dmitry Lavnikevich
2014-10-03 13:18 ` Dmitry Lavnikevich
2014-10-03 13:18 ` Dmitry Lavnikevich
2014-10-03 13:18 ` [PATCH v4 1/4] ARM: dts: pbab01: move i2c pins and frequency configuration into pfla02 Dmitry Lavnikevich
2014-10-03 13:18 ` Dmitry Lavnikevich
2014-10-03 13:18 ` Dmitry Lavnikevich
[not found] ` <1412342336-25700-1-git-send-email-d.lavnikevich-H6HfJ9slvY0Aspv4Qr0y0gC/G2K4zDHf@public.gmane.org>
2014-10-03 13:18 ` [PATCH v4 2/4] ARM: dts: pbab01: enable I2S audio on phyFLEX-i.MX6 boards Dmitry Lavnikevich
2014-10-03 13:18 ` Dmitry Lavnikevich
2014-10-03 13:18 ` Dmitry Lavnikevich
2014-10-03 13:18 ` [PATCH v4 3/4] ARM: imx_v6_v7_defconfig: enable tlv320aic3x audio codec by default Dmitry Lavnikevich
2014-10-03 13:18 ` Dmitry Lavnikevich
2014-10-03 13:18 ` Dmitry Lavnikevich
2014-10-03 13:18 ` [PATCH v4 4/4] ASoC: tlv320aic3x: fix PLL D configuration Dmitry Lavnikevich
2014-10-03 13:18 ` Dmitry Lavnikevich
2014-10-03 13:18 ` Dmitry Lavnikevich
[not found] ` <1412342336-25700-5-git-send-email-d.lavnikevich-H6HfJ9slvY0Aspv4Qr0y0gC/G2K4zDHf@public.gmane.org>
2014-10-03 15:08 ` Mark Brown
2014-10-03 15:08 ` Mark Brown
2014-10-03 15:08 ` Mark Brown
2014-10-03 15:22 ` Dmitry Lavnikevich
2014-10-22 9:08 ` [PATCH v4 0/3 RESEND] Add Phytec pbab01 audio support Dmitry Lavnikevich
2014-10-22 9:08 ` Dmitry Lavnikevich
2014-10-22 9:08 ` Dmitry Lavnikevich
[not found] ` <1413968914-13689-1-git-send-email-d.lavnikevich-H6HfJ9slvY0Aspv4Qr0y0gC/G2K4zDHf@public.gmane.org>
2014-10-22 9:08 ` [PATCH v4 RESEND 1/3] ARM: dts: pbab01: move i2c pins and frequency configuration into pfla02 Dmitry Lavnikevich
2014-10-22 9:08 ` Dmitry Lavnikevich
2014-10-22 9:08 ` Dmitry Lavnikevich
2014-10-22 9:12 ` [PATCH v4 RESEND 2/3] ARM: dts: pbab01: enable I2S audio on phyFLEX-i.MX6 boards Dmitry Lavnikevich
2014-10-22 9:12 ` Dmitry Lavnikevich
2014-10-22 9:12 ` Dmitry Lavnikevich
2014-10-22 9:11 ` [PATCH v4 RESEND 3/3] ARM: imx_v6_v7_defconfig: enable tlv320aic3x audio codec by default Dmitry Lavnikevich
2014-10-22 9:11 ` Dmitry Lavnikevich
2014-10-22 9:11 ` Dmitry Lavnikevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54131782.2000204@sam-solutions.net \
--to=d.lavnikevich-h6hfj9slvy2ikusvnlsyvv6hyfs7nttn@public.gmane.org \
--cc=Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=d.lavnikevich-H6HfJ9slvY0Aspv4Qr0y0gC/G2K4zDHf@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=perex-/Fr2/VpizcU@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=timur-N01EOCouUvQ@public.gmane.org \
--cc=tiwai-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.