All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, marc.zyngier@arm.com,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 1/6] target-arm: kvm: save/restore mp state
Date: Thu, 26 Feb 2015 13:57:52 +0100	[thread overview]
Message-ID: <54EF1850.5050002@redhat.com> (raw)
In-Reply-To: <1424880159-29348-2-git-send-email-alex.bennee@linaro.org>



On 25/02/2015 17:02, Alex Bennée wrote:
> +#if defined CONFIG_KVM
> +        {
> +            .name = "mp_state",
> +            .version_id = 0,
> +            .size = sizeof(uint32_t),
> +            .info = &vmstate_mpstate,
> +            .flags = VMS_SINGLE,
> +            .offset = 0,
> +        },
> +#endif

This makes TCG migration state incompatible depending on whether QEMU
was built on ARM or x86.

You can instead add a subsection, and mark it as needed only iff
kvm_enabled().

Paolo

>          {
>              .name = "cpsr",
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: pbonzini@redhat.com (Paolo Bonzini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] target-arm: kvm: save/restore mp state
Date: Thu, 26 Feb 2015 13:57:52 +0100	[thread overview]
Message-ID: <54EF1850.5050002@redhat.com> (raw)
In-Reply-To: <1424880159-29348-2-git-send-email-alex.bennee@linaro.org>



On 25/02/2015 17:02, Alex Benn?e wrote:
> +#if defined CONFIG_KVM
> +        {
> +            .name = "mp_state",
> +            .version_id = 0,
> +            .size = sizeof(uint32_t),
> +            .info = &vmstate_mpstate,
> +            .flags = VMS_SINGLE,
> +            .offset = 0,
> +        },
> +#endif

This makes TCG migration state incompatible depending on whether QEMU
was built on ARM or x86.

You can instead add a subsection, and mark it as needed only iff
kvm_enabled().

Paolo

>          {
>              .name = "cpsr",

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	kvm@vger.kernel.org, marc.zyngier@arm.com,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org
Subject: Re: [Qemu-devel] [PATCH 1/6] target-arm: kvm: save/restore mp state
Date: Thu, 26 Feb 2015 13:57:52 +0100	[thread overview]
Message-ID: <54EF1850.5050002@redhat.com> (raw)
In-Reply-To: <1424880159-29348-2-git-send-email-alex.bennee@linaro.org>



On 25/02/2015 17:02, Alex Bennée wrote:
> +#if defined CONFIG_KVM
> +        {
> +            .name = "mp_state",
> +            .version_id = 0,
> +            .size = sizeof(uint32_t),
> +            .info = &vmstate_mpstate,
> +            .flags = VMS_SINGLE,
> +            .offset = 0,
> +        },
> +#endif

This makes TCG migration state incompatible depending on whether QEMU
was built on ARM or x86.

You can instead add a subsection, and mark it as needed only iff
kvm_enabled().

Paolo

>          {
>              .name = "cpsr",

  parent reply	other threads:[~2015-02-26 12:52 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25 16:02 [PATCH 0/6] QEMU ARM64 Migration Fixes Alex Bennée
2015-02-25 16:02 ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02 ` Alex Bennée
2015-02-25 16:02 ` [PATCH 1/6] target-arm: kvm: save/restore mp state Alex Bennée
2015-02-25 16:02   ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02   ` Alex Bennée
2015-02-25 23:36   ` Peter Maydell
2015-02-25 23:36     ` [Qemu-devel] " Peter Maydell
2015-02-25 23:36     ` Peter Maydell
2015-03-03 10:56     ` Alex Bennée
2015-03-03 10:56       ` [Qemu-devel] " Alex Bennée
2015-03-03 10:56       ` Alex Bennée
2015-03-03 11:06       ` Paolo Bonzini
2015-03-03 11:06         ` [Qemu-devel] " Paolo Bonzini
2015-03-03 11:06         ` Paolo Bonzini
2015-03-03 11:51         ` Peter Maydell
2015-03-03 11:51           ` [Qemu-devel] " Peter Maydell
2015-03-03 11:51           ` Peter Maydell
2015-03-03 16:30           ` Alex Bennée
2015-03-03 16:30             ` [Qemu-devel] " Alex Bennée
2015-03-03 16:30             ` Alex Bennée
2015-03-03 17:10             ` Paolo Bonzini
2015-03-03 17:10               ` [Qemu-devel] " Paolo Bonzini
2015-03-03 17:10               ` Paolo Bonzini
2015-02-26 12:57   ` Paolo Bonzini [this message]
2015-02-26 12:57     ` [Qemu-devel] " Paolo Bonzini
2015-02-26 12:57     ` Paolo Bonzini
2015-02-25 16:02 ` [PATCH 2/6] arm_gic_kvm.c: restore config before pending IRQs Alex Bennée
2015-02-25 16:02   ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02   ` Alex Bennée
2015-03-02 22:14   ` Christoffer Dall
2015-03-02 22:14     ` [Qemu-devel] " Christoffer Dall
2015-03-02 22:14     ` Christoffer Dall
2015-02-25 16:02 ` [PATCH 3/6] hw/char/pl011: don't keep setting the IRQ if nothing changed Alex Bennée
2015-02-25 16:02   ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02   ` Alex Bennée
2015-02-25 16:02 ` [PATCH 4/6] target-arm/kvm64.c: sync FP register state Alex Bennée
2015-02-25 16:02   ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02   ` Alex Bennée
2015-02-25 16:02 ` [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR registers Alex Bennée
2015-02-25 16:02   ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02   ` Alex Bennée
2015-02-25 16:02 ` [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs Alex Bennée
2015-02-25 16:02   ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02   ` Alex Bennée
2015-03-02 17:22   ` Christoffer Dall
2015-03-02 17:22     ` [Qemu-devel] " Christoffer Dall
2015-03-02 17:22     ` Christoffer Dall
2015-03-03 11:28     ` Alex Bennée
2015-03-03 11:28       ` [Qemu-devel] " Alex Bennée
2015-03-03 11:28       ` Alex Bennée
2015-03-09 12:56       ` Christoffer Dall
2015-03-09 12:56         ` [Qemu-devel] " Christoffer Dall
2015-03-09 12:56         ` Christoffer Dall
2015-03-09 13:31         ` Peter Maydell
2015-03-09 13:31           ` [Qemu-devel] " Peter Maydell
2015-03-09 13:31           ` Peter Maydell
2015-03-09 16:25           ` Alex Bennée
2015-03-09 16:25             ` [Qemu-devel] " Alex Bennée
2015-03-09 16:25             ` Alex Bennée
2015-03-09 16:25             ` Alex Bennée
2015-03-09 19:31           ` Christoffer Dall
2015-03-09 19:31             ` [Qemu-devel] " Christoffer Dall
2015-03-09 19:31             ` Christoffer Dall
2015-02-25 16:02 ` [PATCH 6/6] target-arm/cpu.h: document why env->spsr exists Alex Bennée
2015-02-25 16:02   ` [Qemu-devel] " Alex Bennée
2015-02-25 16:02   ` Alex Bennée
2015-03-11 15:39   ` [Qemu-devel] " Greg Bellows
2015-03-11 15:39     ` Greg Bellows
2015-03-11 15:39     ` Greg Bellows
2015-03-11 15:47   ` Peter Maydell
2015-03-11 15:47     ` [Qemu-devel] " Peter Maydell
2015-03-11 15:47     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EF1850.5050002@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.