All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Scott Wood <scottwood@freescale.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alexander Graf <agraf@suse.de>,
	Bogdan Purcareata <bogdan.purcareata@freescale.com>,
	mihai.caraman@freescale.com, Thomas Gleixner <tglx@linutronix.de>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 0/2] powerpc/kvm: Enable running guests on RT Linux
Date: Thu, 26 Feb 2015 14:02:38 +0100	[thread overview]
Message-ID: <54EF196E.4090805@redhat.com> (raw)
In-Reply-To: <1424734051.4698.17.camel@freescale.com>



On 24/02/2015 00:27, Scott Wood wrote:
> This isn't a host PIC driver.  It's guest PIC emulation, some of which
> is indeed not suitable for a rawlock (in particular, openpic_update_irq
> which loops on the number of vcpus, with a loop body that calls
> IRQ_check() which loops over all pending IRQs).

The question is what behavior is wanted of code that isn't quite
RT-ready.  What is preferred, bugs or bad latency?

If the answer is bad latency (which can be avoided simply by not running
KVM on a RT kernel in production), patch 1 can be applied.  If the
answer is bugs, patch 1 is not upstream material.

I myself prefer to have bad latency; if something takes a spinlock in
atomic context, that spinlock should be raw.  If it hurts (latency),
don't do it (use the affected code).

Paolo

> The vcpu limits are a
> temporary bandaid to avoid the worst latencies, but I'm still skeptical
> about this being upstream material.

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Scott Wood <scottwood@freescale.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Alexander Graf <agraf@suse.de>,
	Bogdan Purcareata <bogdan.purcareata@freescale.com>,
	linuxppc-dev@lists.ozlabs.org, linux-rt-users@vger.kernel.org,
	linux-kernel@vger.kernel.org, mihai.caraman@freescale.com,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 0/2] powerpc/kvm: Enable running guests on RT Linux
Date: Thu, 26 Feb 2015 14:02:38 +0100	[thread overview]
Message-ID: <54EF196E.4090805@redhat.com> (raw)
In-Reply-To: <1424734051.4698.17.camel@freescale.com>



On 24/02/2015 00:27, Scott Wood wrote:
> This isn't a host PIC driver.  It's guest PIC emulation, some of which
> is indeed not suitable for a rawlock (in particular, openpic_update_irq
> which loops on the number of vcpus, with a loop body that calls
> IRQ_check() which loops over all pending IRQs).

The question is what behavior is wanted of code that isn't quite
RT-ready.  What is preferred, bugs or bad latency?

If the answer is bad latency (which can be avoided simply by not running
KVM on a RT kernel in production), patch 1 can be applied.  If the
answer is bugs, patch 1 is not upstream material.

I myself prefer to have bad latency; if something takes a spinlock in
atomic context, that spinlock should be raw.  If it hurts (latency),
don't do it (use the affected code).

Paolo

> The vcpu limits are a
> temporary bandaid to avoid the worst latencies, but I'm still skeptical
> about this being upstream material.

  parent reply	other threads:[~2015-02-26 13:03 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18  9:32 [PATCH 0/2] powerpc/kvm: Enable running guests on RT Linux Bogdan Purcareata
2015-02-18  9:32 ` Bogdan Purcareata
2015-02-18  9:32 ` [PATCH 1/2] powerpc/kvm: Convert openpic lock to raw_spinlock Bogdan Purcareata
2015-02-18  9:32   ` Bogdan Purcareata
2015-02-23 22:43   ` Scott Wood
2015-02-23 22:43     ` Scott Wood
2015-02-18  9:32 ` [PATCH 2/2] powerpc/kvm: Limit MAX_VCPUS for guests running on RT Linux Bogdan Purcareata
2015-02-18  9:32   ` Bogdan Purcareata
2015-02-18  9:36   ` Sebastian Andrzej Siewior
2015-02-18  9:36     ` Sebastian Andrzej Siewior
2015-02-20 13:45   ` Alexander Graf
2015-02-20 13:45     ` Alexander Graf
2015-02-23 22:48     ` Scott Wood
2015-02-23 22:48       ` Scott Wood
2015-02-20 13:45 ` [PATCH 0/2] powerpc/kvm: Enable running guests " Alexander Graf
2015-02-20 13:45   ` Alexander Graf
2015-02-20 14:12   ` Paolo Bonzini
2015-02-20 14:12     ` Paolo Bonzini
2015-02-20 14:16     ` Alexander Graf
2015-02-20 14:16       ` Alexander Graf
2015-02-20 14:54     ` Sebastian Andrzej Siewior
2015-02-20 14:54       ` Sebastian Andrzej Siewior
2015-02-20 14:57       ` Paolo Bonzini
2015-02-20 14:57         ` Paolo Bonzini
2015-02-20 15:06         ` Sebastian Andrzej Siewior
2015-02-20 15:06           ` Sebastian Andrzej Siewior
2015-02-20 15:10           ` Paolo Bonzini
2015-02-20 15:10             ` Paolo Bonzini
2015-02-20 15:17             ` Sebastian Andrzej Siewior
2015-02-20 15:17               ` Sebastian Andrzej Siewior
2015-02-23  8:12               ` Purcareata Bogdan
2015-02-23  8:12                 ` Purcareata Bogdan
2015-02-23  7:50           ` Purcareata Bogdan
2015-02-23  7:50             ` Purcareata Bogdan
2015-02-23  7:29       ` Purcareata Bogdan
2015-02-23  7:29         ` Purcareata Bogdan
2015-02-23 23:27       ` Scott Wood
2015-02-23 23:27         ` Scott Wood
2015-02-23 23:27         ` Scott Wood
2015-02-25 16:36         ` Sebastian Andrzej Siewior
2015-02-25 16:36           ` Sebastian Andrzej Siewior
2015-02-26 13:02         ` Paolo Bonzini [this message]
2015-02-26 13:02           ` Paolo Bonzini
2015-02-26 13:31           ` Sebastian Andrzej Siewior
2015-02-26 13:31             ` Sebastian Andrzej Siewior
2015-02-27  1:05             ` Scott Wood
2015-02-27  1:05               ` Scott Wood
2015-02-27 13:06               ` Paolo Bonzini
2015-02-27 13:06                 ` Paolo Bonzini
2015-03-27 17:07               ` Purcareata Bogdan
2015-03-27 17:07                 ` Purcareata Bogdan
2015-04-02 23:11                 ` Scott Wood
2015-04-02 23:11                   ` Scott Wood
2015-04-03  8:07                   ` Purcareata Bogdan
2015-04-03  8:07                     ` Purcareata Bogdan
2015-04-03 21:26                     ` Scott Wood
2015-04-03 21:26                       ` Scott Wood
2015-04-09  7:44                       ` Purcareata Bogdan
2015-04-09  7:44                         ` Purcareata Bogdan
2015-04-09  7:44                         ` Purcareata Bogdan
2015-04-09 23:53                         ` Scott Wood
2015-04-09 23:53                           ` Scott Wood
2015-04-20 10:53                           ` Purcareata Bogdan
2015-04-20 10:53                             ` Purcareata Bogdan
2015-04-21  0:52                             ` Scott Wood
2015-04-21  0:52                               ` Scott Wood
2015-04-22 12:06                               ` Purcareata Bogdan
2015-04-22 12:06                                 ` Purcareata Bogdan
2015-04-22 12:06                                 ` Purcareata Bogdan
2015-04-23  0:30                                 ` Scott Wood
2015-04-23  0:30                                   ` Scott Wood
2015-04-23 12:31                                   ` Purcareata Bogdan
2015-04-23 12:31                                     ` Purcareata Bogdan
2015-04-23 12:31                                     ` Purcareata Bogdan
2015-04-23 21:26                                     ` Scott Wood
2015-04-23 21:26                                       ` Scott Wood
2015-04-27  6:45                                       ` Purcareata Bogdan
2015-04-27  6:45                                         ` Purcareata Bogdan
2015-04-27  6:45                                         ` Purcareata Bogdan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EF196E.4090805@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=bigeasy@linutronix.de \
    --cc=bogdan.purcareata@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mihai.caraman@freescale.com \
    --cc=scottwood@freescale.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.