[PATCH v2] remove now unnecessary gc from libxl__async_exec_start calls

[PATCH v2] remove now unnecessary gc from libxl__async_exec_start calls

[Wen Congyang]

These were removed in commit f5f8400f.

Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
---
 tools/libxl/libxl_netbuffer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/libxl/libxl_netbuffer.c b/tools/libxl/libxl_netbuffer.c
index ff2d6c7..107e867 100644
--- a/tools/libxl/libxl_netbuffer.c
+++ b/tools/libxl/libxl_netbuffer.c
@@ -310,7 +310,7 @@ static void nic_setup(libxl__egc *egc, libxl__remus_device *dev)
     }
 
     setup_async_exec(dev, "setup");
-    rc = libxl__async_exec_start(gc, &dev->aodev.aes);
+    rc = libxl__async_exec_start(&dev->aodev.aes);
     if (rc)
         goto out;
 
@@ -402,7 +402,7 @@ static void nic_teardown(libxl__egc *egc, libxl__remus_device *dev)
 
     setup_async_exec(dev, "teardown");
 
-    rc = libxl__async_exec_start(gc, &dev->aodev.aes);
+    rc = libxl__async_exec_start(&dev->aodev.aes);
     if (rc)
         goto out;
 
-- 
2.4.3

Re: [PATCH v2] remove now unnecessary gc from libxl__async_exec_start calls

[Ian Jackson]

Wen Congyang writes ("[PATCH v2] remove now unnecessary gc from libxl__async_exec_start calls"):
> These were removed in commit f5f8400f.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

And I have committed it (with `libxl:' added to the front of the
Subject).

Thanks,
Ian.

Re: [PATCH v2] remove now unnecessary gc from libxl__async_exec_start calls

[Andrew Cooper]

On 30/06/15 09:55, Wen Congyang wrote:
> These were removed in commit f5f8400f.
>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> ---
>  tools/libxl/libxl_netbuffer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libxl/libxl_netbuffer.c b/tools/libxl/libxl_netbuffer.c
> index ff2d6c7..107e867 100644
> --- a/tools/libxl/libxl_netbuffer.c
> +++ b/tools/libxl/libxl_netbuffer.c
> @@ -310,7 +310,7 @@ static void nic_setup(libxl__egc *egc, libxl__remus_device *dev)
>      }
>  
>      setup_async_exec(dev, "setup");
> -    rc = libxl__async_exec_start(gc, &dev->aodev.aes);
> +    rc = libxl__async_exec_start(&dev->aodev.aes);
>      if (rc)
>          goto out;
>  
> @@ -402,7 +402,7 @@ static void nic_teardown(libxl__egc *egc, libxl__remus_device *dev)
>  
>      setup_async_exec(dev, "teardown");
>  
> -    rc = libxl__async_exec_start(gc, &dev->aodev.aes);
> +    rc = libxl__async_exec_start(&dev->aodev.aes);
>      if (rc)
>          goto out;
>  

Can OSS test be updated to build the remus bits of libxl?  This failure
should not have been able to pass the push gate.

~Andrew

Re: [PATCH v2] remove now unnecessary gc from libxl__async_exec_start calls

[Ian Jackson]

Andrew Cooper writes ("Re: [Xen-devel] [PATCH v2] remove now unnecessary gc from libxl__async_exec_start calls"):
> On 30/06/15 09:55, Wen Congyang wrote:
> > These were removed in commit f5f8400f.
...
> > -    rc = libxl__async_exec_start(gc, &dev->aodev.aes);
> > +    rc = libxl__async_exec_start(&dev->aodev.aes);
> 
> Can OSS test be updated to build the remus bits of libxl?  This failure
> should not have been able to pass the push gate.

I haven't investigated why this is disabled in osstest's builds.  Did
you check one of its build logs ?  They contain the `configure'
output.

Ian.

Re: [PATCH v2] remove now unnecessary gc from libxl__async_exec_start calls

[Ian Campbell]

On Tue, 2015-06-30 at 10:40 +0100, Ian Jackson wrote:
> Andrew Cooper writes ("Re: [Xen-devel] [PATCH v2] remove now unnecessary gc from libxl__async_exec_start calls"):
> > On 30/06/15 09:55, Wen Congyang wrote:
> > > These were removed in commit f5f8400f.
> ...
> > > -    rc = libxl__async_exec_start(gc, &dev->aodev.aes);
> > > +    rc = libxl__async_exec_start(&dev->aodev.aes);
> > 
> > Can OSS test be updated to build the remus bits of libxl?  This failure
> > should not have been able to pass the push gate.
> 
> I haven't investigated why this is disabled in osstest's builds.

Roger was jsut asking about libnl-dev and ts-xen-build-prep on IRC. I
suspect he may be investigating...

> Did you check one of its build logs ?  They contain the `configure'
> output.

Roger pointed at 
http://logs.test-lab.xenproject.org/osstest/logs/58974/build-amd64/5.ts-xen-build.log

Which has:
        Checking for LIBNL3... no
        configure: WARNING: Disabling support for Remus network buffering.
            Please install libnl3 libraries, command line tools and devel
            headers - version 3.2.8 or higher
        
But Wheezy has libnl-dev 1.1-7, which I think it might just be too old.
It also has libnl-3-dev which is 3.2.7 in Wheezy, i.e. still not quite
new enough.

Jessie has 3.2.24 which will be more than sufficient.

I think the upshot is that it is pointless installing libnl-dev on
Wheezy, at least for current Xen maybe older branches worked with older
libnl, I didn't check...

Ian.