All of lore.kernel.org
 help / color / mirror / Atom feed
From: michal.simek@xilinx.com (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFCv3 1/4] docs: dts: Added documentation for Xilinx Zynq Reset Controller bindings.
Date: Tue, 4 Aug 2015 10:18:54 +0200	[thread overview]
Message-ID: <55C0756E.8050003@xilinx.com> (raw)
In-Reply-To: <1438675772.3793.18.camel@pengutronix.de>

On 08/04/2015 10:09 AM, Philipp Zabel wrote:
> Hi Moritz,
> 
> Am Donnerstag, den 30.07.2015, 18:13 -0700 schrieb Moritz Fischer:
>> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
>> ---
>>  .../devicetree/bindings/reset/zynq-reset.txt       | 68 ++++++++++++++++++++++
>>  1 file changed, 68 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/reset/zynq-reset.txt
>>
>> diff --git a/Documentation/devicetree/bindings/reset/zynq-reset.txt b/Documentation/devicetree/bindings/reset/zynq-reset.txt
>> new file mode 100644
>> index 0000000..498c037a
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/reset/zynq-reset.txt
>> @@ -0,0 +1,68 @@
>> +Xilinx Zynq Reset Manager
>> +
>> +The Zynq AP-SoC has several different resets.
>> +
>> +See Chapter 26 of the Zynq TRM (UG585) for more information about Zynq resets.
>> +
>> +Required properties:
>> +- compatible: "xlnx,zynq-reset"
>> +- reg: SLCR offset and size taken via syscon <0x200 0x48>
>> +- syscon: <&slcr>
>> +  This should be a phandle to the Zynq's SLCR register.
> 
>                                                  ^ register singular?
> 
> I still think the syscon phandle property is superfluous,
> but I'm fine with keeping it for consistency.
> It could always be made optional later.

Great.

Philipp: I expect you want to take at least 1/4 and 3/4 via your tree.
I am fine if you also want to add 2/4 and 4/4 via your tree.
If you think that they should go via arm-soc please let me know and I
will add them to the queue.

Thanks,
Michal

WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@xilinx.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
	Moritz Fischer <moritz.fischer@ettus.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux@arm.linux.org.uk, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, michal.simek@xilinx.com,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org, galak@codeaurora.org,
	soren.brinkmann@xilinx.com
Subject: Re: [RFCv3 1/4] docs: dts: Added documentation for Xilinx Zynq Reset Controller bindings.
Date: Tue, 4 Aug 2015 10:18:54 +0200	[thread overview]
Message-ID: <55C0756E.8050003@xilinx.com> (raw)
In-Reply-To: <1438675772.3793.18.camel@pengutronix.de>

On 08/04/2015 10:09 AM, Philipp Zabel wrote:
> Hi Moritz,
> 
> Am Donnerstag, den 30.07.2015, 18:13 -0700 schrieb Moritz Fischer:
>> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
>> ---
>>  .../devicetree/bindings/reset/zynq-reset.txt       | 68 ++++++++++++++++++++++
>>  1 file changed, 68 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/reset/zynq-reset.txt
>>
>> diff --git a/Documentation/devicetree/bindings/reset/zynq-reset.txt b/Documentation/devicetree/bindings/reset/zynq-reset.txt
>> new file mode 100644
>> index 0000000..498c037a
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/reset/zynq-reset.txt
>> @@ -0,0 +1,68 @@
>> +Xilinx Zynq Reset Manager
>> +
>> +The Zynq AP-SoC has several different resets.
>> +
>> +See Chapter 26 of the Zynq TRM (UG585) for more information about Zynq resets.
>> +
>> +Required properties:
>> +- compatible: "xlnx,zynq-reset"
>> +- reg: SLCR offset and size taken via syscon <0x200 0x48>
>> +- syscon: <&slcr>
>> +  This should be a phandle to the Zynq's SLCR register.
> 
>                                                  ^ register singular?
> 
> I still think the syscon phandle property is superfluous,
> but I'm fine with keeping it for consistency.
> It could always be made optional later.

Great.

Philipp: I expect you want to take at least 1/4 and 3/4 via your tree.
I am fine if you also want to add 2/4 and 4/4 via your tree.
If you think that they should go via arm-soc please let me know and I
will add them to the queue.

Thanks,
Michal

WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@xilinx.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
	Moritz Fischer <moritz.fischer@ettus.com>
Cc: <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
	<linux@arm.linux.org.uk>, <pawel.moll@arm.com>,
	<ijc+devicetree@hellion.org.uk>, <michal.simek@xilinx.com>,
	<linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <galak@codeaurora.org>,
	<soren.brinkmann@xilinx.com>
Subject: Re: [RFCv3 1/4] docs: dts: Added documentation for Xilinx Zynq Reset Controller bindings.
Date: Tue, 4 Aug 2015 10:18:54 +0200	[thread overview]
Message-ID: <55C0756E.8050003@xilinx.com> (raw)
In-Reply-To: <1438675772.3793.18.camel@pengutronix.de>

On 08/04/2015 10:09 AM, Philipp Zabel wrote:
> Hi Moritz,
> 
> Am Donnerstag, den 30.07.2015, 18:13 -0700 schrieb Moritz Fischer:
>> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
>> ---
>>  .../devicetree/bindings/reset/zynq-reset.txt       | 68 ++++++++++++++++++++++
>>  1 file changed, 68 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/reset/zynq-reset.txt
>>
>> diff --git a/Documentation/devicetree/bindings/reset/zynq-reset.txt b/Documentation/devicetree/bindings/reset/zynq-reset.txt
>> new file mode 100644
>> index 0000000..498c037a
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/reset/zynq-reset.txt
>> @@ -0,0 +1,68 @@
>> +Xilinx Zynq Reset Manager
>> +
>> +The Zynq AP-SoC has several different resets.
>> +
>> +See Chapter 26 of the Zynq TRM (UG585) for more information about Zynq resets.
>> +
>> +Required properties:
>> +- compatible: "xlnx,zynq-reset"
>> +- reg: SLCR offset and size taken via syscon <0x200 0x48>
>> +- syscon: <&slcr>
>> +  This should be a phandle to the Zynq's SLCR register.
> 
>                                                  ^ register singular?
> 
> I still think the syscon phandle property is superfluous,
> but I'm fine with keeping it for consistency.
> It could always be made optional later.

Great.

Philipp: I expect you want to take at least 1/4 and 3/4 via your tree.
I am fine if you also want to add 2/4 and 4/4 via your tree.
If you think that they should go via arm-soc please let me know and I
will add them to the queue.

Thanks,
Michal

  reply	other threads:[~2015-08-04  8:18 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31  1:13 [RFCv3 0/4] Adding support for Zynq Reset Controller Moritz Fischer
2015-07-31  1:13 ` Moritz Fischer
2015-07-31  1:13 ` [RFCv3 1/4] docs: dts: Added documentation for Xilinx Zynq Reset Controller bindings Moritz Fischer
2015-07-31  1:13   ` Moritz Fischer
2015-08-04  8:09   ` Philipp Zabel
2015-08-04  8:09     ` Philipp Zabel
2015-08-04  8:09     ` Philipp Zabel
2015-08-04  8:18     ` Michal Simek [this message]
2015-08-04  8:18       ` Michal Simek
2015-08-04  8:18       ` Michal Simek
2015-08-04 15:05     ` Moritz Fischer
2015-08-04 15:05       ` Moritz Fischer
2015-08-04 15:10       ` Philipp Zabel
2015-08-04 15:10         ` Philipp Zabel
2015-08-05 19:43         ` Moritz Fischer
2015-08-05 19:43           ` Moritz Fischer
2015-08-05 19:43           ` Moritz Fischer
2015-08-06  4:54           ` Michal Simek
2015-08-06  4:54             ` Michal Simek
2015-08-06  4:54             ` Michal Simek
2015-07-31  1:13 ` [RFCv3 2/4] dts: zynq: Add devicetree entry for Xilinx Zynq reset controller Moritz Fischer
2015-07-31  1:13   ` Moritz Fischer
2015-08-04  8:13   ` Michal Simek
2015-08-04  8:13     ` Michal Simek
2015-08-04  8:13     ` Michal Simek
2015-07-31  1:13 ` [RFCv3 3/4] reset: reset-zynq: Adding support " Moritz Fischer
2015-07-31  1:13   ` Moritz Fischer
2015-07-31  1:13 ` [RFCv3 4/4] ARM: zynq: Select ARCH_HAS_RESET_CONTROLLER Moritz Fischer
2015-07-31  1:13   ` Moritz Fischer
2015-07-31  8:09   ` Michal Simek
2015-07-31  8:09     ` Michal Simek
2015-07-31  8:09     ` Michal Simek
2015-07-31 16:47     ` Sören Brinkmann
2015-07-31 16:47       ` Sören Brinkmann
2015-07-31 16:47       ` Sören Brinkmann
2015-08-04  8:38       ` Philipp Zabel
2015-08-04  8:38         ` Philipp Zabel
2015-08-04  8:38         ` Philipp Zabel
2015-08-04 14:11         ` Sören Brinkmann
2015-08-04 14:11           ` Sören Brinkmann
2015-08-04 14:11           ` Sören Brinkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C0756E.8050003@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.