From: Peter Hurley <peter@hurleysoftware.com>
To: Jun Nie <jun.nie@linaro.org>, Timur Tabi <timur@codeaurora.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "jason.liu@linaro.org" <jason.liu@linaro.org>,
Andre Przywara <andre.przywara@arm.com>,
Andrew Jackson <Andrew.Jackson@arm.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"wan.zhijun@zte.com.cn" <wan.zhijun@zte.com.cn>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v13 5/5] uart: pl011: Add support to ZTE ZX296702 uart
Date: Tue, 27 Oct 2015 09:31:13 -0400 [thread overview]
Message-ID: <562F7CA1.5080100@hurleysoftware.com> (raw)
In-Reply-To: <CABymUCMAc59SCBnji8bcHkYzuFMbA3GMZL0Cv6ReuK=27kBW4Q@mail.gmail.com>
On 10/25/2015 09:27 PM, Jun Nie wrote:
> 2015-10-24 11:32 GMT+08:00 Timur Tabi <timur@codeaurora.org>:
>> Jun Nie wrote:
>>>
>>> I am OK to add a new driver for ZTE UART if no other's objection
>>> though I do not agree you. Without this last patch, other patches are
>>> just for minor refactor for register access.
>>
>>
>> In that case, my vote is to drop the whole patchset. Just copy/paste the
>> amba-pl011 driver and make whatever changes you need. That sort of thing
>> happens all the time.
>
> Greg, Peter & Russell,
>
> What's your opinion on this separate UART driver suggestion?
That's crazy; fork the driver simply because the register i/o addresses
are different? No.
On the contrary, this patchset directly triggered important improvements to
both this driver and the ARM arch.
Regards,
Peter Hurley
WARNING: multiple messages have this Message-ID (diff)
From: peter@hurleysoftware.com (Peter Hurley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v13 5/5] uart: pl011: Add support to ZTE ZX296702 uart
Date: Tue, 27 Oct 2015 09:31:13 -0400 [thread overview]
Message-ID: <562F7CA1.5080100@hurleysoftware.com> (raw)
In-Reply-To: <CABymUCMAc59SCBnji8bcHkYzuFMbA3GMZL0Cv6ReuK=27kBW4Q@mail.gmail.com>
On 10/25/2015 09:27 PM, Jun Nie wrote:
> 2015-10-24 11:32 GMT+08:00 Timur Tabi <timur@codeaurora.org>:
>> Jun Nie wrote:
>>>
>>> I am OK to add a new driver for ZTE UART if no other's objection
>>> though I do not agree you. Without this last patch, other patches are
>>> just for minor refactor for register access.
>>
>>
>> In that case, my vote is to drop the whole patchset. Just copy/paste the
>> amba-pl011 driver and make whatever changes you need. That sort of thing
>> happens all the time.
>
> Greg, Peter & Russell,
>
> What's your opinion on this separate UART driver suggestion?
That's crazy; fork the driver simply because the register i/o addresses
are different? No.
On the contrary, this patchset directly triggered important improvements to
both this driver and the ARM arch.
Regards,
Peter Hurley
next prev parent reply other threads:[~2015-10-27 13:31 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1438328959-16177-1-git-send-email-jun.nie@linaro.org>
[not found] ` <1438328959-16177-3-git-send-email-jun.nie@linaro.org>
2015-09-18 10:51 ` [PATCH v13 2/5] uart: pl011: Introduce register accessor Andre Przywara
2015-09-18 10:51 ` Andre Przywara
2015-09-19 6:46 ` Jun Nie
2015-09-19 6:46 ` Jun Nie
2015-09-19 21:45 ` Andre Przywara
2015-09-19 21:45 ` Andre Przywara
2015-10-22 23:36 ` Timur Tabi
2015-10-22 23:36 ` Timur Tabi
2015-10-28 14:22 ` Peter Hurley
2015-10-28 14:22 ` Peter Hurley
2015-10-28 14:51 ` Timur Tabi
2015-10-28 14:51 ` Timur Tabi
2015-10-28 15:08 ` Peter Hurley
2015-10-28 15:08 ` Peter Hurley
[not found] ` <1438328959-16177-5-git-send-email-jun.nie@linaro.org>
2015-09-18 10:58 ` [PATCH v13 4/5] uart: pl011: Improve LCRH register access decision Andre Przywara
2015-09-18 10:58 ` Andre Przywara
[not found] ` <1438328959-16177-6-git-send-email-jun.nie@linaro.org>
2015-09-18 13:50 ` [PATCH v13 5/5] uart: pl011: Add support to ZTE ZX296702 uart Andre Przywara
2015-09-18 13:50 ` Andre Przywara
2015-09-18 13:59 ` Russell King - ARM Linux
2015-09-18 13:59 ` Russell King - ARM Linux
2015-09-19 6:47 ` Jun Nie
2015-09-19 6:47 ` Jun Nie
2015-09-19 6:54 ` Jun Nie
2015-09-19 6:54 ` Jun Nie
2015-10-23 21:54 ` Timur Tabi
2015-10-23 21:54 ` Timur Tabi
2015-10-24 3:23 ` Jun Nie
2015-10-24 3:23 ` Jun Nie
2015-10-24 3:32 ` Timur Tabi
2015-10-24 3:32 ` Timur Tabi
2015-10-26 1:27 ` Jun Nie
2015-10-26 1:27 ` Jun Nie
2015-10-27 13:31 ` Peter Hurley [this message]
2015-10-27 13:31 ` Peter Hurley
2015-10-26 9:59 ` Andre Przywara
2015-10-26 9:59 ` Andre Przywara
2015-10-26 12:46 ` Timur Tabi
2015-10-26 12:46 ` Timur Tabi
2015-10-26 14:00 ` Andre Przywara
2015-10-26 14:00 ` Andre Przywara
2015-10-26 14:07 ` Timur Tabi
2015-10-26 14:07 ` Timur Tabi
2015-10-26 14:42 ` Andre Przywara
2015-10-26 14:42 ` Andre Przywara
2015-10-26 14:47 ` Timur Tabi
2015-10-26 14:47 ` Timur Tabi
2015-10-26 15:19 ` Andre Przywara
2015-10-26 15:19 ` Andre Przywara
2015-10-26 15:31 ` Timur Tabi
2015-10-26 15:31 ` Timur Tabi
2015-10-27 22:54 ` Timur Tabi
2015-10-27 22:54 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F7CA1.5080100@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=Andrew.Jackson@arm.com \
--cc=andre.przywara@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jason.liu@linaro.org \
--cc=jun.nie@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=shawn.guo@linaro.org \
--cc=timur@codeaurora.org \
--cc=wan.zhijun@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.