All of lore.kernel.org
 help / color / mirror / Atom feed
From: huawei.libin@huawei.com (libin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: ftrace: stop using kstop_machine to enable/disable tracing
Date: Fri, 4 Dec 2015 09:00:40 +0800	[thread overview]
Message-ID: <5660E5B8.2050103@huawei.com> (raw)
In-Reply-To: <20151203103139.35648cc2@gandalf.local.home>


Thanks very much to Will and Steve for the wonderful comments, I will modify the
commit message, and remove the misleading comments about module text
disappearing case.

Thanks again,
Li Bin

on 2015/12/3 23:31, Steven Rostedt wrote:
> On Thu, 3 Dec 2015 15:09:26 +0000
> Will Deacon <will.deacon@arm.com> wrote:
>
>> Yeah, I think the comments on x86 and arm64 are out of date. They also
>> mention the freeing of __init sections -- is that still a concern?
> No we black list them, any section that we are not sure will be there
> when we expect it to has recordmcount.c nop out the calls to mcount and
> they are ignored. Remember the e1000e bug? This was the reproducer.
>
> Anyway, on my todo list is to allow init sections to be traced. To do
> so would mean that I need to add generic code that lets ftrace know to
> remove init sections at boot up. Right now (or at least the last time I
> checked, which was back in 2009), every arch had its own way of freeing
> init memory. If that has changed, or I can just place a hook where it
> happens (which is probably the easy part), I can allow init code to be
> traced too.
>
> -- Steve
>
>
> .
>

WARNING: multiple messages have this Message-ID (diff)
From: libin <huawei.libin@huawei.com>
To: Steven Rostedt <rostedt@goodmis.org>, Will Deacon <will.deacon@arm.com>
Cc: <mingo@redhat.com>, <catalin.marinas@arm.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <guohanjun@huawei.com>,
	<dingtianhong@huawei.com>
Subject: Re: [PATCH] arm64: ftrace: stop using kstop_machine to enable/disable tracing
Date: Fri, 4 Dec 2015 09:00:40 +0800	[thread overview]
Message-ID: <5660E5B8.2050103@huawei.com> (raw)
In-Reply-To: <20151203103139.35648cc2@gandalf.local.home>


Thanks very much to Will and Steve for the wonderful comments, I will modify the
commit message, and remove the misleading comments about module text
disappearing case.

Thanks again,
Li Bin

on 2015/12/3 23:31, Steven Rostedt wrote:
> On Thu, 3 Dec 2015 15:09:26 +0000
> Will Deacon <will.deacon@arm.com> wrote:
>
>> Yeah, I think the comments on x86 and arm64 are out of date. They also
>> mention the freeing of __init sections -- is that still a concern?
> No we black list them, any section that we are not sure will be there
> when we expect it to has recordmcount.c nop out the calls to mcount and
> they are ignored. Remember the e1000e bug? This was the reproducer.
>
> Anyway, on my todo list is to allow init sections to be traced. To do
> so would mean that I need to add generic code that lets ftrace know to
> remove init sections at boot up. Right now (or at least the last time I
> checked, which was back in 2009), every arch had its own way of freeing
> init memory. If that has changed, or I can just place a hook where it
> happens (which is probably the easy part), I can allow init code to be
> traced too.
>
> -- Steve
>
>
> .
>



  reply	other threads:[~2015-12-04  1:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-28  7:50 [PATCH] arm64: ftrace: stop using kstop_machine to enable/disable tracing Li Bin
2015-11-28  7:50 ` Li Bin
2015-11-28 15:58 ` Steven Rostedt
2015-11-28 15:58   ` Steven Rostedt
2015-11-30  2:03   ` libin
2015-11-30  2:03     ` libin
2015-12-02 12:36 ` Will Deacon
2015-12-02 12:36   ` Will Deacon
2015-12-02 13:16   ` Will Deacon
2015-12-02 13:16     ` Will Deacon
2015-12-03  9:39     ` libin
2015-12-03  9:39       ` libin
2015-12-03 11:48       ` Will Deacon
2015-12-03 11:48         ` Will Deacon
2015-12-03 15:07         ` Steven Rostedt
2015-12-03 15:07           ` Steven Rostedt
2015-12-02 14:02   ` Steven Rostedt
2015-12-02 14:02     ` Steven Rostedt
2015-12-03  9:21   ` libin
2015-12-03  9:21     ` libin
2015-12-03  9:38     ` Will Deacon
2015-12-03  9:38       ` Will Deacon
2015-12-03 15:05       ` Steven Rostedt
2015-12-03 15:05         ` Steven Rostedt
2015-12-03 15:09         ` Will Deacon
2015-12-03 15:09           ` Will Deacon
2015-12-03 15:31           ` Steven Rostedt
2015-12-03 15:31             ` Steven Rostedt
2015-12-04  1:00             ` libin [this message]
2015-12-04  1:00               ` libin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5660E5B8.2050103@huawei.com \
    --to=huawei.libin@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.