Re: [PATCH v2 4/9] drm/xe/xe_hw_error: Handle non-fatal errors routed via direct IRQ

["Tauro, Riana" <riana.tauro@intel.com>]

On 28-10-2026 21:47, Andi Shyti wrote:
> One more question here...
>
> ...
>
>>   	/*
>> -	 * Hardware errors are reported through System Controller on the platforms that
>> -	 * support it, and never routed as direct IRQ to SGUnit. So we should never be
>> -	 * here for those platforms.
>> +	 * Non fatal errors are routed as a direct IRQ on platforms that support
>> +	 * system controller.
>>   	 */
>>   	if (xe->info.has_sysctrl) {
>> -		drm_err_ratelimited(&xe->drm, HW_ERR "Invalid error routing\n");
>> +		drm_err_ratelimited(&xe->drm, HW_ERR "%s %s reported\n", hw_err_to_str(hw_err),
>> +				    severity_str);
>> +		schedule_delayed_work(&tile->hw_error_work, msecs_to_jiffies(MSEC_PER_SEC));
> why are we waiting one second here? How did you choose this time?


Its a best case scenario that if there is a non-fatal error which is 
accompanied with a fatal at the same time.
We will wait for AER to get triggered to avoid unnecessary handling of 
non-fatal errors.
It is not guaranteed that we will see a AER in 1sec because even that is 
a worker.

If this is not okay, we can drop it as we are waiting for worker to 
complete anyway.

Thanks
Riana


>
> Andi