[PATCH] Do not require console control protocol.

[PATCH] Do not require console control protocol.

[Johan Rydberg]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi,

I would like to have the following patch committed.  Some EFI
implementations do not provide a console control protocol instance,
and it is covered by neither EFI or UEFI specifications.

~j

2006-07-28  Johan Rydberg  <jrydberg@gnu.org>

        * kern/efi/efi.c (grub_efi_set_text_mode): Assume console already
        is in text mode if there is no console control protocol instance
        available.



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: grub.efi-console-control.1.patch --]
[-- Type: text/x-patch, Size: 579 bytes --]

Index: kern/efi/efi.c
===================================================================
RCS file: /sources/grub/grub2/kern/efi/efi.c,v
retrieving revision 1.7
diff -u -r1.7 efi.c
--- kern/efi/efi.c	27 May 2006 21:09:25 -0000	1.7
+++ kern/efi/efi.c	27 Jul 2006 22:01:49 -0000
@@ -125,7 +125,9 @@
 
   c = grub_efi_locate_protocol (&console_control_guid, 0);
   if (! c)
-    return 0;
+    /* No console control protocol instance available, assume it is
+       already in text mode. */
+    return 1;
   
   if (c->get_mode (c, &mode, 0, 0) != GRUB_EFI_SUCCESS)
     return 0;

Re: [PATCH] Do not require console control protocol.

[Yoshinori K. Okuji]

On Friday 28 July 2006 00:15, Johan Rydberg wrote:
> I would like to have the following patch committed.  Some EFI
> implementations do not provide a console control protocol instance,
> and it is covered by neither EFI or UEFI specifications.

Right, right. My code was only for testing, so it was not good, generally 
speaking. BTW, can I add you into the project members of GRUB so that you can 
commit patches yourself?

Thanks,
Okuji

Re: [PATCH] Do not require console control protocol.

[Johan Rydberg]

"Yoshinori K. Okuji" <okuji@enbug.org> writes:

>> I would like to have the following patch committed.  Some EFI
>> implementations do not provide a console control protocol instance,
>> and it is covered by neither EFI or UEFI specifications.
>
> Right, right. My code was only for testing, so it was not good, generally 
> speaking. BTW, can I add you into the project members of GRUB so that you can 
> commit patches yourself?

Yes, please do.

~j

Re: [PATCH] Do not require console control protocol.

[Yoshinori K. Okuji]

On Friday 28 July 2006 12:20, Johan Rydberg wrote:
> "Yoshinori K. Okuji" <okuji@enbug.org> writes:
> >> I would like to have the following patch committed.  Some EFI
> >> implementations do not provide a console control protocol instance,
> >> and it is covered by neither EFI or UEFI specifications.
> >
> > Right, right. My code was only for testing, so it was not good, generally
> > speaking. BTW, can I add you into the project members of GRUB so that you
> > can commit patches yourself?
>
> Yes, please do.

Done. Can you check in your patch, please?

Okuji