* [PATCH 1/2] ARM: dts: armada388-helios4: assign pinctrl to LEDs
@ 2020-12-03 2:23 Rosen Penev
2020-12-03 2:23 ` [PATCH 2/2] ARM: dts: armada388-helios4: assign pinctrl to each fan Rosen Penev
2021-01-29 15:27 ` [PATCH 1/2] ARM: dts: armada388-helios4: assign pinctrl to LEDs Gregory CLEMENT
0 siblings, 2 replies; 4+ messages in thread
From: Rosen Penev @ 2020-12-03 2:23 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: gregory.clement
Split up the pins to match earlier definitions. Allows LEDs to flash
properly.
Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
arch/arm/boot/dts/armada-388-helios4.dts | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/armada-388-helios4.dts b/arch/arm/boot/dts/armada-388-helios4.dts
index b3728de3bd3f..5a6af7e83e44 100644
--- a/arch/arm/boot/dts/armada-388-helios4.dts
+++ b/arch/arm/boot/dts/armada-388-helios4.dts
@@ -70,6 +70,9 @@
system-leds {
compatible = "gpio-leds";
+ pinctrl-names = "default";
+ pinctrl-0 = <&helios_system_led_pins>;
+
status-led {
label = "helios4:green:status";
gpios = <&gpio0 24 GPIO_ACTIVE_LOW>;
@@ -86,6 +89,9 @@
io-leds {
compatible = "gpio-leds";
+ pinctrl-names = "default";
+ pinctrl-0 = <&helios_io_led_pins>;
+
sata1-led {
label = "helios4:green:ata1";
gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
@@ -286,9 +292,12 @@
"mpp39", "mpp40";
marvell,function = "sd0";
};
- helios_led_pins: helios-led-pins {
- marvell,pins = "mpp24", "mpp25",
- "mpp49", "mpp50",
+ helios_system_led_pins: helios-system-led-pins {
+ marvell,pins = "mpp24", "mpp25";
+ marvell,function = "gpio";
+ };
+ helios_io_led_pins: helios-io-led-pins {
+ marvell,pins = "mpp49", "mpp50",
"mpp52", "mpp53",
"mpp54";
marvell,function = "gpio";
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] ARM: dts: armada388-helios4: assign pinctrl to each fan
2020-12-03 2:23 [PATCH 1/2] ARM: dts: armada388-helios4: assign pinctrl to LEDs Rosen Penev
@ 2020-12-03 2:23 ` Rosen Penev
2021-01-29 15:27 ` Gregory CLEMENT
2021-01-29 15:27 ` [PATCH 1/2] ARM: dts: armada388-helios4: assign pinctrl to LEDs Gregory CLEMENT
1 sibling, 1 reply; 4+ messages in thread
From: Rosen Penev @ 2020-12-03 2:23 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: gregory.clement
Split up the pins for each fan. This is needed in order to control them
Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
arch/arm/boot/dts/armada-388-helios4.dts | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/armada-388-helios4.dts b/arch/arm/boot/dts/armada-388-helios4.dts
index 5a6af7e83e44..ec134e22bae3 100644
--- a/arch/arm/boot/dts/armada-388-helios4.dts
+++ b/arch/arm/boot/dts/armada-388-helios4.dts
@@ -127,11 +127,15 @@
fan1: j10-pwm {
compatible = "pwm-fan";
pwms = <&gpio1 9 40000>; /* Target freq:25 kHz */
+ pinctrl-names = "default";
+ pinctrl-0 = <&helios_fan1_pins>;
};
fan2: j17-pwm {
compatible = "pwm-fan";
pwms = <&gpio1 23 40000>; /* Target freq:25 kHz */
+ pinctrl-names = "default";
+ pinctrl-0 = <&helios_fan2_pins>;
};
usb2_phy: usb2-phy {
@@ -302,9 +306,12 @@
"mpp54";
marvell,function = "gpio";
};
- helios_fan_pins: helios-fan-pins {
- marvell,pins = "mpp41", "mpp43",
- "mpp48", "mpp55";
+ helios_fan1_pins: helios_fan1_pins {
+ marvell,pins = "mpp41", "mpp43";
+ marvell,function = "gpio";
+ };
+ helios_fan2_pins: helios_fan2_pins {
+ marvell,pins = "mpp48", "mpp55";
marvell,function = "gpio";
};
microsom_spi1_cs_pins: spi1-cs-pins {
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ARM: dts: armada388-helios4: assign pinctrl to LEDs
2020-12-03 2:23 [PATCH 1/2] ARM: dts: armada388-helios4: assign pinctrl to LEDs Rosen Penev
2020-12-03 2:23 ` [PATCH 2/2] ARM: dts: armada388-helios4: assign pinctrl to each fan Rosen Penev
@ 2021-01-29 15:27 ` Gregory CLEMENT
1 sibling, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2021-01-29 15:27 UTC (permalink / raw)
To: Rosen Penev, linux-arm-kernel
Hi Rosen,
> Split up the pins to match earlier definitions. Allows LEDs to flash
> properly.
>
> Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-388-helios4.dts | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-388-helios4.dts b/arch/arm/boot/dts/armada-388-helios4.dts
> index b3728de3bd3f..5a6af7e83e44 100644
> --- a/arch/arm/boot/dts/armada-388-helios4.dts
> +++ b/arch/arm/boot/dts/armada-388-helios4.dts
> @@ -70,6 +70,9 @@
>
> system-leds {
> compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&helios_system_led_pins>;
> +
> status-led {
> label = "helios4:green:status";
> gpios = <&gpio0 24 GPIO_ACTIVE_LOW>;
> @@ -86,6 +89,9 @@
>
> io-leds {
> compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&helios_io_led_pins>;
> +
> sata1-led {
> label = "helios4:green:ata1";
> gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
> @@ -286,9 +292,12 @@
> "mpp39", "mpp40";
> marvell,function = "sd0";
> };
> - helios_led_pins: helios-led-pins {
> - marvell,pins = "mpp24", "mpp25",
> - "mpp49", "mpp50",
> + helios_system_led_pins: helios-system-led-pins {
> + marvell,pins = "mpp24", "mpp25";
> + marvell,function = "gpio";
> + };
> + helios_io_led_pins: helios-io-led-pins {
> + marvell,pins = "mpp49", "mpp50",
> "mpp52", "mpp53",
> "mpp54";
> marvell,function = "gpio";
> --
> 2.17.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] ARM: dts: armada388-helios4: assign pinctrl to each fan
2020-12-03 2:23 ` [PATCH 2/2] ARM: dts: armada388-helios4: assign pinctrl to each fan Rosen Penev
@ 2021-01-29 15:27 ` Gregory CLEMENT
0 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2021-01-29 15:27 UTC (permalink / raw)
To: Rosen Penev, linux-arm-kernel
Hi Rosen,
> Split up the pins for each fan. This is needed in order to control them
>
> Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-388-helios4.dts | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-388-helios4.dts b/arch/arm/boot/dts/armada-388-helios4.dts
> index 5a6af7e83e44..ec134e22bae3 100644
> --- a/arch/arm/boot/dts/armada-388-helios4.dts
> +++ b/arch/arm/boot/dts/armada-388-helios4.dts
> @@ -127,11 +127,15 @@
> fan1: j10-pwm {
> compatible = "pwm-fan";
> pwms = <&gpio1 9 40000>; /* Target freq:25 kHz */
> + pinctrl-names = "default";
> + pinctrl-0 = <&helios_fan1_pins>;
> };
>
> fan2: j17-pwm {
> compatible = "pwm-fan";
> pwms = <&gpio1 23 40000>; /* Target freq:25 kHz */
> + pinctrl-names = "default";
> + pinctrl-0 = <&helios_fan2_pins>;
> };
>
> usb2_phy: usb2-phy {
> @@ -302,9 +306,12 @@
> "mpp54";
> marvell,function = "gpio";
> };
> - helios_fan_pins: helios-fan-pins {
> - marvell,pins = "mpp41", "mpp43",
> - "mpp48", "mpp55";
> + helios_fan1_pins: helios_fan1_pins {
> + marvell,pins = "mpp41", "mpp43";
> + marvell,function = "gpio";
> + };
> + helios_fan2_pins: helios_fan2_pins {
> + marvell,pins = "mpp48", "mpp55";
> marvell,function = "gpio";
> };
> microsom_spi1_cs_pins: spi1-cs-pins {
> --
> 2.17.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-29 15:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-03 2:23 [PATCH 1/2] ARM: dts: armada388-helios4: assign pinctrl to LEDs Rosen Penev
2020-12-03 2:23 ` [PATCH 2/2] ARM: dts: armada388-helios4: assign pinctrl to each fan Rosen Penev
2021-01-29 15:27 ` Gregory CLEMENT
2021-01-29 15:27 ` [PATCH 1/2] ARM: dts: armada388-helios4: assign pinctrl to LEDs Gregory CLEMENT
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.