All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] platform/x86: asus-armoury: add support for G614PR
@ 2026-06-10 15:21 Marco Scardovi
  2026-06-10 17:54 ` Denis Benato
  2026-06-11 15:02 ` Ilpo Järvinen
  0 siblings, 2 replies; 12+ messages in thread
From: Marco Scardovi @ 2026-06-10 15:21 UTC (permalink / raw)
  To: Luke D . Jones, Denis Benato, Corentin Chary, Hans de Goede,
	Ilpo Järvinen
  Cc: platform-driver-x86, linux-kernel

Add TDP power limits and fan curve requirements for the ASUS ROG Strix
G16 G614PR laptop model.

The ASUS ROG Strix G16 G614PR requires specific AC/DC power limits
(PPT PL1/PL2/PL3, dynamic boost, and NV TGP targets) to function
correctly under various power profiles. Without these limits, the Asus
Armoury driver cannot configure the correct power envelopes or enable custom
fan curves, leading to suboptimal performance or noise management.

This patch adds the corresponding DMI board name matching entry ("G614PR")
under the power_limits table in asus-armoury.h, populating the AC and DC
limits based on the platform's hardware specification.

Assisted-by: Antigravity:gemini-3.5-flash
Signed-off-by: Marco Scardovi <scardracs@disroot.org>
---
 drivers/platform/x86/asus-armoury.h | 34 +++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/drivers/platform/x86/asus-armoury.h b/drivers/platform/x86/asus-armoury.h
index 692978b61959..5be34b6a92db 100644
--- a/drivers/platform/x86/asus-armoury.h
+++ b/drivers/platform/x86/asus-armoury.h
@@ -1898,6 +1898,40 @@ static const struct dmi_system_id power_limits[] = {
 			.requires_fan_curve = true,
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "G614PR"),
+		},
+		.driver_data = &(struct power_data) {
+			.ac_data = &(struct power_limits) {
+				.ppt_pl1_spl_min = 30,
+				.ppt_pl1_spl_max = 90,
+				.ppt_pl2_sppt_min = 65,
+				.ppt_pl2_sppt_def = 110,
+				.ppt_pl2_sppt_max = 125,
+				.ppt_pl3_fppt_min = 65,
+				.ppt_pl3_fppt_def = 110,
+				.ppt_pl3_fppt_max = 125,
+				.nv_temp_target_min = 75,
+				.nv_temp_target_max = 87,
+				.nv_dynamic_boost_min = 5,
+				.nv_dynamic_boost_max = 25,
+				.nv_tgp_min = 65,
+				.nv_tgp_max = 115,
+			},
+			.dc_data = &(struct power_limits) {
+				.ppt_pl1_spl_min = 25,
+				.ppt_pl1_spl_max = 65,
+				.ppt_pl2_sppt_min = 25,
+				.ppt_pl2_sppt_max = 65,
+				.ppt_pl3_fppt_min = 35,
+				.ppt_pl3_fppt_max = 75,
+				.nv_temp_target_min = 75,
+				.nv_temp_target_max = 87,
+			},
+			.requires_fan_curve = true,
+		},
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_NAME, "G615LR"),
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH] platform/x86: asus-armoury: add support for G614PR
  2026-06-10 15:21 [PATCH] platform/x86: asus-armoury: add support for G614PR Marco Scardovi
@ 2026-06-10 17:54 ` Denis Benato
  2026-06-11 15:02 ` Ilpo Järvinen
  1 sibling, 0 replies; 12+ messages in thread
From: Denis Benato @ 2026-06-10 17:54 UTC (permalink / raw)
  To: Marco Scardovi, Luke D . Jones, Corentin Chary, Hans de Goede,
	Ilpo Järvinen
  Cc: platform-driver-x86, linux-kernel


On 6/10/26 17:21, Marco Scardovi wrote:
> Add TDP power limits and fan curve requirements for the ASUS ROG Strix
> G16 G614PR laptop model.
>
> The ASUS ROG Strix G16 G614PR requires specific AC/DC power limits
> (PPT PL1/PL2/PL3, dynamic boost, and NV TGP targets) to function
> correctly under various power profiles. Without these limits, the Asus
> Armoury driver cannot configure the correct power envelopes or enable custom
> fan curves, leading to suboptimal performance or noise management.
>
> This patch adds the corresponding DMI board name matching entry ("G614PR")
> under the power_limits table in asus-armoury.h, populating the AC and DC
> limits based on the platform's hardware specification.
Reviewed-by: Denis Benato <denis.benato@linux.dev>
> Assisted-by: Antigravity:gemini-3.5-flash
> Signed-off-by: Marco Scardovi <scardracs@disroot.org>
> ---
>  drivers/platform/x86/asus-armoury.h | 34 +++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-armoury.h b/drivers/platform/x86/asus-armoury.h
> index 692978b61959..5be34b6a92db 100644
> --- a/drivers/platform/x86/asus-armoury.h
> +++ b/drivers/platform/x86/asus-armoury.h
> @@ -1898,6 +1898,40 @@ static const struct dmi_system_id power_limits[] = {
>  			.requires_fan_curve = true,
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_NAME, "G614PR"),
> +		},
> +		.driver_data = &(struct power_data) {
> +			.ac_data = &(struct power_limits) {
> +				.ppt_pl1_spl_min = 30,
> +				.ppt_pl1_spl_max = 90,
> +				.ppt_pl2_sppt_min = 65,
> +				.ppt_pl2_sppt_def = 110,
> +				.ppt_pl2_sppt_max = 125,
> +				.ppt_pl3_fppt_min = 65,
> +				.ppt_pl3_fppt_def = 110,
> +				.ppt_pl3_fppt_max = 125,
> +				.nv_temp_target_min = 75,
> +				.nv_temp_target_max = 87,
> +				.nv_dynamic_boost_min = 5,
> +				.nv_dynamic_boost_max = 25,
> +				.nv_tgp_min = 65,
> +				.nv_tgp_max = 115,
> +			},
> +			.dc_data = &(struct power_limits) {
> +				.ppt_pl1_spl_min = 25,
> +				.ppt_pl1_spl_max = 65,
> +				.ppt_pl2_sppt_min = 25,
> +				.ppt_pl2_sppt_max = 65,
> +				.ppt_pl3_fppt_min = 35,
> +				.ppt_pl3_fppt_max = 75,
> +				.nv_temp_target_min = 75,
> +				.nv_temp_target_max = 87,
> +			},
> +			.requires_fan_curve = true,
> +		},
> +	},
>  	{
>  		.matches = {
>  			DMI_MATCH(DMI_BOARD_NAME, "G615LR"),

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] platform/x86: asus-armoury: add support for G614PR
  2026-06-10 15:21 [PATCH] platform/x86: asus-armoury: add support for G614PR Marco Scardovi
  2026-06-10 17:54 ` Denis Benato
@ 2026-06-11 15:02 ` Ilpo Järvinen
  2026-06-11 15:53   ` Marco Scardovi
  2026-06-14  8:44   ` [PATCH v2 0/1] " Marco Scardovi
  1 sibling, 2 replies; 12+ messages in thread
From: Ilpo Järvinen @ 2026-06-11 15:02 UTC (permalink / raw)
  To: Luke D . Jones, Denis Benato, Corentin Chary, Hans de Goede,
	Marco Scardovi
  Cc: platform-driver-x86, linux-kernel

On Wed, 10 Jun 2026 17:21:30 +0200, Marco Scardovi wrote:

> Add TDP power limits and fan curve requirements for the ASUS ROG Strix
> G16 G614PR laptop model.
> 
> The ASUS ROG Strix G16 G614PR requires specific AC/DC power limits
> (PPT PL1/PL2/PL3, dynamic boost, and NV TGP targets) to function
> correctly under various power profiles. Without these limits, the Asus
> Armoury driver cannot configure the correct power envelopes or enable custom
> fan curves, leading to suboptimal performance or noise management.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: asus-armoury: add support for G614PR
      commit: 6b3bbe770f4ca0439710b7c42f88b9f6eeebabd0

--
 i.


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] platform/x86: asus-armoury: add support for G614PR
  2026-06-11 15:02 ` Ilpo Järvinen
@ 2026-06-11 15:53   ` Marco Scardovi
  2026-06-14  8:44   ` [PATCH v2 0/1] " Marco Scardovi
  1 sibling, 0 replies; 12+ messages in thread
From: Marco Scardovi @ 2026-06-11 15:53 UTC (permalink / raw)
  To: Luke D . Jones, Denis Benato, Corentin Chary, Hans de Goede,
	Ilpo Järvinen
  Cc: platform-driver-x86, linux-kernel

In data giovedì 11 giugno 2026 17:02:39 Ora legale dell’Europa centrale, Ilpo 
Järvinen ha scritto:
> On Wed, 10 Jun 2026 17:21:30 +0200, Marco Scardovi wrote:
> > Add TDP power limits and fan curve requirements for the ASUS ROG Strix
> > G16 G614PR laptop model.
> > 
> > The ASUS ROG Strix G16 G614PR requires specific AC/DC power limits
> > (PPT PL1/PL2/PL3, dynamic boost, and NV TGP targets) to function
> > correctly under various power profiles. Without these limits, the Asus
> > Armoury driver cannot configure the correct power envelopes or enable
> > custom fan curves, leading to suboptimal performance or noise management.
> > 
> > [...]
> 
> Thank you for your contribution, it has been applied to my local
> review-ilpo-next branch. Note it will show up in the public
> platform-drivers-x86/review-ilpo-next branch only once I've pushed my
> local branch there, which might take a while.
> 
> The list of commits applied:
> [1/1] platform/x86: asus-armoury: add support for G614PR
>       commit: 6b3bbe770f4ca0439710b7c42f88b9f6eeebabd0
> 
> --
>  i.

Hi! Thank you for picking it up :) I'm not in a rush and tbf I was expecting 
it would take some time.



^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH v2 0/1] platform/x86: asus-armoury: add support for G614PR
  2026-06-11 15:02 ` Ilpo Järvinen
  2026-06-11 15:53   ` Marco Scardovi
@ 2026-06-14  8:44   ` Marco Scardovi
  2026-06-14  8:44     ` [PATCH v2] " Marco Scardovi
  1 sibling, 1 reply; 12+ messages in thread
From: Marco Scardovi @ 2026-06-14  8:44 UTC (permalink / raw)
  To: ilpo.jarvinen
  Cc: corentin.chary, denis.benato, hansg, linux-kernel, luke,
	platform-driver-x86, scardracs

Hi Ilpo,

Here is the v2 of the patch.

In this version, I have updated the AC power limits (.ppt_pl1_spl_max,
.ppt_pl2_sppt_def, .ppt_pl2_sppt_max, .ppt_pl3_fppt_def, and
.ppt_pl3_fppt_max) to match the correct hardware specifications for
the G614PR laptop model.

The previous v1 submission had underestimated these values (e.g. limiting
the PL1 to 90W and PL2/PL3 to 125W max). The updated values (120W for PL1
max, 140W default and 145W max for PL2/PL3) allow the ASUS ROG Strix G16
G614PR to utilize its full power envelopes correctly under AC power profiles
without artificial capping.

Thanks,
Marco

Marco Scardovi (1):
  platform/x86: asus-armoury: add support for G614PR

 drivers/platform/x86/asus-armoury.h | 34 +++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

-- 
2.54.0

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH v2] platform/x86: asus-armoury: add support for G614PR
  2026-06-14  8:44   ` [PATCH v2 0/1] " Marco Scardovi
@ 2026-06-14  8:44     ` Marco Scardovi
  2026-06-14 12:33       ` Denis Benato
  0 siblings, 1 reply; 12+ messages in thread
From: Marco Scardovi @ 2026-06-14  8:44 UTC (permalink / raw)
  To: ilpo.jarvinen
  Cc: corentin.chary, denis.benato, hansg, linux-kernel, luke,
	platform-driver-x86, scardracs

Add TDP power limits and fan curve requirements for the ASUS ROG
Strix G16 G614PR laptop model.

Add the corresponding DMI board name matching entry ("G614PR") under
the power_limits table in asus-armoury.h, populating the AC and DC limits
based on the platform's hardware specification.

Assisted-by: Antigravity:gemini-3.5-flash
Signed-off-by: Marco Scardovi <scardracs@disroot.org>
---
 drivers/platform/x86/asus-armoury.h | 34 +++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/drivers/platform/x86/asus-armoury.h b/drivers/platform/x86/asus-armoury.h
index 692978b61959..c2df2381a260 100644
--- a/drivers/platform/x86/asus-armoury.h
+++ b/drivers/platform/x86/asus-armoury.h
@@ -1898,6 +1898,40 @@ static const struct dmi_system_id power_limits[] = {
 			.requires_fan_curve = true,
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "G614PR"),
+		},
+		.driver_data = &(struct power_data) {
+			.ac_data = &(struct power_limits) {
+				.ppt_pl1_spl_min = 30,
+				.ppt_pl1_spl_max = 120,
+				.ppt_pl2_sppt_min = 65,
+				.ppt_pl2_sppt_def = 140,
+				.ppt_pl2_sppt_max = 145,
+				.ppt_pl3_fppt_min = 65,
+				.ppt_pl3_fppt_def = 140,
+				.ppt_pl3_fppt_max = 145,
+				.nv_temp_target_min = 75,
+				.nv_temp_target_max = 87,
+				.nv_dynamic_boost_min = 5,
+				.nv_dynamic_boost_max = 25,
+				.nv_tgp_min = 65,
+				.nv_tgp_max = 115,
+			},
+			.dc_data = &(struct power_limits) {
+				.ppt_pl1_spl_min = 25,
+				.ppt_pl1_spl_max = 65,
+				.ppt_pl2_sppt_min = 25,
+				.ppt_pl2_sppt_max = 65,
+				.ppt_pl3_fppt_min = 35,
+				.ppt_pl3_fppt_max = 75,
+				.nv_temp_target_min = 75,
+				.nv_temp_target_max = 87,
+			},
+			.requires_fan_curve = true,
+		},
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_NAME, "G615LR"),
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH v2] platform/x86: asus-armoury: add support for G614PR
  2026-06-14  8:44     ` [PATCH v2] " Marco Scardovi
@ 2026-06-14 12:33       ` Denis Benato
  2026-06-15 15:07         ` Marco Scardovi
  0 siblings, 1 reply; 12+ messages in thread
From: Denis Benato @ 2026-06-14 12:33 UTC (permalink / raw)
  To: Marco Scardovi, ilpo.jarvinen
  Cc: corentin.chary, hansg, linux-kernel, luke, platform-driver-x86


On 6/14/26 10:44, Marco Scardovi wrote:
> Add TDP power limits and fan curve requirements for the ASUS ROG
> Strix G16 G614PR laptop model.
>
> Add the corresponding DMI board name matching entry ("G614PR") under
> the power_limits table in asus-armoury.h, populating the AC and DC limits
> based on the platform's hardware specification.
In general all these data have been posted in the ppt data collection thread
in form of screenshots (and I'd like to have yours too for future reference).

Your model isn't posted there, so I assumed these values were what is available
to you on the official windows app, if so the previous one has to be kept
unless you find an explanation of why what is see is different from
what you expect to see.
> Assisted-by: Antigravity:gemini-3.5-flash
> Signed-off-by: Marco Scardovi <scardracs@disroot.org>
> ---
>  drivers/platform/x86/asus-armoury.h | 34 +++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-armoury.h b/drivers/platform/x86/asus-armoury.h
> index 692978b61959..c2df2381a260 100644
> --- a/drivers/platform/x86/asus-armoury.h
> +++ b/drivers/platform/x86/asus-armoury.h
> @@ -1898,6 +1898,40 @@ static const struct dmi_system_id power_limits[] = {
>  			.requires_fan_curve = true,
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_NAME, "G614PR"),
> +		},
> +		.driver_data = &(struct power_data) {
> +			.ac_data = &(struct power_limits) {
> +				.ppt_pl1_spl_min = 30,
> +				.ppt_pl1_spl_max = 120,
> +				.ppt_pl2_sppt_min = 65,
> +				.ppt_pl2_sppt_def = 140,
> +				.ppt_pl2_sppt_max = 145,
> +				.ppt_pl3_fppt_min = 65,
> +				.ppt_pl3_fppt_def = 140,
> +				.ppt_pl3_fppt_max = 145,
> +				.nv_temp_target_min = 75,
> +				.nv_temp_target_max = 87,
> +				.nv_dynamic_boost_min = 5,
> +				.nv_dynamic_boost_max = 25,
> +				.nv_tgp_min = 65,
> +				.nv_tgp_max = 115,
> +			},
> +			.dc_data = &(struct power_limits) {
> +				.ppt_pl1_spl_min = 25,
> +				.ppt_pl1_spl_max = 65,
> +				.ppt_pl2_sppt_min = 25,
> +				.ppt_pl2_sppt_max = 65,
> +				.ppt_pl3_fppt_min = 35,
> +				.ppt_pl3_fppt_max = 75,
> +				.nv_temp_target_min = 75,
> +				.nv_temp_target_max = 87,
> +			},
> +			.requires_fan_curve = true,
> +		},
> +	},
>  	{
>  		.matches = {
>  			DMI_MATCH(DMI_BOARD_NAME, "G615LR"),

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2] platform/x86: asus-armoury: add support for G614PR
  2026-06-14 12:33       ` Denis Benato
@ 2026-06-15 15:07         ` Marco Scardovi
  2026-06-27  6:18           ` Marco Scardovi
  0 siblings, 1 reply; 12+ messages in thread
From: Marco Scardovi @ 2026-06-15 15:07 UTC (permalink / raw)
  To: ilpo.jarvinen, Denis Benato
  Cc: corentin.chary, hansg, linux-kernel, luke, platform-driver-x86

> 
> In general all these data have been posted in the ppt data collection thread
> in form of screenshots (and I'd like to have yours too for future
> reference).
> 
> Your model isn't posted there, so I assumed these values were what is
> available to you on the official windows app, if so the previous one has to
> be kept unless you find an explanation of why what is see is different from
> what you expect to see.
> 
Hi Denis,

as I wrote you in private it was my bad in the end: I made gemini extrapolate
them from the ThrottleGear_G614PR.xml, which was encrypted, and didn't
triple check them.

As I told you I wrote down a python script [1], completely free from the ASUS 
code, that can handle these xml files, decrypt them and even create the quirks 
necessary to post in asus-armoury.h. I tried it with my G614PR.xml: it works 
without problems and the values are correct.

[1] https://gitlab.com/scardracs/throttlegear



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2] platform/x86: asus-armoury: add support for G614PR
  2026-06-15 15:07         ` Marco Scardovi
@ 2026-06-27  6:18           ` Marco Scardovi
  2026-06-29 11:04             ` Ilpo Järvinen
  0 siblings, 1 reply; 12+ messages in thread
From: Marco Scardovi @ 2026-06-27  6:18 UTC (permalink / raw)
  To: ilpo.jarvinen
  Cc: corentin.chary, denis.benato, hansg, linux-kernel, luke,
	platform-driver-x86

Hi Ilpo,
you around? I'd need this to be fixed to set the correct values.

Thank you,
Marco



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2] platform/x86: asus-armoury: add support for G614PR
  2026-06-27  6:18           ` Marco Scardovi
@ 2026-06-29 11:04             ` Ilpo Järvinen
  2026-06-29 11:27               ` Marco Scardovi
  0 siblings, 1 reply; 12+ messages in thread
From: Ilpo Järvinen @ 2026-06-29 11:04 UTC (permalink / raw)
  To: Marco Scardovi
  Cc: corentin.chary, denis.benato, Hans de Goede, LKML, luke,
	platform-driver-x86

On Sat, 27 Jun 2026, Marco Scardovi wrote:

> you around? I'd need this to be fixed to set the correct values.

I'm not sure what the context here is, whether you're just asking for the 
patch to be applied (which is entirely unnecessary, as long as the patch 
appears in the patchwork's queue, I've not lost it), or if you're saying 
there's a problem in v2 patch?

Usually, the merge window is quiet time anyway when it comes to applying 
patches so don't expect much to happen for them until clearly after rc1 
(= not right after rc1 has been published, because the piled up patch 
queue will take some time to drain and there are other things to do around 
that timeframe as well).

-- 
 i.


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2] platform/x86: asus-armoury: add support for G614PR
  2026-06-29 11:04             ` Ilpo Järvinen
@ 2026-06-29 11:27               ` Marco Scardovi
  2026-06-30 14:18                 ` Ilpo Järvinen
  0 siblings, 1 reply; 12+ messages in thread
From: Marco Scardovi @ 2026-06-29 11:27 UTC (permalink / raw)
  To: Ilpo Järvinen
  Cc: corentin.chary, denis.benato, Hans de Goede, LKML, luke,
	platform-driver-x86

Hi Ilpo,

In data lunedì 29 giugno 2026 13:04:51 Ora legale dell’Europa centrale, Ilpo Järvinen ha scritto:
> On Sat, 27 Jun 2026, Marco Scardovi wrote:
> 
> > you around? I'd need this to be fixed to set the correct values.
> 
> I'm not sure what the context here is, whether you're just asking for the 
> patch to be applied (which is entirely unnecessary, as long as the patch 
> appears in the patchwork's queue, I've not lost it), or if you're saying 
> there's a problem in v2 patch?
>
There was a problem with the v1 patch, where I wrote 4 values wrongly,
so I posted the v2 with the correct values.
> 
> Usually, the merge window is quiet time anyway when it comes to applying 
> patches so don't expect much to happen for them until clearly after rc1 
> (= not right after rc1 has been published, because the piled up patch 
> queue will take some time to drain and there are other things to do around 
> that timeframe as well).
> 
I see, sorry for bothering. I'm new to the kernel patching workflow and
still learning how it works.



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2] platform/x86: asus-armoury: add support for G614PR
  2026-06-29 11:27               ` Marco Scardovi
@ 2026-06-30 14:18                 ` Ilpo Järvinen
  0 siblings, 0 replies; 12+ messages in thread
From: Ilpo Järvinen @ 2026-06-30 14:18 UTC (permalink / raw)
  To: Marco Scardovi
  Cc: corentin.chary, denis.benato, Hans de Goede, LKML, luke,
	platform-driver-x86

[-- Attachment #1: Type: text/plain, Size: 2166 bytes --]

On Mon, 29 Jun 2026, Marco Scardovi wrote:

> Hi Ilpo,
> 
> In data lunedì 29 giugno 2026 13:04:51 Ora legale dell’Europa centrale, Ilpo Järvinen ha scritto:
> > On Sat, 27 Jun 2026, Marco Scardovi wrote:
> > 
> > > you around? I'd need this to be fixed to set the correct values.
> > 
> > I'm not sure what the context here is, whether you're just asking for the 
> > patch to be applied (which is entirely unnecessary, as long as the patch 
> > appears in the patchwork's queue, I've not lost it), or if you're saying 
> > there's a problem in v2 patch?
> >
> There was a problem with the v1 patch, where I wrote 4 values wrongly,
> so I posted the v2 with the correct values.

Hi,

I did take v1 patch and it has in the meantime been merged into Linus' 
tree, making the original change immutable.

Thus, please post a delta patch with a justification instead. Use a Fixes 
tag pointing to the original commit.

For simple patches, placing the patch changelog (patch history) in that 
patch itself under --- line e.g. as bullet points is more effective and 
easy to spot that from the coverletter.

Preferrably post new versions as own thread because sometimes tools may 
get confused when more than one version appears within the same thread.

> > Usually, the merge window is quiet time anyway when it comes to applying 
> > patches so don't expect much to happen for them until clearly after rc1 
> > (= not right after rc1 has been published, because the piled up patch 
> > queue will take some time to drain and there are other things to do around 
> > that timeframe as well).
> > 
> I see, sorry for bothering. I'm new to the kernel patching workflow and
> still learning how it works.

It's no problem, no need to be sorry at all, we value also patches from 
newcomers. I just wrote this to explain how the kernel development cycle 
works. 

Some subsystems accept no new submissions during merge window, in pdx86 
we've no such rule but things are still quieter also here (I usually won't 
apply anything than very very critical fixes during that 2 weeks window of 
time, it's "normal").

-- 
 i.

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2026-06-30 14:18 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-10 15:21 [PATCH] platform/x86: asus-armoury: add support for G614PR Marco Scardovi
2026-06-10 17:54 ` Denis Benato
2026-06-11 15:02 ` Ilpo Järvinen
2026-06-11 15:53   ` Marco Scardovi
2026-06-14  8:44   ` [PATCH v2 0/1] " Marco Scardovi
2026-06-14  8:44     ` [PATCH v2] " Marco Scardovi
2026-06-14 12:33       ` Denis Benato
2026-06-15 15:07         ` Marco Scardovi
2026-06-27  6:18           ` Marco Scardovi
2026-06-29 11:04             ` Ilpo Järvinen
2026-06-29 11:27               ` Marco Scardovi
2026-06-30 14:18                 ` Ilpo Järvinen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.