All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	arnd-r2nGTMty4D4@public.gmane.org,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Dan Williams
	<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Wei Yongjun
	<yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>,
	Andy Shevchenko
	<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF
Date: Mon, 3 Oct 2016 09:39:25 -0400	[thread overview]
Message-ID: <a36242e2-99a4-b519-094e-b6d2bcdd27da@codeaurora.org> (raw)
In-Reply-To: <20161003033851.GP2467@localhost>

On 10/2/2016 11:38 PM, Vinod Koul wrote:
>> I followed the pattern in of_platform_device_create_pdata function. of_msi_configure does
>> > nothing if MSI is not enabled as irq_find_matching_host returns NULL. It didn't have any
>> > side effects on my testing either.
> yeah later on I did look up the of_msi_configure() and I suspected this. I
> think it would be worthwhile to document this assumption here.

Sure, let me do that.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF
Date: Mon, 3 Oct 2016 09:39:25 -0400	[thread overview]
Message-ID: <a36242e2-99a4-b519-094e-b6d2bcdd27da@codeaurora.org> (raw)
In-Reply-To: <20161003033851.GP2467@localhost>

On 10/2/2016 11:38 PM, Vinod Koul wrote:
>> I followed the pattern in of_platform_device_create_pdata function. of_msi_configure does
>> > nothing if MSI is not enabled as irq_find_matching_host returns NULL. It didn't have any
>> > side effects on my testing either.
> yeah later on I did look up the of_msi_configure() and I suspected this. I
> think it would be worthwhile to document this assumption here.

Sure, let me do that.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

WARNING: multiple messages have this Message-ID (diff)
From: Sinan Kaya <okaya@codeaurora.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org,
	devicetree@vger.kernel.org, cov@codeaurora.org, jcm@redhat.com,
	agross@codeaurora.org, arnd@arndb.de,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Dan Williams <dan.j.williams@intel.com>,
	Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF
Date: Mon, 3 Oct 2016 09:39:25 -0400	[thread overview]
Message-ID: <a36242e2-99a4-b519-094e-b6d2bcdd27da@codeaurora.org> (raw)
In-Reply-To: <20161003033851.GP2467@localhost>

On 10/2/2016 11:38 PM, Vinod Koul wrote:
>> I followed the pattern in of_platform_device_create_pdata function. of_msi_configure does
>> > nothing if MSI is not enabled as irq_find_matching_host returns NULL. It didn't have any
>> > side effects on my testing either.
> yeah later on I did look up the of_msi_configure() and I suspected this. I
> think it would be worthwhile to document this assumption here.

Sure, let me do that.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

  reply	other threads:[~2016-10-03 13:39 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-29  2:12 [PATCH V4 00/10] dmaengine: qcom_hidma: add MSI interrupt support Sinan Kaya
2016-09-29  2:12 ` Sinan Kaya
2016-09-29  2:12 ` [PATCH V4 02/10] Documentation: DT: qcom_hidma: correct spelling mistakes Sinan Kaya
2016-09-29  2:12   ` Sinan Kaya
     [not found] ` <1475115167-5898-1-git-send-email-okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-09-29  2:12   ` [PATCH V4 01/10] Documentation: DT: qcom_hidma: update binding for MSI Sinan Kaya
2016-09-29  2:12     ` Sinan Kaya
2016-09-29  2:12     ` Sinan Kaya
2016-09-29  2:12   ` [PATCH V4 03/10] of: irq: make of_msi_configure accessible from modules Sinan Kaya
2016-09-29  2:12     ` Sinan Kaya
2016-09-29  2:12     ` Sinan Kaya
2016-09-29  2:12   ` [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF Sinan Kaya
2016-09-29  2:12     ` Sinan Kaya
2016-09-29  2:12     ` Sinan Kaya
2016-10-01  6:17     ` Vinod Koul
2016-10-01  6:17       ` Vinod Koul
2016-10-01 15:15       ` Sinan Kaya
2016-10-01 15:15         ` Sinan Kaya
2016-10-03  3:38         ` Vinod Koul
2016-10-03  3:38           ` Vinod Koul
2016-10-03 13:39           ` Sinan Kaya [this message]
2016-10-03 13:39             ` Sinan Kaya
2016-10-03 13:39             ` Sinan Kaya
2016-09-29  2:12   ` [PATCH V4 05/10] dmaengine: qcom_hidma: make pending_tre_count atomic Sinan Kaya
2016-09-29  2:12     ` Sinan Kaya
2016-09-29  2:12     ` Sinan Kaya
2016-10-01  6:19     ` Vinod Koul
2016-10-01  6:19       ` Vinod Koul
2016-10-01 15:19       ` Sinan Kaya
2016-10-01 15:19         ` Sinan Kaya
2016-10-03  3:39         ` Vinod Koul
2016-10-03  3:39           ` Vinod Koul
2016-09-29  2:12   ` [PATCH V4 08/10] dmaengine: qcom_hidma: add a common API to setup the interrupt Sinan Kaya
2016-09-29  2:12     ` Sinan Kaya
2016-09-29  2:12     ` Sinan Kaya
2016-09-29  2:12   ` [PATCH V4 09/10] dmaengine: qcom_hidma: protect common data structures Sinan Kaya
2016-09-29  2:12     ` Sinan Kaya
2016-09-29  2:12     ` Sinan Kaya
2016-09-29  2:12 ` [PATCH V4 06/10] dmaengine: qcom_hidma: make error and success path common Sinan Kaya
2016-09-29  2:12   ` Sinan Kaya
2016-09-29  2:12 ` [PATCH V4 07/10] dmaengine: qcom_hidma: bring out interrupt cause Sinan Kaya
2016-09-29  2:12   ` Sinan Kaya
2016-09-29  2:12 ` [PATCH V4 10/10] dmaengine: qcom_hidma: add MSI support for interrupts Sinan Kaya
2016-09-29  2:12   ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a36242e2-99a4-b519-094e-b6d2bcdd27da@codeaurora.org \
    --to=okaya-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
    --cc=agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.