[PATCH] xfs: remove some EXPERIMENTAL warnings

[PATCH] xfs: remove some EXPERIMENTAL warnings

[Darrick J. Wong]

From: Darrick J. Wong <djwong@kernel.org>

Online fsck was finished a year ago, in Linux 6.10.  The exchange-range
syscall and parent pointers were merged in the same cycle.  None of
these have encountered any serious errors in the year that they've been
in the kernel (or the many many years they've been under development) so
let's drop the shouty warnings.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
 fs/xfs/xfs_message.h |    3 ---
 fs/xfs/scrub/scrub.c |    2 --
 fs/xfs/xfs_message.c |   12 ------------
 fs/xfs/xfs_super.c   |    7 -------
 4 files changed, 24 deletions(-)

diff --git a/fs/xfs/xfs_message.h b/fs/xfs/xfs_message.h
index a92a4d09c8e9fa..bce9942f394a6f 100644
--- a/fs/xfs/xfs_message.h
+++ b/fs/xfs/xfs_message.h
@@ -92,12 +92,9 @@ void xfs_buf_alert_ratelimited(struct xfs_buf *bp, const char *rlmsg,
 
 enum xfs_experimental_feat {
 	XFS_EXPERIMENTAL_PNFS,
-	XFS_EXPERIMENTAL_SCRUB,
 	XFS_EXPERIMENTAL_SHRINK,
 	XFS_EXPERIMENTAL_LARP,
 	XFS_EXPERIMENTAL_LBS,
-	XFS_EXPERIMENTAL_EXCHRANGE,
-	XFS_EXPERIMENTAL_PPTR,
 	XFS_EXPERIMENTAL_METADIR,
 	XFS_EXPERIMENTAL_ZONED,
 
diff --git a/fs/xfs/scrub/scrub.c b/fs/xfs/scrub/scrub.c
index 9908850bf76f9e..76e24032e99a53 100644
--- a/fs/xfs/scrub/scrub.c
+++ b/fs/xfs/scrub/scrub.c
@@ -680,8 +680,6 @@ xfs_scrub_metadata(
 	if (error)
 		goto out;
 
-	xfs_warn_experimental(mp, XFS_EXPERIMENTAL_SCRUB);
-
 	sc = kzalloc(sizeof(struct xfs_scrub), XCHK_GFP_FLAGS);
 	if (!sc) {
 		error = -ENOMEM;
diff --git a/fs/xfs/xfs_message.c b/fs/xfs/xfs_message.c
index 15d410d16bb27c..54fc5ada519c43 100644
--- a/fs/xfs/xfs_message.c
+++ b/fs/xfs/xfs_message.c
@@ -145,10 +145,6 @@ xfs_warn_experimental(
 			.opstate	= XFS_OPSTATE_WARNED_PNFS,
 			.name		= "pNFS",
 		},
-		[XFS_EXPERIMENTAL_SCRUB] = {
-			.opstate	= XFS_OPSTATE_WARNED_SCRUB,
-			.name		= "online scrub",
-		},
 		[XFS_EXPERIMENTAL_SHRINK] = {
 			.opstate	= XFS_OPSTATE_WARNED_SHRINK,
 			.name		= "online shrink",
@@ -161,14 +157,6 @@ xfs_warn_experimental(
 			.opstate	= XFS_OPSTATE_WARNED_LBS,
 			.name		= "large block size",
 		},
-		[XFS_EXPERIMENTAL_EXCHRANGE] = {
-			.opstate	= XFS_OPSTATE_WARNED_EXCHRANGE,
-			.name		= "exchange range",
-		},
-		[XFS_EXPERIMENTAL_PPTR] = {
-			.opstate	= XFS_OPSTATE_WARNED_PPTR,
-			.name		= "parent pointer",
-		},
 		[XFS_EXPERIMENTAL_METADIR] = {
 			.opstate	= XFS_OPSTATE_WARNED_METADIR,
 			.name		= "metadata directory tree",
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 696874e72eacf1..b4e830fe101b2f 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1953,13 +1953,6 @@ xfs_fs_fill_super(
 		}
 	}
 
-
-	if (xfs_has_exchange_range(mp))
-		xfs_warn_experimental(mp, XFS_EXPERIMENTAL_EXCHRANGE);
-
-	if (xfs_has_parent(mp))
-		xfs_warn_experimental(mp, XFS_EXPERIMENTAL_PPTR);
-
 	/*
 	 * If no quota mount options were provided, maybe we'll try to pick
 	 * up the quota accounting and enforcement flags from the ondisk sb.

Re: [PATCH] xfs: remove some EXPERIMENTAL warnings

[Christoph Hellwig]

On Sat, May 10, 2025 at 08:53:01AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Online fsck was finished a year ago, in Linux 6.10.  The exchange-range
> syscall and parent pointers were merged in the same cycle.  None of
> these have encountered any serious errors in the year that they've been
> in the kernel (or the many many years they've been under development) so
> let's drop the shouty warnings.

Looks good.  Talking about experimental warnings, I'd also like to
drop the pnfs warning.  The code has been around forever, and while
we found occasional issues in the nfsd side of it, they were quickly
fixed.

Re: [PATCH] xfs: remove some EXPERIMENTAL warnings

[Darrick J. Wong]

On Sun, May 11, 2025 at 09:34:24PM -0700, Christoph Hellwig wrote:
> On Sat, May 10, 2025 at 08:53:01AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > Online fsck was finished a year ago, in Linux 6.10.  The exchange-range
> > syscall and parent pointers were merged in the same cycle.  None of
> > these have encountered any serious errors in the year that they've been
> > in the kernel (or the many many years they've been under development) so
> > let's drop the shouty warnings.
> 
> Looks good.  Talking about experimental warnings, I'd also like to
> drop the pnfs warning.  The code has been around forever, and while
> we found occasional issues in the nfsd side of it, they were quickly
> fixed.

I agree, let's drop the pnfs warning since warts or not the code has
been stable for a long time.  However, would you (hch) mind writing that
patch since you're the author of xfs_pnfs.c and I've never even used it.

--D

Re: [PATCH] xfs: remove some EXPERIMENTAL warnings

[Christoph Hellwig]

On Mon, May 12, 2025 at 08:14:30AM -0700, Darrick J. Wong wrote:
> I agree, let's drop the pnfs warning since warts or not the code has
> been stable for a long time.  However, would you (hch) mind writing that
> patch since you're the author of xfs_pnfs.c and I've never even used it.

Sure, I'll take care of it.

Re: [PATCH] xfs: remove some EXPERIMENTAL warnings

[Dave Chinner]

On Sat, May 10, 2025 at 08:53:01AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Online fsck was finished a year ago, in Linux 6.10.  The exchange-range
> syscall and parent pointers were merged in the same cycle.  None of
> these have encountered any serious errors in the year that they've been
> in the kernel (or the many many years they've been under development) so
> let's drop the shouty warnings.
> 
> Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>

Seems reasonable to me. I haven't encountered any problems with them
over the past few months, so no objections here.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

Re: [PATCH] xfs: remove some EXPERIMENTAL warnings

[Carlos Maiolino]

On Sat, May 10, 2025 at 08:53:01AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Online fsck was finished a year ago, in Linux 6.10.  The exchange-range
> syscall and parent pointers were merged in the same cycle.  None of
> these have encountered any serious errors in the year that they've been
> in the kernel (or the many many years they've been under development) so
> let's drop the shouty warnings.
> 
> Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>

No objections either.

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

> ---
>  fs/xfs/xfs_message.h |    3 ---
>  fs/xfs/scrub/scrub.c |    2 --
>  fs/xfs/xfs_message.c |   12 ------------
>  fs/xfs/xfs_super.c   |    7 -------
>  4 files changed, 24 deletions(-)
> 
> diff --git a/fs/xfs/xfs_message.h b/fs/xfs/xfs_message.h
> index a92a4d09c8e9fa..bce9942f394a6f 100644
> --- a/fs/xfs/xfs_message.h
> +++ b/fs/xfs/xfs_message.h
> @@ -92,12 +92,9 @@ void xfs_buf_alert_ratelimited(struct xfs_buf *bp, const char *rlmsg,
> 
>  enum xfs_experimental_feat {
>  	XFS_EXPERIMENTAL_PNFS,
> -	XFS_EXPERIMENTAL_SCRUB,
>  	XFS_EXPERIMENTAL_SHRINK,
>  	XFS_EXPERIMENTAL_LARP,
>  	XFS_EXPERIMENTAL_LBS,
> -	XFS_EXPERIMENTAL_EXCHRANGE,
> -	XFS_EXPERIMENTAL_PPTR,
>  	XFS_EXPERIMENTAL_METADIR,
>  	XFS_EXPERIMENTAL_ZONED,
> 
> diff --git a/fs/xfs/scrub/scrub.c b/fs/xfs/scrub/scrub.c
> index 9908850bf76f9e..76e24032e99a53 100644
> --- a/fs/xfs/scrub/scrub.c
> +++ b/fs/xfs/scrub/scrub.c
> @@ -680,8 +680,6 @@ xfs_scrub_metadata(
>  	if (error)
>  		goto out;
> 
> -	xfs_warn_experimental(mp, XFS_EXPERIMENTAL_SCRUB);
> -
>  	sc = kzalloc(sizeof(struct xfs_scrub), XCHK_GFP_FLAGS);
>  	if (!sc) {
>  		error = -ENOMEM;
> diff --git a/fs/xfs/xfs_message.c b/fs/xfs/xfs_message.c
> index 15d410d16bb27c..54fc5ada519c43 100644
> --- a/fs/xfs/xfs_message.c
> +++ b/fs/xfs/xfs_message.c
> @@ -145,10 +145,6 @@ xfs_warn_experimental(
>  			.opstate	= XFS_OPSTATE_WARNED_PNFS,
>  			.name		= "pNFS",
>  		},
> -		[XFS_EXPERIMENTAL_SCRUB] = {
> -			.opstate	= XFS_OPSTATE_WARNED_SCRUB,
> -			.name		= "online scrub",
> -		},
>  		[XFS_EXPERIMENTAL_SHRINK] = {
>  			.opstate	= XFS_OPSTATE_WARNED_SHRINK,
>  			.name		= "online shrink",
> @@ -161,14 +157,6 @@ xfs_warn_experimental(
>  			.opstate	= XFS_OPSTATE_WARNED_LBS,
>  			.name		= "large block size",
>  		},
> -		[XFS_EXPERIMENTAL_EXCHRANGE] = {
> -			.opstate	= XFS_OPSTATE_WARNED_EXCHRANGE,
> -			.name		= "exchange range",
> -		},
> -		[XFS_EXPERIMENTAL_PPTR] = {
> -			.opstate	= XFS_OPSTATE_WARNED_PPTR,
> -			.name		= "parent pointer",
> -		},
>  		[XFS_EXPERIMENTAL_METADIR] = {
>  			.opstate	= XFS_OPSTATE_WARNED_METADIR,
>  			.name		= "metadata directory tree",
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 696874e72eacf1..b4e830fe101b2f 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1953,13 +1953,6 @@ xfs_fs_fill_super(
>  		}
>  	}
> 
> -
> -	if (xfs_has_exchange_range(mp))
> -		xfs_warn_experimental(mp, XFS_EXPERIMENTAL_EXCHRANGE);
> -
> -	if (xfs_has_parent(mp))
> -		xfs_warn_experimental(mp, XFS_EXPERIMENTAL_PPTR);
> -
>  	/*
>  	 * If no quota mount options were provided, maybe we'll try to pick
>  	 * up the quota accounting and enforcement flags from the ondisk sb.
> 

Re: [PATCH] xfs: remove some EXPERIMENTAL warnings

[Carlos Maiolino]

On Sat, 10 May 2025 08:53:01 -0700, Darrick J. Wong wrote:
> Online fsck was finished a year ago, in Linux 6.10.  The exchange-range
> syscall and parent pointers were merged in the same cycle.  None of
> these have encountered any serious errors in the year that they've been
> in the kernel (or the many many years they've been under development) so
> let's drop the shouty warnings.
> 
> 
> [...]

Applied to for-next, thanks!

[1/1] xfs: remove some EXPERIMENTAL warnings
      (no commit info)

Best regards,
-- 
Carlos Maiolino <cem@kernel.org>

Re: [PATCH] xfs: remove some EXPERIMENTAL warnings

[Darrick J. Wong]

On Tue, May 13, 2025 at 07:38:08PM +0200, Carlos Maiolino wrote:
> On Sat, 10 May 2025 08:53:01 -0700, Darrick J. Wong wrote:
> > Online fsck was finished a year ago, in Linux 6.10.  The exchange-range
> > syscall and parent pointers were merged in the same cycle.  None of
> > these have encountered any serious errors in the year that they've been
> > in the kernel (or the many many years they've been under development) so
> > let's drop the shouty warnings.
> > 
> > 
> > [...]
> 
> Applied to for-next, thanks!
> 
> [1/1] xfs: remove some EXPERIMENTAL warnings
>       (no commit info)

Er... there's a V2 out with slightly more aggressive cleanups of
now-defunct OPSTATE bits.

--D

> Best regards,
> -- 
> Carlos Maiolino <cem@kernel.org>
> 

Re: [PATCH] xfs: remove some EXPERIMENTAL warnings

[Carlos Maiolino]

On Tue, May 13, 2025 at 07:38:08PM +0200, Carlos Maiolino wrote:
> On Sat, 10 May 2025 08:53:01 -0700, Darrick J. Wong wrote:
> > Online fsck was finished a year ago, in Linux 6.10.  The exchange-range
> > syscall and parent pointers were merged in the same cycle.  None of
> > these have encountered any serious errors in the year that they've been
> > in the kernel (or the many many years they've been under development) so
> > let's drop the shouty warnings.
> >
> >
> > [...]
> 
> Applied to for-next, thanks!
> 
> [1/1] xfs: remove some EXPERIMENTAL warnings
>       (no commit info)
> 

My apologies Darrick, this message was triggered by accident. I didn't
merge it yet. You'll see this patch is not in the ANNOUNCE email.


> Best regards,
> --
> Carlos Maiolino <cem@kernel.org>
> 
>