From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netdev-bot+sashiko@kernel.org
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
edumazet@kernel.org, horms@kernel.org, fw@strlen.de, ja@ssi.bg
Subject: Re: [PATCH net-next 03/15] netfilter: flowtable: retrieve stats on flow deletion
Date: Mon, 16 Nov 2026 00:22:13 +0100 [thread overview]
Message-ID: <avo-pZueHXPEOl66@chamomile> (raw)
In-Reply-To: <179462662110.2199510.725528221767942638@kernel.org>
On Sat, Nov 14, 2026 at 03:23:41AM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 2 · Low: 0
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] The core change only does anything when a driver writes
> f->stats in its FLOW_CLS_DESTROY handler.
> - [Medium] The final hardware stats are added to the conntrack
> asynchronously in flow_offload_work_del() ->…
>
> --
>
> netfilter: flowtable: retrieve stats on flow deletion
>
> This commit passes a flow_stats object to the driver on FLOW_CLS_DESTROY,
> so the final hardware counters can be synced into the conntrack entry
> when a flow is removed from hardware. The stats update logic moves out of
> flow_offload_work_stats() into a new flow_offload_update_stats() helper,
> which both the stats path and the delete path now use.
>
> Closes: https://patch.msgid.link/netfilter-devel/20261021175030.4800-1-dreyksmail@gmail.com/
>
> > diff --git a/net/netfilter/nf_flow_table_offload.c b/net/netfilter/nf_flow_table_offload.c
> > index 3a18fa48cadb0..c302051489f23 100644
> > --- a/net/netfilter/nf_flow_table_offload.c
> > +++ b/net/netfilter/nf_flow_table_offload.c
> > @@ -928,12 +928,33 @@ static int nf_flow_offload_tuple(struct nf_flowtable *flowtable,
>
> [ ... ]
>
> > +static void flow_offload_update_stats(struct flow_offload_work *offload,
> > + struct flow_stats *stats)
> > +{
> > + u64 lastused;
> > +
>
> [ ... ]
>
> > + if (offload->flowtable->flags & NF_FLOWTABLE_COUNTER) {
> > + if (stats[0].pkts)
> > + nf_ct_acct_add(offload->flow->ct,
> > + FLOW_OFFLOAD_DIR_ORIGINAL,
> > + stats[0].pkts, stats[0].bytes);
>
> [Severity: Medium]
> When we get here from flow_offload_work_del(), could the conntrack entry
> already have been deleted and reported?
>
> One of the triggers that queues the DESTROY work is a dying ct in
> nf_flow_offload_gc_step():
>
> net/netfilter/nf_flow_table_core.c:nf_flow_offload_gc_step() {
> ...
> nf_ct_is_dying(flow->ct) ||
> ...
> }
>
> By that point nf_ct_delete() has already set IPS_DYING, unlinked the
> entry and sent IPCT_DESTROY. That event carries the ct accounting
> counters to ctnetlink/ulogd:
>
> net/netfilter/nf_conntrack_core.c:nf_ct_delete() {
> ...
> if (test_and_set_bit(IPS_DYING_BIT, &ct->status))
> return false;
> ...
> if (nf_conntrack_event_report(IPCT_DESTROY, ct,
> portid, report) < 0) {
> ...
> }
>
> So when an offloaded ct is removed by conntrack -D or -F
This patch does not handle the conntrack -D or -F scenario, that would
require postponing the event delivery.
That is a pre-existing issue, this patch is not targeting at this
scenario.
I don't think the fix needed for this belong to this patch.
> by nf_ct_iterate_cleanup() on device or NAT events, or by netns teardown,
> the sequence looks like this:
>
> nf_ct_delete()
> IPCT_DESTROY event sent with the current counters
> nf_flow_offload_gc_step()
> nf_ct_is_dying() -> flow_offload_teardown() -> nf_flow_offload_del()
> flow_offload_work_handler()
> flow_offload_work_del()
> flow_offload_update_stats()
> nf_ct_acct_add()
>
> The counters added here go into a ct that nothing reports any more. On
> this path, the hardware traffic since the last FLOW_CLS_STATS poll is
> still lost.
>
> The common case, a flow expiring while its ct is still alive, looks
> fine. flow_offload_teardown() leaves the ct alive, and this update runs
> before the ct's own destroy event.
>
> Is the deleted-ct case meant to be covered by the "missing last stats
> sync" that the commit message describes?
>
> > + if (stats[1].pkts)
> > + nf_ct_acct_add(offload->flow->ct,
> > + FLOW_OFFLOAD_DIR_REPLY,
> > + stats[1].pkts, stats[1].bytes);
> > + }
> > +}
>
> [ ... ]
>
> > @@ -991,10 +1013,15 @@ static void flow_offload_work_add(struct flow_offload_work *offload)
> >
> > static void flow_offload_work_del(struct flow_offload_work *offload)
> > {
> > + struct flow_stats stats[FLOW_OFFLOAD_DIR_MAX] = {};
> > +
> > clear_bit(IPS_HW_OFFLOAD_BIT, &offload->flow->ct->status);
> > - flow_offload_tuple_del(offload, FLOW_OFFLOAD_DIR_ORIGINAL);
> > + flow_offload_tuple_del(offload, FLOW_OFFLOAD_DIR_ORIGINAL, &stats[0]);
> > if (test_bit(NF_FLOW_HW_BIDIRECTIONAL, &offload->flow->flags))
> > - flow_offload_tuple_del(offload, FLOW_OFFLOAD_DIR_REPLY);
> > + flow_offload_tuple_del(offload, FLOW_OFFLOAD_DIR_REPLY, &stats[1]);
> > +
> > + flow_offload_update_stats(offload, stats);
>
> [Severity: Medium]
> Won't stats[] still be all zero here for mlx5 and nfp?
>
> cls_flow is zero-initialised in nf_flow_offload_tuple(). If a driver's
> FLOW_CLS_DESTROY handler never writes f->stats, the memcpy() copies back
> zeroes, and flow_offload_update_stats() skips nf_ct_acct_add().
>
> Later patches in this series convert mtk_ppe and airoha ("net: ethernet:
> mtk_ppe: update stats on flow deletion" and "net: airoha: update stats on
> flow deletion"). Two other in-tree consumers still report nothing on
> DESTROY at the end of the series.
>
> In mlx5, mlx5_tc_ct_block_flow_offload_del() drops the counter through
> mlx5_tc_ct_entry_put(). It never calls mlx5_fc_query_cached() or
> flow_stats_update().
>
> In nfp, nfp_fl_ct_handle_nft_flow() does:
>
> case FLOW_CLS_DESTROY:
> ct_map_ent = rhashtable_lookup_fast(...);
> return nfp_fl_ct_del_flow(ct_map_ent);
>
> Both drivers report packet and byte deltas only from their
> FLOW_CLS_STATS handlers, mlx5_tc_ct_block_flow_offload_stats() and
> nfp_fl_ct_stats().
>
> Both register through act_ct, which turns on counter accounting:
>
> net/sched/act_ct.c:tcf_ct_flow_table_get() {
> ...
> ct_ft->nf_ft.flags |= NF_FLOWTABLE_HW_OFFLOAD |
> NF_FLOWTABLE_COUNTER;
> ...
> }
>
> So with tc act_ct offload on mlx5 or nfp, traffic forwarded between the
> last FLOW_CLS_STATS poll and the hardware delete is still missing from
> the conntrack counters.
>
> Given the Reported-by and Closes tags, should mlx5 and nfp be converted
> in this series as well? sfc doesn't seem to be affected, because
> efx_tc_ct_stats() only reports lastused.
>
> > +
> > set_bit(NF_FLOW_HW_DEAD, &offload->flow->flags);
> > }
>
> [ ... ]
>
> --
> Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113031251.2437074-2-pablo%40netfilter.org
next prev parent reply other threads:[~2026-11-15 23:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 3:12 [PATCH net-next 00/15] Netfilter updates for net-next Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 01/15] netfilter: flowtable: do not hw offload flows in teardown state Pablo Neira Ayuso
2026-11-13 3:17 ` netdev-bot+sinfo
2026-11-13 3:24 ` Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-15 23:12 ` Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 02/15] netfilter: flowtable: fix pmtu discovery in nf_flow_tunnel_ip6ip6_push() Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-15 23:19 ` Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 03/15] netfilter: flowtable: retrieve stats on flow deletion Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-15 23:22 ` Pablo Neira Ayuso [this message]
2026-11-13 3:12 ` [PATCH net-next 04/15] net: ethernet: mtk_ppe: update " Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-15 23:26 ` Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 05/15] net: airoha: " Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-15 23:26 ` Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 06/15] netfilter: xt_time: fix monthday computation for dates past 2039 Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-13 3:12 ` [PATCH net-next 07/15] netfilter: nft_flow_offload: do not offload multicast Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-13 3:12 ` [PATCH net-next 08/15] netfilter: lwtunnel: expose read-only sysctl nf_hooks_lwtunnel for non init-netns Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-15 23:29 ` Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 09/15] netfilter: flowtable: purge entries immediately when destroying the flowtable Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-13 3:12 ` [PATCH net-next 10/15] selftests: netfilter: nf_queue: drop the no-op loop initializer Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 11/15] netfilter: flowtable: do not scrub as crossing netns Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-15 23:30 ` Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 12/15] netfilter: flowtable: tunnel device poisons h_source of fast-path frames Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-13 3:12 ` [PATCH net-next 13/15] netfilter: flowtable: do not clear the offload bit twice Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 14/15] netfilter: nfnetlink_queue: make skb writable before writing NFQA_L2HDR Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 15/15] selftests: netfilter: add UDP flowtable offload test Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-15 23:46 ` [PATCH net-next 00/15] Netfilter updates for net-next Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avo-pZueHXPEOl66@chamomile \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=ja@ssi.bg \
--cc=kuba@kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.