From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netdev-bot+sashiko@kernel.org
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
edumazet@kernel.org, horms@kernel.org, fw@strlen.de, ja@ssi.bg
Subject: Re: [PATCH net-next 01/15] netfilter: flowtable: do not hw offload flows in teardown state
Date: Mon, 16 Nov 2026 00:12:54 +0100 [thread overview]
Message-ID: <avo8doGLhLtsvSIV@chamomile> (raw)
In-Reply-To: <179462661878.2199510.10033227088688888386@kernel.org>
Hi,
On Sat, Nov 14, 2026 at 03:23:38AM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
>
> Critical: 0 · High: 1 · Medium: 0 · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] The patch only partly closes the packet-path refresh race.
> - [Low] The commit fixes a race found by an automated reporter ('Sashiko
> reports...') but carries no Fixes:, Reported-by: or Closes: tag.
>
> --
>
> netfilter: flowtable: do not hw offload flows in teardown state
>
> This commit makes nf_flow_offload_refresh() check NF_FLOW_TEARDOWN again
> after NF_FLOW_PENDING has been acquired. The goal is to stop the packet
> path from queueing a hardware refresh for a flow that is going away. It
> relies on GC skipping flows that have NF_FLOW_PENDING set, which came in
> with commit 7c549fb7eecd.
>
> > Sashiko reports that refreshing hw offload from packet path is racy
> > since the flow might be already going away.
> >
> > Since commit 7c549fb7eecd ("netfilter: flowtable: generalize pending
> > status bit"), GC skips flow entries that are still pending to be
> > offloaded. Let's just check for the teardown status bit after the
> > pending bit is set on to address this race.
>
> [Severity: Low]
> This isn't a bug, but should this have Fixes:, Reported-by: and Closes:
> tags for the report?
>
> The fix only works on trees where nf_flow_offload_gc_step() already skips
> flows with NF_FLOW_PENDING set:
>
> if (test_bit(NF_FLOW_PENDING, &flow->flags))
> return;
>
> That check came from commit 7c549fb7eecd. A stable backport to a tree
> without that commit would leave the race open.
>
> Could the message record this dependency? Could it also state the
> consequence, which is offload work queued on a flow that GC frees, i.e. a
> possible use-after-free?
>
> > diff --git a/net/netfilter/nf_flow_table_offload.c b/net/netfilter/nf_flow_table_offload.c
> > index 4365859220e6a..3a18fa48cadb0 100644
> > --- a/net/netfilter/nf_flow_table_offload.c
> > +++ b/net/netfilter/nf_flow_table_offload.c
> > @@ -1120,6 +1120,12 @@ void nf_flow_offload_refresh(struct nf_flowtable *flowtable,
> > if (!offload)
> > return;
> >
> > + if (test_bit(NF_FLOW_TEARDOWN, &flow->flags)) {
> > + clear_bit(NF_FLOW_PENDING, &flow->flags);
> > + kfree(offload);
> > + return;
> > + }
> > +
> > flow_offload_queue_work(offload);
> > }
>
> [Severity: High]
> Does this close the race for flows that are only in the NF_FLOW_CLOSING
> state?
This patch is intended to address the TEARDOWN race only as described.
> GC also sends a hardware DESTROY for a CLOSING flow while TEARDOWN is
> still clear. This happens in nf_flow_offload_gc_step():
>
> } else if (test_bit(NF_FLOW_CLOSING, &flow->flags) &&
> test_bit(NF_FLOW_HW, &flow->flags) &&
> !test_bit(NF_FLOW_HW_DYING, &flow->flags)) {
> nf_flow_offload_del(flow_table, flow);
>
> On the packet path, flow_offload_refresh() is the only place that tests
> CLOSING, and it does so before PENDING is taken:
>
> if (likely(!nf_flowtable_hw_offload(flow_table)) ||
> test_bit(NF_FLOW_CLOSING, &flow->flags))
> return;
>
> if (test_bit(NF_FLOW_HW, &flow->flags))
> nf_flow_offload_refresh(flow_table, flow);
>
> Could this sequence happen?
>
> CPU B (packet path)
> flow_offload_refresh()
> sees CLOSING == 0 and NF_FLOW_HW set
> <stalls before test_and_set_bit(NF_FLOW_PENDING)>
>
> CPU A
> nf_flow_state_check() on FIN/RST
> sets NF_FLOW_CLOSING
It seems CPU A is also on packet path. Two TCP packets of the same
flow going through different CPUs is unlikely to happen. This also
assumes preemptible softirq, ie. PREEMPT_RT.
I will have closer look to search for possible issues with the CLOSING
state but that this patch is specifically aiming at the TEARDOWN state
only.
> GC
> nf_flow_offload_gc_step()
> nf_flow_offload_del()
> takes PENDING, sets NF_FLOW_HW_DYING, queues DESTROY
> flow_offload_work_del()
> removes the rule, sets NF_FLOW_HW_DEAD
> PENDING is cleared
>
> CPU B resumes
> nf_flow_offload_refresh()
> nf_flow_offload_work_alloc() wins PENDING
> test_bit(NF_FLOW_TEARDOWN) == 0
> flow_offload_queue_work() with FLOW_CLS_REPLACE
>
> flow_offload_work_add() does not check NF_FLOW_HW_DYING or
> NF_FLOW_HW_DEAD. It installs the hardware rule again and sets
> IPS_HW_OFFLOAD_BIT.
>
> Nothing clears HW_DYING or HW_DEAD after that. When the flow later
> expires, the teardown branch in nf_flow_offload_gc_step() goes straight
> to flow_offload_del() and sends no new DESTROY:
>
> if (test_bit(NF_FLOW_HW, &flow->flags)) {
> if (!test_bit(NF_FLOW_HW_DYING, &flow->flags))
> nf_flow_offload_del(flow_table, flow);
> else if (test_bit(NF_FLOW_HW_DEAD, &flow->flags))
> flow_offload_del(flow_table, flow);
>
> Would the re-installed rule then stay in the driver and hardware after
> the flow and its conntrack entry are freed? Its cookie is the address of
> the freed tuple, so a new flow allocated at the same address could
> collide with it.
>
> There seems to be a worse interleaving as well:
>
> 1. GC reads PENDING == 0 at the top of nf_flow_offload_gc_step().
> 2. CPU B wins PENDING and reads TEARDOWN == 0.
> 3. GC calls flow_offload_teardown(). HW_DYING and HW_DEAD are already set
> from the CLOSING DESTROY, so GC frees the flow through
> flow_offload_del() without taking PENDING.
>
> Can the queued REPLACE work then run on a flow that was freed via
> call_rcu()?
>
> The window is narrow. It still looks reachable on PREEMPT_RT, where
> softirq is preemptible, or under vCPU preemption. The FIN/RST that starts
> it comes from the network.
A follow up patch could possibly discard refreshing entries for
fin/rst packets, but this is unrelated to this patch.
> NF_FLOW_HW_DYING is set while PENDING is held, and it is published before
> PENDING is cleared. Would re-checking NF_FLOW_HW_DYING (and/or
> NF_FLOW_CLOSING) here, after PENDING is acquired, cover every state in
> which GC has already issued the DESTROY?
>
> Later patches in the series don't appear to change
> nf_flow_offload_refresh() or flow_offload_refresh().
>
> --
> Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113031251.2437074-2-pablo%40netfilter.org
next prev parent reply other threads:[~2026-11-15 23:13 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 3:12 [PATCH net-next 00/15] Netfilter updates for net-next Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 01/15] netfilter: flowtable: do not hw offload flows in teardown state Pablo Neira Ayuso
2026-11-13 3:17 ` netdev-bot+sinfo
2026-11-13 3:24 ` Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-15 23:12 ` Pablo Neira Ayuso [this message]
2026-11-13 3:12 ` [PATCH net-next 02/15] netfilter: flowtable: fix pmtu discovery in nf_flow_tunnel_ip6ip6_push() Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-15 23:19 ` Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 03/15] netfilter: flowtable: retrieve stats on flow deletion Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-15 23:22 ` Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 04/15] net: ethernet: mtk_ppe: update " Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-15 23:26 ` Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 05/15] net: airoha: " Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-15 23:26 ` Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 06/15] netfilter: xt_time: fix monthday computation for dates past 2039 Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-13 3:12 ` [PATCH net-next 07/15] netfilter: nft_flow_offload: do not offload multicast Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-13 3:12 ` [PATCH net-next 08/15] netfilter: lwtunnel: expose read-only sysctl nf_hooks_lwtunnel for non init-netns Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-15 23:29 ` Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 09/15] netfilter: flowtable: purge entries immediately when destroying the flowtable Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-13 3:12 ` [PATCH net-next 10/15] selftests: netfilter: nf_queue: drop the no-op loop initializer Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 11/15] netfilter: flowtable: do not scrub as crossing netns Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-15 23:30 ` Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 12/15] netfilter: flowtable: tunnel device poisons h_source of fast-path frames Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-13 3:12 ` [PATCH net-next 13/15] netfilter: flowtable: do not clear the offload bit twice Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 14/15] netfilter: nfnetlink_queue: make skb writable before writing NFQA_L2HDR Pablo Neira Ayuso
2026-11-13 3:12 ` [PATCH net-next 15/15] selftests: netfilter: add UDP flowtable offload test Pablo Neira Ayuso
2026-11-14 3:23 ` netdev-bot+sashiko
2026-11-15 23:46 ` [PATCH net-next 00/15] Netfilter updates for net-next Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avo8doGLhLtsvSIV@chamomile \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=ja@ssi.bg \
--cc=kuba@kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.