All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netdev-bot+sashiko@kernel.org
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
	netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
	edumazet@kernel.org, horms@kernel.org, fw@strlen.de, ja@ssi.bg
Subject: Re: [PATCH net-next 11/15] netfilter: flowtable: do not scrub as crossing netns
Date: Mon, 16 Nov 2026 00:30:42 +0100	[thread overview]
Message-ID: <avpAomzTPmMItRAg@chamomile> (raw)
In-Reply-To: <179462662909.2199510.3682917191750887644@kernel.org>

On Sat, Nov 14, 2026 at 03:23:49AM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found more severe
> issue(s) in other patches of this series. This mail is only an FYI, in case
> you want to address the nit picks below when you respin.
> 
> Low priority / nit picks for your consideration:
> 
> - [Low] The Fixes: tag and the commit message cover only one of the two
>   changed call sites.
> 
> Pre-existing issues:
> - [Medium] This problem wasn't introduced by this patch.
> 
> --
> 
> netfilter: flowtable: do not scrub as crossing netns
> 
> This commit changes the flowtable tunnel push helpers from
> skb_scrub_packet(skb, true) to skb_scrub_packet(skb, false). The skb mark
> is now kept on encapsulated packets. The commit message says the IPIP
> tunneling fast path does not cross a netns.
> 
> > diff --git a/net/netfilter/nf_flow_table_ip.c b/net/netfilter/nf_flow_table_ip.c
> > index 644e70fd6773b..001abfae5a1ff 100644
> > --- a/net/netfilter/nf_flow_table_ip.c
> > +++ b/net/netfilter/nf_flow_table_ip.c
> > @@ -630,7 +630,7 @@ static int nf_flow_tunnel_ip_push(struct net *net, struct sk_buff *skb,
> >  	if (err)
> >  		return err;
> >  
> > -	skb_scrub_packet(skb, true);
> > +	skb_scrub_packet(skb, false);
> 
> [Severity: Medium]
> This is a pre-existing issue and was not introduced by this patch. Is
> the hard-coded xnet = false in nf_flow_tunnel_ip_push() and
> nf_flow_tunnel_ip6_push() correct only because the fast path routes in
> dev_net(dev) and not in the tunnel's link netns?
> 
> The slow path routes in tunnel->net or t->net, and it decides xnet per
> device:
> 
> net/ipv4/ip_tunnel.c:ip_tunnel_xmit() {
>     ...
> 	iptunnel_xmit(NULL, rt, skb, fl4.saddr, fl4.daddr, proto, tos, ttl,
> 		      df, !net_eq(tunnel->net, dev_net(dev)), 0);
>     ...
> }
> 
> net/ipv6/ip6_tunnel.c:ip6_tnl_xmit() {
>     ...
> 	skb_scrub_packet(skb, !net_eq(t->net, dev_net(dev)));
>     ...
> }
> 
> The forward path helpers that admit the flow look up the outer route in
> the device netns instead:
> 
> net/ipv4/ipip.c:ipip_fill_forward_path() {
>     ...
> 	rt = ip_route_output(dev_net(ctx->dev), tiph->daddr, tiph->saddr,
> 			     inet_dsfield_to_dscp(tiph->tos),
> 			     tunnel->parms.link, RT_SCOPE_UNIVERSE);
>     ...
> }
> 
> net/ipv6/ip6_tunnel.c:ip6_tnl_fill_forward_path() {
>     ...
> 	dst = ip6_route_output(dev_net(ctx->dev), NULL, &fl6);
>     ...
> }
> 
> Neither helper rejects a tunnel whose link netns differs from
> dev_net(dev). nft_dev_path_info() does not reject it either, because it
> only checks nft_flowtable_find_dev(info->dev, ft).

Not sure this is correct, if you move a netdevice in a flowtable to
another netns, it gets removed from the flowtable.

> Take an ipip or ip6tnl device whose link netns is A but which lives in
> netns B. Could the offloaded packets of a flow be routed with B's routing
> table, while the slow-path packets of the same flow leave through A's
> underlay?
> 
> With this patch the two paths would also handle skb->mark differently.
> The slow path clears it and the fast path keeps it.
> 
> Could ipip_fill_forward_path() and ip6_tnl_fill_forward_path() return
> -EOPNOTSUPP when the tunnel's link netns differs from dev_net(dev)? That
> would also keep xnet = false correct. Another option is to route in
> tunnel->net and carry the real xnet value through flow_offload_tunnel.
> 
> > @@ -702,7 +702,7 @@ static int nf_flow_tunnel_ip6_push(struct net *net, struct sk_buff *skb,
> >  	mtu = dst_mtu(dst) - sizeof(*ip6h);
> >  	mtu = max(mtu, IPV6_MIN_MTU);
> >  	skb_dst_update_pmtu_no_confirm(skb, mtu);
> > -	skb_scrub_packet(skb, true);
> > +	skb_scrub_packet(skb, false);
> 
> [Severity: Low]
> This isn't a bug, but the skb_scrub_packet() call in
> nf_flow_tunnel_ip6_push() came from 93cf357fa797 ("netfilter: flowtable:
> Add IP6IP6 tx sw acceleration"). It did not come from the commit named
> in the tag:
> 
>   Fixes: d30301ba4b07 ("netfilter: flowtable: Add IPIP tx sw acceleration")
> 
> The commit message also only talks about "IPIP tunneling support".
> However, this hunk changes the IPv6-outer encapsulation path too, so
> skb->mark is now kept on those packets as well.
> 
> Earlier in the same series, "netfilter: flowtable: fix pmtu discovery in
> nf_flow_tunnel_ip6ip6_push()" uses Fixes: 93cf357fa797 for this same
> function.
> 
> Should a Fixes: tag for 93cf357fa797 be added, and should the commit
> message mention the IPv6-outer path?
> 
> [ ... ]
> 
> -- 
> Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113031251.2437074-2-pablo%40netfilter.org

  reply	other threads:[~2026-11-15 23:30 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  3:12 [PATCH net-next 00/15] Netfilter updates for net-next Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 01/15] netfilter: flowtable: do not hw offload flows in teardown state Pablo Neira Ayuso
2026-11-13  3:17   ` netdev-bot+sinfo
2026-11-13  3:24     ` Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:12     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 02/15] netfilter: flowtable: fix pmtu discovery in nf_flow_tunnel_ip6ip6_push() Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:19     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 03/15] netfilter: flowtable: retrieve stats on flow deletion Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:22     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 04/15] net: ethernet: mtk_ppe: update " Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:26     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 05/15] net: airoha: " Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:26     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 06/15] netfilter: xt_time: fix monthday computation for dates past 2039 Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-13  3:12 ` [PATCH net-next 07/15] netfilter: nft_flow_offload: do not offload multicast Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-13  3:12 ` [PATCH net-next 08/15] netfilter: lwtunnel: expose read-only sysctl nf_hooks_lwtunnel for non init-netns Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:29     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 09/15] netfilter: flowtable: purge entries immediately when destroying the flowtable Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-13  3:12 ` [PATCH net-next 10/15] selftests: netfilter: nf_queue: drop the no-op loop initializer Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 11/15] netfilter: flowtable: do not scrub as crossing netns Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:30     ` Pablo Neira Ayuso [this message]
2026-11-13  3:12 ` [PATCH net-next 12/15] netfilter: flowtable: tunnel device poisons h_source of fast-path frames Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-13  3:12 ` [PATCH net-next 13/15] netfilter: flowtable: do not clear the offload bit twice Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 14/15] netfilter: nfnetlink_queue: make skb writable before writing NFQA_L2HDR Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 15/15] selftests: netfilter: add UDP flowtable offload test Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:46 ` [PATCH net-next 00/15] Netfilter updates for net-next Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avpAomzTPmMItRAg@chamomile \
    --to=pablo@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=ja@ssi.bg \
    --cc=kuba@kernel.org \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.