All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netdev-bot+sashiko@kernel.org
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
	netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
	edumazet@kernel.org, horms@kernel.org, fw@strlen.de, ja@ssi.bg
Subject: Re: [PATCH net-next 04/15] net: ethernet: mtk_ppe: update stats on flow deletion
Date: Mon, 16 Nov 2026 00:26:03 +0100	[thread overview]
Message-ID: <avo_iwv4AZdPu2Lm@chamomile> (raw)
In-Reply-To: <179462662226.2199510.18334585380250309949@kernel.org>

On Sat, Nov 14, 2026 at 03:23:42AM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 0 · Medium: 2 · Low: 0
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [Medium] Bridge (L2) flows on mtk_ppe: the new destroy-time call to
>   mtk_flow_offload_update_stats() read-clears the hardware MIB counter…
> - [Medium] mtk_flow_offload_destroy() takes the final MIB snapshot before
>   it invalidates the hardware FOE entry, so the 'last stats sync' on…
> 
> --
> 
> net: ethernet: mtk_ppe: update stats on flow deletion
> 
> This moves the stats collection out of mtk_flow_offload_stats() into a new
> helper, mtk_flow_offload_update_stats(). The helper is also called from
> mtk_flow_offload_destroy(), so the final hardware counters are reported
> when a flow is deleted. This follows "netfilter: flowtable: retrieve stats
> on flow deletion".
> 
> > diff --git a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
> > index 99b28aaa7cc47..8ca694bb5e1b7 100644
> > --- a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
> > +++ b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
> > @@ -526,6 +526,24 @@ mtk_flow_offload_replace(struct mtk_eth *eth, struct flow_cls_offload *f,
> >  	return err;
> >  }
> >  
> > +static void
> > +mtk_flow_offload_update_stats(struct mtk_eth *eth, struct flow_cls_offload *f,
> > +			      struct mtk_flow_entry *entry)
> > +{
> > +	struct mtk_foe_accounting diff;
> > +	u32 idle;
> > +
> > +	idle = mtk_foe_entry_idle_time(eth->ppe[entry->ppe_index], entry);
> > +	f->stats.lastused = jiffies - idle * HZ;
> > +
> > +	if (entry->hash != 0xFFFF &&
> > +	    mtk_foe_entry_get_mib(eth->ppe[entry->ppe_index], entry->hash,
> > +				  &diff)) {
> 
> [Severity: Medium]
> When a bridge (L2) flow is destroyed, can this read-clear the hardware
> counter of an unrelated flow?

Maybe, but that is a pre-existing issue.

This patch is just adapting the driver to use the new call to stats
when deleting a flow, it reuses the existing codebase.

> For a flower rule with only ETH_ADDRS, mtk_flow_offload_replace()
> allocates the entry with kzalloc_obj(), so entry->hash starts at 0.
> mtk_foe_entry_commit() then takes the L2 path:
> 
> drivers/net/ethernet/mediatek/mtk_ppe.c:mtk_foe_entry_commit() {
> 	...
> 	if (type == MTK_PPE_PKT_TYPE_BRIDGE)
> 		return mtk_foe_entry_commit_l2(ppe, entry);
> 
> 	hash = mtk_ppe_hash_entry(ppe->eth, &entry->data);
> 	entry->hash = 0xffff;
> 	...
> }
> 
> mtk_foe_entry_commit_l2() never sets entry->hash = 0xffff. The base L2
> entry is not on the foe_flow lists, so __mtk_ppe_check_skb() never updates
> its hash. mtk_flow_entry_update_l2() only touches the subflow hashes. As a
> result, the base entry keeps hash == 0 for its whole lifetime.
> 
> That means the entry->hash != 0xFFFF check passes and
> mtk_foe_entry_get_mib(ppe, 0, &diff) runs. mtk_ppe_start() enables
> MTK_PPE_MIB_CFG_RD_CLR, so this read zeroes the MIB counter of whatever
> flow is bound at FOE index 0, for example an nf_flowtable L3 flow. Those
> packets and bytes get charged to the L2 rule and never reach their real
> owner.
> 
> The bridge flow's own counters live in the subflow slots on
> entry->l2_flows, and this function never reads them. So the destroy-time
> stats for L2 flows are wrong as well.
> 
> The missing 0xffff on L2 base entries is not new. Before this patch,
> though, mtk_flow_offload_destroy() never touched the MIB. Now every
> FLOW_CLS_DESTROY of a bridge flow does this read-clear, even when nobody
> requested stats for that rule.
> 
> Should L2 base entries be skipped here? Alternatively, should
> mtk_foe_entry_commit_l2() set entry->hash to 0xffff?
> 
> > +		f->stats.pkts += diff.packets;
> > +		f->stats.bytes += diff.bytes;
> > +	}
> > +}
> > +
> >  static int
> >  mtk_flow_offload_destroy(struct mtk_eth *eth, struct flow_cls_offload *f)
> >  {
> > @@ -536,6 +554,8 @@ mtk_flow_offload_destroy(struct mtk_eth *eth, struct flow_cls_offload *f)
> >  	if (!entry)
> >  		return -ENOENT;
> >  
> > +	mtk_flow_offload_update_stats(eth, f, entry);
> > +
> >  	mtk_foe_entry_clear(eth->ppe[entry->ppe_index], entry);
> 
> [Severity: Medium]
> Is this snapshot really the final one for the flow?
> 
> mtk_flow_offload_update_stats() read-clears MIB[entry->hash] while the
> hardware FOE entry is still in BIND state. ppe_lock is dropped between
> the two steps. The entry is only invalidated later, under ppe_lock, in
> __mtk_foe_entry_clear():
> 
> drivers/net/ethernet/mediatek/mtk_ppe.c:__mtk_foe_entry_clear() {
> 	...
> 		hwe->ib1 &= ~MTK_FOE_IB1_STATE;
> 		hwe->ib1 |= FIELD_PREP(MTK_FOE_IB1_STATE, MTK_FOE_STATE_INVALID);
> 		dma_wmb();
> 		mtk_ppe_cache_clear(ppe);
> 
> 		if (ppe->accounting) {
> 			...
> 			acct->packets = 0;
> 			acct->bytes = 0;
> 		}
> 	}
> 	entry->hash = 0xffff;
> 	...
> }
> 
> Between the MIB read and the invalidation, the PPE keeps forwarding and
> counting packets for this flow. That traffic never reaches f->stats. It
> stays in the hardware MIB counter, because only the software acct_table
> is zeroed here.
> 
> __mtk_foe_entry_commit() doesn't clear the MIB either. So the next
> read-clear of that index charges those packets to whichever flow binds
> the slot next.
> 
> This happens whenever an active flow is torn down, for example on a
> flowtable flush, a conntrack flush or a ruleset deletion.
> 
> Would it work to invalidate the entry first and then drain
> MIB[saved hash]?
> 
> >  	rhashtable_remove_fast(&eth->flow_table, &entry->node,
> >  			       mtk_flow_ht_params);
> 
> [ ... ]
> 
> -- 
> Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113031251.2437074-2-pablo%40netfilter.org

  reply	other threads:[~2026-11-15 23:26 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  3:12 [PATCH net-next 00/15] Netfilter updates for net-next Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 01/15] netfilter: flowtable: do not hw offload flows in teardown state Pablo Neira Ayuso
2026-11-13  3:17   ` netdev-bot+sinfo
2026-11-13  3:24     ` Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:12     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 02/15] netfilter: flowtable: fix pmtu discovery in nf_flow_tunnel_ip6ip6_push() Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:19     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 03/15] netfilter: flowtable: retrieve stats on flow deletion Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:22     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 04/15] net: ethernet: mtk_ppe: update " Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:26     ` Pablo Neira Ayuso [this message]
2026-11-13  3:12 ` [PATCH net-next 05/15] net: airoha: " Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:26     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 06/15] netfilter: xt_time: fix monthday computation for dates past 2039 Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-13  3:12 ` [PATCH net-next 07/15] netfilter: nft_flow_offload: do not offload multicast Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-13  3:12 ` [PATCH net-next 08/15] netfilter: lwtunnel: expose read-only sysctl nf_hooks_lwtunnel for non init-netns Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:29     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 09/15] netfilter: flowtable: purge entries immediately when destroying the flowtable Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-13  3:12 ` [PATCH net-next 10/15] selftests: netfilter: nf_queue: drop the no-op loop initializer Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 11/15] netfilter: flowtable: do not scrub as crossing netns Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:30     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 12/15] netfilter: flowtable: tunnel device poisons h_source of fast-path frames Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-13  3:12 ` [PATCH net-next 13/15] netfilter: flowtable: do not clear the offload bit twice Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 14/15] netfilter: nfnetlink_queue: make skb writable before writing NFQA_L2HDR Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 15/15] selftests: netfilter: add UDP flowtable offload test Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:46 ` [PATCH net-next 00/15] Netfilter updates for net-next Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avo_iwv4AZdPu2Lm@chamomile \
    --to=pablo@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=ja@ssi.bg \
    --cc=kuba@kernel.org \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.