All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netdev-bot+sashiko@kernel.org
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
	netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
	edumazet@kernel.org, horms@kernel.org, fw@strlen.de, ja@ssi.bg
Subject: Re: [PATCH net-next 08/15] netfilter: lwtunnel: expose read-only sysctl nf_hooks_lwtunnel for non init-netns
Date: Mon, 16 Nov 2026 00:29:04 +0100	[thread overview]
Message-ID: <avpAQDC_eXLe72NR@chamomile> (raw)
In-Reply-To: <179462662676.2199510.16804675187126889146@kernel.org>

On Sat, Nov 14, 2026 at 03:23:46AM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 0 · Medium: 1 · Low: 1
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [Medium] The patch sets the per-netns copy of
>   net.netfilter.nf_hooks_lwtunnel to mode 0444 in nf_lwtunnel_net_init()…
> - [Low] The nf_hooks_lwtunnel entry in
>   Documentation/networking/nf_conntrack-sysctl.rst (lines 212-217)…
> 
> --
> 
> netfilter: lwtunnel: expose read-only sysctl nf_hooks_lwtunnel for non init-netns
> 
> The commit registers the per-netns copy of the nf_hooks_lwtunnel sysctl
> with mode 0444 instead of 0644 in every netns except init_net. This stops
> unprivileged users from flipping the global nf_hooks_lwtunnel_enabled
> static key from inside a user namespace.
> 
> > diff --git a/net/netfilter/nf_hooks_lwtunnel.c b/net/netfilter/nf_hooks_lwtunnel.c
> > index 40c6fce14a63f..7e2ee8677f1fc 100644
> > --- a/net/netfilter/nf_hooks_lwtunnel.c
> > +++ b/net/netfilter/nf_hooks_lwtunnel.c
> > @@ -68,14 +68,18 @@ static int __net_init nf_lwtunnel_net_init(struct net *net)
> 
> [ ... ]
> 
> >  	if (!net_eq(net, &init_net)) {
> > -		table = kmemdup(nf_lwtunnel_sysctl_table,
> > -				sizeof(nf_lwtunnel_sysctl_table),
> > -				GFP_KERNEL_ACCOUNT);
> > -		if (!table)
> > +		dup = kmemdup(nf_lwtunnel_sysctl_table,
> > +			      sizeof(nf_lwtunnel_sysctl_table),
> > +			      GFP_KERNEL_ACCOUNT);
> > +		if (!dup)
> >  			goto err_alloc;
> > +
> > +		dup->mode = 0444;
> > +		table = dup;
> 
> [Severity: Medium]
> Should the SRv6 netfilter selftests be updated along with this change?

That test needs an update yes, I'd prefer to address this in a follow
up patch.

> With 0444, nobody can write the knob from a child netns, including global
> root with CAP_NET_ADMIN. net_ctl_permissions() copies only the owner bits:
> 
> net/sysctl_net.c:net_ctl_permissions() {
>     ...
> 	if (ns_capable_noaudit(net->user_ns, CAP_NET_ADMIN)) {
> 		int mode = (table->mode >> 6) & 7;
> 		return (mode << 6) | (mode << 3) | mode;
> 	}
>     ...
> }
> 
> test_perm() in fs/proc/proc_sysctl.c does not let root override this, so
> the write returns -EACCES.
> 
> Both tools/testing/selftests/net/srv6_end_dx4_netfilter_test.sh and
> srv6_end_dx6_netfilter_test.sh write the knob from the rt-N netns in
> setup_rt_netfilter():
> 
> 	ip netns exec ${nsname} sysctl -wq net.netfilter.nf_hooks_lwtunnel=1
> 
> The scripts don't check the exit status, so the failure goes unnoticed.
> nf_hooks_lwtunnel_enabled then stays off, and decapsulated SRv6 packets
> never reach the NF_HOOK(NF_INET_PRE_ROUTING) calls in seg6_local.c.
> 
> router_netfilter_tests() only checks ping connectivity:
> 
> 	setup_rt_netfilter 1
> 	setup_rt_netfilter 2
> 
> 	check_and_log_hs_connectivity 1 2 100
> 
> Plain SRv6 forwarding works without the hooks, so the "netfilter enabled
> in routers" tests would still pass without running the netfilter path at
> all.
> 
> Userspace sees the same change: a privileged container manager that used
> to enable this knob as real root from inside a pod netns will now get
> EACCES and has to write it in init_net instead.
> 
> The restriction itself matches other global netfilter sysctls, such as
> those in nf_conntrack_standalone.c and ipvs. The concern is only that the
> dependent selftests stay as they are. As of 3e59905baa0f, both scripts
> still write the sysctl from rt-N.
> 
> [Severity: Low]
> This isn't a bug, but should the nf_hooks_lwtunnel entry in
> Documentation/networking/nf_conntrack-sysctl.rst mention the new
> restriction?
> 
> The entry currently reads:
> 
> 	nf_hooks_lwtunnel - BOOLEAN
> 		- 0 - disabled (default)
> 		- not 0 - enabled
> 
> 		If this option is enabled, the lightweight tunnel netfilter hooks are
> 		enabled. This option cannot be disabled once it is enabled.
> 
> The same document already has this note for nf_conntrack_buckets:
> 
> 	This sysctl is only writeable in the initial net namespace.
> 
> A similar note here would explain the EACCES that users now get when they
> write the knob from a child netns. As of 3e59905baa0f, the entry is
> unchanged.
> 
> >  	}
> >  
> >  	hdr = register_net_sysctl_sz(net, "net/netfilter", table,
> 
> -- 
> Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113031251.2437074-2-pablo%40netfilter.org

  reply	other threads:[~2026-11-15 23:29 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  3:12 [PATCH net-next 00/15] Netfilter updates for net-next Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 01/15] netfilter: flowtable: do not hw offload flows in teardown state Pablo Neira Ayuso
2026-11-13  3:17   ` netdev-bot+sinfo
2026-11-13  3:24     ` Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:12     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 02/15] netfilter: flowtable: fix pmtu discovery in nf_flow_tunnel_ip6ip6_push() Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:19     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 03/15] netfilter: flowtable: retrieve stats on flow deletion Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:22     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 04/15] net: ethernet: mtk_ppe: update " Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:26     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 05/15] net: airoha: " Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:26     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 06/15] netfilter: xt_time: fix monthday computation for dates past 2039 Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-13  3:12 ` [PATCH net-next 07/15] netfilter: nft_flow_offload: do not offload multicast Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-13  3:12 ` [PATCH net-next 08/15] netfilter: lwtunnel: expose read-only sysctl nf_hooks_lwtunnel for non init-netns Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:29     ` Pablo Neira Ayuso [this message]
2026-11-13  3:12 ` [PATCH net-next 09/15] netfilter: flowtable: purge entries immediately when destroying the flowtable Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-13  3:12 ` [PATCH net-next 10/15] selftests: netfilter: nf_queue: drop the no-op loop initializer Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 11/15] netfilter: flowtable: do not scrub as crossing netns Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:30     ` Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 12/15] netfilter: flowtable: tunnel device poisons h_source of fast-path frames Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-13  3:12 ` [PATCH net-next 13/15] netfilter: flowtable: do not clear the offload bit twice Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 14/15] netfilter: nfnetlink_queue: make skb writable before writing NFQA_L2HDR Pablo Neira Ayuso
2026-11-13  3:12 ` [PATCH net-next 15/15] selftests: netfilter: add UDP flowtable offload test Pablo Neira Ayuso
2026-11-14  3:23   ` netdev-bot+sashiko
2026-11-15 23:46 ` [PATCH net-next 00/15] Netfilter updates for net-next Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avpAQDC_eXLe72NR@chamomile \
    --to=pablo@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=ja@ssi.bg \
    --cc=kuba@kernel.org \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.