Re: [PATCH v5 01/15] hw/riscv/fdt-common: prepend helpers with "riscv_"

["Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>]

Hi Daniel,

On 28/8/26 22:39, Daniel Henrique Barboza wrote:
> Given that the helpers are public API we should prefix them with
> "riscv_" to avoid conflicts when linking with different targets in the
> future, i.e. we should not use generic names like
> "create_fdt_socket_memory".
> 
> Despite the amount of lines this is a mechanical change and no real
> FDT changes are intended.
> 
> Suggested-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
> Signed-off-by: Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>
> Reviewed-by: Chao Liu <chao.liu@processmission.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
> ---
>   hw/riscv/fdt-common.c         | 45 ++++++++++++++++----------------
>   hw/riscv/sifive_u.c           | 34 +++++++++++++------------
>   hw/riscv/spike.c              | 30 ++++++++++++----------
>   hw/riscv/tt_atlantis.c        | 22 ++++++++--------
>   hw/riscv/virt.c               | 42 +++++++++++++++---------------
>   include/hw/riscv/fdt-common.h | 48 ++++++++++++++++++-----------------
>   6 files changed, 117 insertions(+), 104 deletions(-)

I had the following patch tagged but it will conflict with your
series which is apparently ready (and at v5):
https://lore.kernel.org/qemu-devel/20260823150731.896-6-luoyonggang@gmail.com/
I'll let see with Yonggang what is the simpler (likely have
his patch rebased once your series is merged).

Regards,

Phil.