From: Marc Zyngier <maz@kernel.org>
To: Joey Gouly <joey.gouly@arm.com>
Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
kvm@vger.kernel.org, James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Oliver Upton <oliver.upton@linux.dev>,
Zenghui Yu <yuzenghui@huawei.com>,
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>,
Xu Zhao <zhaoxu.35@bytedance.com>,
Eric Auger <eric.auger@redhat.com>
Subject: Re: [PATCH v2 03/11] KVM: arm64: vgic-v3: Refactor GICv3 SGI generation
Date: Thu, 21 Sep 2023 12:13:08 +0100 [thread overview]
Message-ID: <d905e62015f27949c3c08c7579e489ca@kernel.org> (raw)
In-Reply-To: <20230921094225.GA2926762@e124191.cambridge.arm.com>
On 2023-09-21 10:42, Joey Gouly wrote:
> Hi Marc, Oliver,
>
> On Wed, Sep 20, 2023 at 07:17:23PM +0100, Marc Zyngier wrote:
>> As we're about to change the way SGIs are sent, start by splitting
>> out some of the basic functionnality: instead of intermingling
>> the broadcast and non-broadcast cases with the actual SGI generation,
>> perform the following cleanups:
>>
>> - move the SGI queuing into its own helper
>> - split the broadcast code from the affinity-driven code
>> - replace the mask/shift combinations with FIELD_GET()
>>
>> The result is much more readable, and paves the way for further
>> optimisations.
>>
>> Reviewed-by: Joey Gouly <joey.gouly@arm.com>
>
> Want to point out that I didn't review this code, I only reviewed
> patches 1-3
> from the original series.
Ah crap. I try to make sure I was only tagging the right patches,
but obviously failed... :-( Really sorry about that.
> https://lore.kernel.org/linux-arm-kernel/20230907100931.1186690-1-maz@kernel.org/
>
> Since it seems Oliver is picking it up, can you remove my r-b tag from
> this patch.
Well, Zenghui has found a couple of issues, so there will be a third
revision for sure. I'll amend the patch right away.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Joey Gouly <joey.gouly@arm.com>
Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
kvm@vger.kernel.org, James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Oliver Upton <oliver.upton@linux.dev>,
Zenghui Yu <yuzenghui@huawei.com>,
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>,
Xu Zhao <zhaoxu.35@bytedance.com>,
Eric Auger <eric.auger@redhat.com>
Subject: Re: [PATCH v2 03/11] KVM: arm64: vgic-v3: Refactor GICv3 SGI generation
Date: Thu, 21 Sep 2023 12:13:08 +0100 [thread overview]
Message-ID: <d905e62015f27949c3c08c7579e489ca@kernel.org> (raw)
In-Reply-To: <20230921094225.GA2926762@e124191.cambridge.arm.com>
On 2023-09-21 10:42, Joey Gouly wrote:
> Hi Marc, Oliver,
>
> On Wed, Sep 20, 2023 at 07:17:23PM +0100, Marc Zyngier wrote:
>> As we're about to change the way SGIs are sent, start by splitting
>> out some of the basic functionnality: instead of intermingling
>> the broadcast and non-broadcast cases with the actual SGI generation,
>> perform the following cleanups:
>>
>> - move the SGI queuing into its own helper
>> - split the broadcast code from the affinity-driven code
>> - replace the mask/shift combinations with FIELD_GET()
>>
>> The result is much more readable, and paves the way for further
>> optimisations.
>>
>> Reviewed-by: Joey Gouly <joey.gouly@arm.com>
>
> Want to point out that I didn't review this code, I only reviewed
> patches 1-3
> from the original series.
Ah crap. I try to make sure I was only tagging the right patches,
but obviously failed... :-( Really sorry about that.
> https://lore.kernel.org/linux-arm-kernel/20230907100931.1186690-1-maz@kernel.org/
>
> Since it seems Oliver is picking it up, can you remove my r-b tag from
> this patch.
Well, Zenghui has found a couple of issues, so there will be a third
revision for sure. I'll amend the patch right away.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-21 11:13 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 18:17 [PATCH v2 00/11] KVM: arm64: Accelerate lookup of vcpus by MPIDR values (and other fixes) Marc Zyngier
2023-09-20 18:17 ` Marc Zyngier
2023-09-20 18:17 ` [PATCH v2 01/11] KVM: arm64: vgic: Make kvm_vgic_inject_irq() take a vcpu pointer Marc Zyngier
2023-09-20 18:17 ` Marc Zyngier
2023-09-21 9:11 ` Zenghui Yu
2023-09-21 9:11 ` Zenghui Yu
2023-09-21 11:20 ` Marc Zyngier
2023-09-21 11:20 ` Marc Zyngier
2023-09-20 18:17 ` [PATCH v2 02/11] KVM: arm64: vgic-its: Treat the collection target address as a vcpu_id Marc Zyngier
2023-09-20 18:17 ` Marc Zyngier
2023-09-21 9:14 ` Zenghui Yu
2023-09-21 9:14 ` Zenghui Yu
2023-09-21 11:46 ` Marc Zyngier
2023-09-21 11:46 ` Marc Zyngier
2023-09-21 13:12 ` Zenghui Yu
2023-09-21 13:12 ` Zenghui Yu
2023-09-20 18:17 ` [PATCH v2 03/11] KVM: arm64: vgic-v3: Refactor GICv3 SGI generation Marc Zyngier
2023-09-20 18:17 ` Marc Zyngier
2023-09-21 9:42 ` Joey Gouly
2023-09-21 9:42 ` Joey Gouly
2023-09-21 11:13 ` Marc Zyngier [this message]
2023-09-21 11:13 ` Marc Zyngier
2023-09-20 18:17 ` [PATCH v2 04/11] KVM: arm64: vgic-v2: Use cpuid from userspace as vcpu_id Marc Zyngier
2023-09-20 18:17 ` Marc Zyngier
2023-09-20 18:17 ` [PATCH v2 05/11] KVM: arm64: vgic: Use vcpu_idx for the debug information Marc Zyngier
2023-09-20 18:17 ` Marc Zyngier
2023-09-20 18:17 ` [PATCH v2 06/11] KVM: arm64: Use vcpu_idx for invalidation tracking Marc Zyngier
2023-09-20 18:17 ` Marc Zyngier
2023-09-21 9:16 ` Zenghui Yu
2023-09-21 9:16 ` Zenghui Yu
2023-09-21 12:58 ` Marc Zyngier
2023-09-21 12:58 ` Marc Zyngier
2023-09-20 18:17 ` [PATCH v2 07/11] KVM: arm64: Simplify kvm_vcpu_get_mpidr_aff() Marc Zyngier
2023-09-20 18:17 ` Marc Zyngier
2023-09-20 18:17 ` [PATCH v2 08/11] KVM: arm64: Build MPIDR to vcpu index cache at runtime Marc Zyngier
2023-09-20 18:17 ` Marc Zyngier
2023-09-20 18:17 ` [PATCH v2 09/11] KVM: arm64: Fast-track kvm_mpidr_to_vcpu() when mpidr_data is available Marc Zyngier
2023-09-20 18:17 ` Marc Zyngier
2023-09-20 18:17 ` [PATCH v2 10/11] KVM: arm64: vgic-v3: Optimize affinity-based SGI injection Marc Zyngier
2023-09-20 18:17 ` Marc Zyngier
2023-09-21 9:32 ` Zenghui Yu
2023-09-21 9:32 ` Zenghui Yu
2023-09-20 18:17 ` [PATCH v2 11/11] KVM: arm64: Clarify the ordering requirements for vcpu/RD creation Marc Zyngier
2023-09-20 18:17 ` Marc Zyngier
2023-09-21 2:11 ` [PATCH v2 00/11] KVM: arm64: Accelerate lookup of vcpus by MPIDR values (and other fixes) Oliver Upton
2023-09-21 2:11 ` Oliver Upton
2023-09-21 9:39 ` Zenghui Yu
2023-09-21 9:39 ` Zenghui Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d905e62015f27949c3c08c7579e489ca@kernel.org \
--to=maz@kernel.org \
--cc=eric.auger@redhat.com \
--cc=james.morse@arm.com \
--cc=joey.gouly@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=oliver.upton@linux.dev \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
--cc=zhaoxu.35@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.