All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fan Wu <wufan@linux.microsoft.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: corbet@lwn.net, zohar@linux.ibm.com, jmorris@namei.org,
	serge@hallyn.com, tytso@mit.edu, axboe@kernel.dk, agk@redhat.com,
	snitzer@kernel.org, eparis@redhat.com, paul@paul-moore.com,
	linux-doc@vger.kernel.org, linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-fscrypt@vger.kernel.org, linux-block@vger.kernel.org,
	dm-devel@redhat.com, audit@vger.kernel.org,
	roberto.sassu@huawei.com, linux-kernel@vger.kernel.org,
	Deven Bowers <deven.desai@linux.microsoft.com>
Subject: Re: [RFC PATCH v11 15/19] fsverity: consume builtin signature via LSM hook
Date: Wed, 4 Oct 2023 19:49:13 -0700	[thread overview]
Message-ID: <d95c06e5-60e7-4adb-896f-5c99e7f4db52@linux.microsoft.com> (raw)
In-Reply-To: <20231005022707.GA1688@quark.localdomain>



On 10/4/2023 7:27 PM, Eric Biggers wrote:
> On Wed, Oct 04, 2023 at 03:09:42PM -0700, Fan Wu wrote:
>> +#ifdef CONFIG_FS_VERITY_BUILTIN_SIGNATURES
>> +static int fsverity_inode_setsecurity(struct inode *inode,
>> +				      struct fsverity_descriptor *desc)
>> +{
>> +	return security_inode_setsecurity(inode, FS_VERITY_INODE_SEC_NAME,
>> +					  desc->signature,
>> +					  le32_to_cpu(desc->sig_size), 0);
>> +}
> 
> Why isn't the type of the second argument 'const struct fsverity_descriptor *'?
> 
> - Eric

Thanks for the suggestion. I agree that adding 'const' here is a better 
approach. I will update this in the next version.

-Fan

WARNING: multiple messages have this Message-ID (diff)
From: Fan Wu <wufan@linux.microsoft.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: axboe@kernel.dk, tytso@mit.edu, paul@paul-moore.com,
	dm-devel@redhat.com, corbet@lwn.net, roberto.sassu@huawei.com,
	Deven Bowers <deven.desai@linux.microsoft.com>,
	linux-doc@vger.kernel.org, snitzer@kernel.org, jmorris@namei.org,
	zohar@linux.ibm.com, linux-kernel@vger.kernel.org,
	linux-block@vger.kernel.org, audit@vger.kernel.org,
	linux-security-module@vger.kernel.org, eparis@redhat.com,
	linux-fscrypt@vger.kernel.org, linux-integrity@vger.kernel.org,
	agk@redhat.com, serge@hallyn.com
Subject: Re: [dm-devel] [RFC PATCH v11 15/19] fsverity: consume builtin signature via LSM hook
Date: Wed, 4 Oct 2023 19:49:13 -0700	[thread overview]
Message-ID: <d95c06e5-60e7-4adb-896f-5c99e7f4db52@linux.microsoft.com> (raw)
In-Reply-To: <20231005022707.GA1688@quark.localdomain>



On 10/4/2023 7:27 PM, Eric Biggers wrote:
> On Wed, Oct 04, 2023 at 03:09:42PM -0700, Fan Wu wrote:
>> +#ifdef CONFIG_FS_VERITY_BUILTIN_SIGNATURES
>> +static int fsverity_inode_setsecurity(struct inode *inode,
>> +				      struct fsverity_descriptor *desc)
>> +{
>> +	return security_inode_setsecurity(inode, FS_VERITY_INODE_SEC_NAME,
>> +					  desc->signature,
>> +					  le32_to_cpu(desc->sig_size), 0);
>> +}
> 
> Why isn't the type of the second argument 'const struct fsverity_descriptor *'?
> 
> - Eric

Thanks for the suggestion. I agree that adding 'const' here is a better 
approach. I will update this in the next version.

-Fan

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2023-10-05 15:58 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-04 22:09 [RFC PATCH v11 00/19] Integrity Policy Enforcement LSM (IPE) Fan Wu
2023-10-04 22:09 ` [dm-devel] " Fan Wu
2023-10-04 22:09 ` [RFC PATCH v11 01/19] security: add ipe lsm Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-04 22:09 ` [RFC PATCH v11 02/19] ipe: add policy parser Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-24  3:52   ` [PATCH RFC v11 2/19] " Paul Moore
2023-10-24  3:52     ` Paul Moore
2023-10-25 22:45     ` Fan Wu
2023-10-25 22:45       ` Fan Wu
2023-10-26 21:36       ` Paul Moore
2023-10-26 21:36         ` Paul Moore
2023-10-04 22:09 ` [RFC PATCH v11 03/19] ipe: add evaluation loop Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-24  3:52   ` [PATCH RFC v11 3/19] " Paul Moore
2023-10-24  3:52     ` Paul Moore
2023-10-26  0:15     ` Fan Wu
2023-10-26  0:15       ` Fan Wu
2023-10-04 22:09 ` [RFC PATCH v11 04/19] ipe: add LSM hooks on execution and kernel read Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-05  8:24   ` kernel test robot
2023-10-24  3:52   ` [PATCH RFC v11 4/19] " Paul Moore
2023-10-24  3:52     ` Paul Moore
2023-10-04 22:09 ` [RFC PATCH v11 05/19] ipe: introduce 'boot_verified' as a trust provider Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-24  3:52   ` [PATCH RFC v11 5/19] " Paul Moore
2023-10-24  3:52     ` Paul Moore
2023-10-26 21:33     ` Fan Wu
2023-10-26 21:33       ` Fan Wu
2023-10-26 22:12       ` Paul Moore
2023-10-26 22:12         ` Paul Moore
2023-11-02 22:46         ` Fan Wu
2023-11-03 22:15           ` Paul Moore
2023-11-03 22:30             ` Paul Moore
2023-10-04 22:09 ` [RFC PATCH v11 06/19] security: add new securityfs delete function Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-04 22:09 ` [RFC PATCH v11 07/19] ipe: add userspace interface Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-05 10:32   ` kernel test robot
2023-10-24  3:52   ` [PATCH RFC v11 7/19] " Paul Moore
2023-10-04 22:09 ` [RFC PATCH v11 08/19] uapi|audit|ipe: add ipe auditing support Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-05 13:00   ` kernel test robot
2023-10-24  3:52   ` [PATCH RFC v11 8/19] " Paul Moore
2023-10-24  3:52     ` Paul Moore
2023-11-02 22:55     ` Fan Wu
2023-10-04 22:09 ` [RFC PATCH v11 09/19] ipe: add permissive toggle Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-24  3:52   ` [PATCH RFC v11 9/19] " Paul Moore
2023-10-24  3:52     ` Paul Moore
2023-11-02 22:56     ` Fan Wu
2023-10-04 22:09 ` [RFC PATCH v11 10/19] block|security: add LSM blob to block_device Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-04 22:09 ` [RFC PATCH v11 11/19] dm verity: set DM_TARGET_SINGLETON feature flag Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-24  3:52   ` [PATCH RFC " Paul Moore
2023-10-24  3:52     ` Paul Moore
2023-11-02  0:40     ` Paul Moore
2023-10-04 22:09 ` [RFC PATCH v11 12/19] dm: add finalize hook to target_type Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-24  3:52   ` [PATCH RFC " Paul Moore
2023-10-24  3:52     ` Paul Moore
2023-11-02  0:41     ` Paul Moore
2023-10-04 22:09 ` [RFC PATCH v11 13/19] dm verity: consume root hash digest and signature data via LSM hook Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-24  3:52   ` [PATCH RFC " Paul Moore
2023-10-24  3:52     ` Paul Moore
2023-11-02  0:41     ` Paul Moore
2023-10-04 22:09 ` [RFC PATCH v11 14/19] ipe: add support for dm-verity as a trust provider Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-24  3:52   ` [PATCH RFC " Paul Moore
2023-10-24  3:52     ` Paul Moore
2023-11-02 22:40     ` Fan Wu
2023-10-04 22:09 ` [RFC PATCH v11 15/19] fsverity: consume builtin signature via LSM hook Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-05  2:27   ` Eric Biggers
2023-10-05  2:27     ` [dm-devel] " Eric Biggers
2023-10-05  2:49     ` Fan Wu [this message]
2023-10-05  2:49       ` Fan Wu
2023-10-24  3:52   ` [PATCH RFC " Paul Moore
2023-10-24  3:52     ` Paul Moore
2023-11-02  0:40     ` Paul Moore
2023-11-02  2:53       ` Eric Biggers
2023-11-02 15:42         ` Paul Moore
2023-11-02 19:33           ` Fan Wu
2023-10-04 22:09 ` [RFC PATCH v11 16/19] ipe: enable support for fs-verity as a trust provider Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-04 23:58   ` Randy Dunlap
2023-10-04 23:58     ` [dm-devel] " Randy Dunlap
2023-10-05  2:45     ` Fan Wu
2023-10-05  2:45       ` [dm-devel] " Fan Wu
2023-10-24  3:52   ` [PATCH RFC " Paul Moore
2023-10-24  3:52     ` Paul Moore
2023-10-04 22:09 ` [RFC PATCH v11 17/19] scripts: add boot policy generation program Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-24  3:52   ` [PATCH RFC " Paul Moore
2023-10-24  3:52     ` Paul Moore
2023-11-02 23:09     ` Fan Wu
2023-10-04 22:09 ` [RFC PATCH v11 18/19] ipe: kunit test for parser Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu
2023-10-24  3:52   ` [PATCH RFC " Paul Moore
2023-10-24  3:52     ` Paul Moore
2023-11-02 23:11     ` Fan Wu
2023-10-04 22:09 ` [RFC PATCH v11 19/19] documentation: add ipe documentation Fan Wu
2023-10-04 22:09   ` [dm-devel] " Fan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d95c06e5-60e7-4adb-896f-5c99e7f4db52@linux.microsoft.com \
    --to=wufan@linux.microsoft.com \
    --cc=agk@redhat.com \
    --cc=audit@vger.kernel.org \
    --cc=axboe@kernel.dk \
    --cc=corbet@lwn.net \
    --cc=deven.desai@linux.microsoft.com \
    --cc=dm-devel@redhat.com \
    --cc=ebiggers@kernel.org \
    --cc=eparis@redhat.com \
    --cc=jmorris@namei.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=roberto.sassu@huawei.com \
    --cc=serge@hallyn.com \
    --cc=snitzer@kernel.org \
    --cc=tytso@mit.edu \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.