* RFC: Sane default for SPLASH
@ 2010-01-13 23:31 Rolf Leggewie
2010-01-13 23:37 ` Richard Purdie
2010-01-13 23:47 ` Phil Blundell
0 siblings, 2 replies; 12+ messages in thread
From: Rolf Leggewie @ 2010-01-13 23:31 UTC (permalink / raw)
To: openembedded-devel
Hello,
the variable SPLASH is currently defined and not defined in a variety of
places leading to undesired results. I think it should be set OE-wide
to a sane default. Sane for me would be either "" to not have a splash
at all or psplash or some other generic splash that shows an OE logo.
As always, this would be set ?= so that distributions and individuals
can override the setting. I think the sane default is no splash but
invite your opinion on the matter.
Regards
Rolf
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: RFC: Sane default for SPLASH
2010-01-13 23:31 RFC: Sane default for SPLASH Rolf Leggewie
@ 2010-01-13 23:37 ` Richard Purdie
2010-01-13 23:47 ` Phil Blundell
1 sibling, 0 replies; 12+ messages in thread
From: Richard Purdie @ 2010-01-13 23:37 UTC (permalink / raw)
To: openembedded-devel
On Thu, 2010-01-14 at 00:31 +0100, Rolf Leggewie wrote:
> the variable SPLASH is currently defined and not defined in a variety of
> places leading to undesired results. I think it should be set OE-wide
> to a sane default. Sane for me would be either "" to not have a splash
> at all or psplash or some other generic splash that shows an OE logo.
> As always, this would be set ?= so that distributions and individuals
> can override the setting. I think the sane default is no splash but
> invite your opinion on the matter.
So a key question is "Where is it actually used?"
I'm asking this in public rather than just looking myself and providing
an answer so people can see the reasoning ;-).
Cheers,
Richard
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: RFC: Sane default for SPLASH
2010-01-13 23:31 RFC: Sane default for SPLASH Rolf Leggewie
2010-01-13 23:37 ` Richard Purdie
@ 2010-01-13 23:47 ` Phil Blundell
2010-01-13 23:58 ` Richard Purdie
1 sibling, 1 reply; 12+ messages in thread
From: Phil Blundell @ 2010-01-13 23:47 UTC (permalink / raw)
To: openembedded-devel
On Thu, 2010-01-14 at 00:31 +0100, Rolf Leggewie wrote:
> the variable SPLASH is currently defined and not defined in a variety of
> places leading to undesired results. I think it should be set OE-wide
> to a sane default.
Is this variable really so important that it needs to be part of the
global configuration? Which packages actually care about its value?
If the default is to be no splash, which I agree seems like the only
sensible plan, can't we just arrange for a completely unset ${SPLASH} to
have the semantics of "no splash"?
Although the cost of adding new things to bitbake.conf is not very high,
it isn't zero either. Every variable that's defined there is included
in the metadata for every single package, which has a small cost in
terms of memory usage and bitbake run time. Also, every line in this
file has a cost in terms of visual clutter and general intelligibility.
Also, if a new variable is to be added to bitbake.conf, I would prefer
it to have a slightly less generic (and maybe more explanatory) name
than ${SPLASH}; the shorter and less qualified the name is, the greater
the chance that it will accidentally conflict with something else.
p.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: RFC: Sane default for SPLASH
2010-01-13 23:47 ` Phil Blundell
@ 2010-01-13 23:58 ` Richard Purdie
2010-01-14 0:38 ` Rolf Leggewie
0 siblings, 1 reply; 12+ messages in thread
From: Richard Purdie @ 2010-01-13 23:58 UTC (permalink / raw)
To: openembedded-devel
On Wed, 2010-01-13 at 23:47 +0000, Phil Blundell wrote:
> On Thu, 2010-01-14 at 00:31 +0100, Rolf Leggewie wrote:
> > the variable SPLASH is currently defined and not defined in a variety of
> > places leading to undesired results. I think it should be set OE-wide
> > to a sane default.
>
> Is this variable really so important that it needs to be part of the
> global configuration? Which packages actually care about its value?
So the answer is likely that images or task .bb files use this thing.
The logical approach would therefore be a weak default variable in
image.bbclass or a package-groups.bbclass included by task-*.bb files...
Cheers,
Richard
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: RFC: Sane default for SPLASH
2010-01-13 23:58 ` Richard Purdie
@ 2010-01-14 0:38 ` Rolf Leggewie
2010-01-14 9:14 ` Koen Kooi
0 siblings, 1 reply; 12+ messages in thread
From: Rolf Leggewie @ 2010-01-14 0:38 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
Richard Purdie wrote:
> So the answer is likely that images or task .bb files use this thing.
> The logical approach would therefore be a weak default variable in
> image.bbclass or a package-groups.bbclass included by task-*.bb files...
yes, very good point indeed. This does not have to be OE-wide, setting
it in image.bbclass is enough and much preferred.
Based on the suggestions I can now come up with a first draft of a patch
for discussion. Further work would need to be done after this patch or
one like it has been applied. There are currently a number of images
that hardwire the bootsplash. For some, that is probably in their
nature and desired, for others it's not so clear. Just to give an
example of the latter, I think that the BOOTSPLASH definition in
gpe-image.bb should be moved into the distro configuration instead.
[-- Attachment #2: bootsplash.patch --]
[-- Type: text/x-patch, Size: 14117 bytes --]
diff --git a/classes/image.bbclass b/classes/image.bbclass
index ab58031..8f45aeb 100644
--- a/classes/image.bbclass
+++ b/classes/image.bbclass
@@ -17,6 +17,9 @@ IMAGE_INITSCRIPTS ?= "initscripts"
#
IMAGE_LOGIN_MANAGER ?= "tinylogin"
+# set sane default for the BOOTSPLASH variable
+BOOTSPLASH ?= ""
+
IMAGE_KEEPROOTFS ?= ""
IMAGE_KEEPROOTFS[doc] = "Set to non-empty to keep ${IMAGE_ROOTFS} around after image creation."
diff --git a/recipes/images/beagleboard-demo-image.bb b/recipes/images/beagleboard-demo-image.bb
index d83281c..a410263 100644
--- a/recipes/images/beagleboard-demo-image.bb
+++ b/recipes/images/beagleboard-demo-image.bb
@@ -10,7 +10,7 @@ XSERVER ?= "xserver-xorg \
"
ANGSTROM_EXTRA_INSTALL ?= ""
-SPLASH = "exquisite exquisite-themes exquisite-theme-angstrom"
+BOOTSPLASH = "exquisite exquisite-themes exquisite-theme-angstrom"
export IMAGE_BASENAME = "Beagleboard-demo-image"
@@ -19,7 +19,7 @@ IMAGE_INSTALL = "\
${XSERVER} \
${ANGSTROM_EXTRA_INSTALL} \
task-beagleboard-demo \
- ${SPLASH} \
+ ${BOOTSPLASH} \
"
IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
diff --git a/recipes/images/bootmanager-image.bb b/recipes/images/bootmanager-image.bb
index db05437..21d11a1 100644
--- a/recipes/images/bootmanager-image.bb
+++ b/recipes/images/bootmanager-image.bb
@@ -1,9 +1,9 @@
#Angstrom bootmanager image
-SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
+BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
DEPENDS = "task-angstrom"
-IMAGE_INSTALL = "angstrom-base-depends angstrom-bootmanager ${SPLASH}"
+IMAGE_INSTALL = "angstrom-base-depends angstrom-bootmanager ${BOOTSPLASH}"
export IMAGE_BASENAME = "bootmanager-image"
diff --git a/recipes/images/console-base-image.bb b/recipes/images/console-base-image.bb
index d25a4fc..0b196b6 100644
--- a/recipes/images/console-base-image.bb
+++ b/recipes/images/console-base-image.bb
@@ -4,17 +4,16 @@ IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
ANGSTROM_EXTRA_INSTALL ?= ""
-SPLASH ?= ""
ZZAPSPLASH = ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-zap", "",d)}'
DEPENDS = "task-base \
- ${SPLASH} \
+ ${BOOTSPLASH} \
${ZZAPSPLASH} \
"
IMAGE_INSTALL = "task-base \
${ANGSTROM_EXTRA_INSTALL} \
- ${SPLASH} \
+ ${BOOTSPLASH} \
${ZZAPSPLASH} \
"
diff --git a/recipes/images/gateway-image.bb b/recipes/images/gateway-image.bb
index d7a77e0..061b6b0 100644
--- a/recipes/images/gateway-image.bb
+++ b/recipes/images/gateway-image.bb
@@ -1,7 +1,7 @@
#Angstrom gateway image
#gives you a gateway with SMB, ssh and dnsmasqs
-SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
+BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
ANGSTROM_EXTRA_INSTALL ?= ""
DISTRO_SSH_DAEMON ?= "dropbear"
@@ -13,7 +13,7 @@ IMAGE_INSTALL = "task-boot \
dnsmasq \
# vsftpd \
angstrom-version \
- ${SPLASH} \
+ ${BOOTSPLASH} \
"
export IMAGE_BASENAME = "gateway-image"
diff --git a/recipes/images/gnuradio-image.bb b/recipes/images/gnuradio-image.bb
index 53e79b8..0c9bfe2 100644
--- a/recipes/images/gnuradio-image.bb
+++ b/recipes/images/gnuradio-image.bb
@@ -4,17 +4,16 @@ IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
IMAGE_EXTRA_INSTALL ?= ""
-SPLASH ?= ""
ZZAPSPLASH = ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-zap", "",d)}'
DEPENDS = "task-base-extended \
- ${SPLASH} \
+ ${BOOTSPLASH} \
${ZZAPSPLASH} \
"
IMAGE_INSTALL = "task-base-extended \
${IMAGE_EXTRA_INSTALL} \
- ${SPLASH} \
+ ${BOOTSPLASH} \
${ZZAPSPLASH} \
oprofile \
screen \
diff --git a/recipes/images/gpe-image.bb b/recipes/images/gpe-image.bb
index 768cc6b..df4a802 100644
--- a/recipes/images/gpe-image.bb
+++ b/recipes/images/gpe-image.bb
@@ -8,7 +8,7 @@ XSERVER ?= "xserver-kdrive-fbdev"
GPE_EXTRA_THEMES = "gpe-theme-industrial"
# Select bootsplash
-SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
+BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
# Select some useful things depending on the device capabilities
@@ -29,7 +29,7 @@ GPE_EXTRA_INSTALL += "${GPE_BIGFLASH_INSTALL}"
DEPENDS = "${MACHINE_TASK_PROVIDER} \
- ${SPLASH} \
+ ${BOOTSPLASH} \
task-gpe-base \
task-gpe-apps \
task-gpe-pim \
@@ -44,7 +44,7 @@ IMAGE_INSTALL = "\
task-gpe-settings \
task-gpe-apps \
${XSERVER} \
- ${SPLASH} \
+ ${BOOTSPLASH} \
${GPE_EXTRA_INSTALL}"
ROOTFS_POSTPROCESS_COMMAND += '${@base_conditional("DISTRO_TYPE", "release", "zap_root_password; ", "",d)}'
diff --git a/recipes/images/illume-image.bb b/recipes/images/illume-image.bb
index 3ab006a..ca219f2 100644
--- a/recipes/images/illume-image.bb
+++ b/recipes/images/illume-image.bb
@@ -5,7 +5,7 @@
IMAGE_LINGUAS = "en-us de-de fr-fr pt-br ca-es zh-cn zh-tw bg-bg cs-cz da-dk nl-nl fi-fi hu-hu it-it ja-jp ko-kr nb-no pl-pl ru-ru sk-sk sl-si es-ar sv-se"
# use exquisite splash
-SPLASH = "exquisite exquisite-themes exquisite-theme-illume"
+BOOTSPLASH = "exquisite exquisite-themes exquisite-theme-illume"
# getting the base system up
BASE_INSTALL = "\
@@ -154,7 +154,7 @@ IMAGE_INSTALL = "\
# ${ZHONE_INSTALL} \
${APPS_INSTALL} \
${DEV_INSTALL} \
- ${SPLASH} \
+ ${BOOTSPLASH} \
"
inherit image
diff --git a/recipes/images/minimal-gpe-image.bb b/recipes/images/minimal-gpe-image.bb
index c37225d..de6a625 100644
--- a/recipes/images/minimal-gpe-image.bb
+++ b/recipes/images/minimal-gpe-image.bb
@@ -3,7 +3,7 @@
# Very angstrom and opkg centric
XSERVER ?= "xserver-kdrive-fbdev"
-SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
+BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
export IMAGE_BASENAME = "minimalist-gpe-image"
@@ -18,7 +18,7 @@ IMAGE_INSTALL = "\
gpe-terminal \
angstrom-feed-configs \
opkg-nogpg opkg-collateral \
- ${SPLASH} \
+ ${BOOTSPLASH} \
"
#zap root password for release images
diff --git a/recipes/images/minimal-image.bb b/recipes/images/minimal-image.bb
index e9abcb3..3d5d3aa 100644
--- a/recipes/images/minimal-image.bb
+++ b/recipes/images/minimal-image.bb
@@ -4,8 +4,6 @@
ANGSTROM_EXTRA_INSTALL ?= ""
DISTRO_SSH_DAEMON ?= "dropbear"
-SPLASH ?= " "
-
IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
IMAGE_INSTALL = "task-boot \
@@ -13,7 +11,7 @@ IMAGE_INSTALL = "task-boot \
${DISTRO_SSH_DAEMON} \
${ANGSTROM_EXTRA_INSTALL} \
angstrom-version \
- ${SPLASH} \
+ ${BOOTSPLASH} \
"
export IMAGE_BASENAME = "minimalist-image"
diff --git a/recipes/images/sdr-image.bb b/recipes/images/sdr-image.bb
index 55a59a2..7c52553 100644
--- a/recipes/images/sdr-image.bb
+++ b/recipes/images/sdr-image.bb
@@ -15,7 +15,7 @@ IMAGE_FSTYPES += "tar.bz2"
ANGSTROM_EXTRA_INSTALL ?= ""
DISTRO_SSH_DAEMON ?= "dropbear"
XSERVER ?= "xserver-kdrive-fbdev"
-SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
+BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
# Install "big" X if the target has a screen
GUIPACKAGES_BIGX = " \
@@ -44,7 +44,7 @@ IMAGE_INSTALL = " task-base-extended \
uucp picocom \
angstrom-zeroconf-audio avahi-utils \
${ANGSTROM_EXTRA_INSTALL} \
- ${SPLASH} \
+ ${BOOTSPLASH} \
"
inherit image
diff --git a/recipes/images/sugar-image.bb b/recipes/images/sugar-image.bb
index e4513f6..01218ad 100644
--- a/recipes/images/sugar-image.bb
+++ b/recipes/images/sugar-image.bb
@@ -1,5 +1,5 @@
XSERVER ?= "xserver-kdrive-fbdev"
-SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
+BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
ANGSTROM_EXTRA_INSTALL += ""
export IMAGE_BASENAME = "sugar-image"
@@ -12,7 +12,7 @@ IMAGE_INSTALL = "\
angstrom-gpe-task-base \
angstrom-gpe-task-settings \
task-sugar-sucrose \
- ${SPLASH} \
+ ${BOOTSPLASH} \
${ANGSTROM_EXTRA_INSTALL}"
IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
diff --git a/recipes/images/ti-demo-x11-image.bb b/recipes/images/ti-demo-x11-image.bb
index e37d183..2ed9150 100644
--- a/recipes/images/ti-demo-x11-image.bb
+++ b/recipes/images/ti-demo-x11-image.bb
@@ -10,7 +10,7 @@ XSERVER ?= "xserver-xorg \
"
ANGSTROM_EXTRA_INSTALL ?= ""
-SPLASH = "exquisite exquisite-themes exquisite-theme-angstrom"
+BOOTSPLASH = "exquisite exquisite-themes exquisite-theme-angstrom"
export IMAGE_BASENAME = "ti-demo-x11-image"
@@ -19,7 +19,7 @@ IMAGE_INSTALL = "\
${XSERVER} \
${ANGSTROM_EXTRA_INSTALL} \
task-demo-x11 \
- ${SPLASH} \
+ ${BOOTSPLASH} \
"
IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
diff --git a/recipes/images/udumpty-image.bb b/recipes/images/udumpty-image.bb
index 8f616d9..3cda81f 100644
--- a/recipes/images/udumpty-image.bb
+++ b/recipes/images/udumpty-image.bb
@@ -1,6 +1,6 @@
# Image that mimics the default desktop of a certain distro
-SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
+BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
XSERVER ?= "xserver-xorg \
xf86-input-evdev \
xf86-input-mouse \
@@ -44,7 +44,7 @@ IMAGE_INSTALL = "\
gnome-control-center \
gnome-settings-daemon \
gnome-session \
- ${SPLASH} \
+ ${BOOTSPLASH} \
"
IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
diff --git a/recipes/images/x11-gpe-image.bb b/recipes/images/x11-gpe-image.bb
index 837d94a..c3fc947 100644
--- a/recipes/images/x11-gpe-image.bb
+++ b/recipes/images/x11-gpe-image.bb
@@ -3,7 +3,7 @@
ANGSTROM_EXTRA_INSTALL += " \
"
XSERVER ?= "xserver-kdrive-fbdev"
-SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
+BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
export IMAGE_BASENAME = "x11-gpe-image"
@@ -17,7 +17,7 @@ IMAGE_INSTALL = "\
kernel-modules \
hal \
angstrom-gpe-task-pim \
- ${SPLASH} \
+ ${BOOTSPLASH} \
${ANGSTROM_EXTRA_INSTALL}"
diff --git a/recipes/images/x11-gpe-java-image.bb b/recipes/images/x11-gpe-java-image.bb
index 760fe52..e4b7998 100644
--- a/recipes/images/x11-gpe-java-image.bb
+++ b/recipes/images/x11-gpe-java-image.bb
@@ -3,7 +3,7 @@
ANGSTROM_EXTRA_INSTALL += " \
"
XSERVER ?= "xserver-kdrive-fbdev"
-SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
+BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
export IMAGE_BASENAME = "x11-gpe-java-image"
@@ -19,7 +19,7 @@ IMAGE_INSTALL = "\
kernel-modules \
hal \
angstrom-gpe-task-pim \
- ${SPLASH} \
+ ${BOOTSPLASH} \
${ANGSTROM_EXTRA_INSTALL}"
IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
diff --git a/recipes/images/x11-image.bb b/recipes/images/x11-image.bb
index 7c632e3..552a8ab 100644
--- a/recipes/images/x11-image.bb
+++ b/recipes/images/x11-image.bb
@@ -12,7 +12,7 @@ IMAGE_INSTALL = "\
angstrom-x11-base-depends \
angstrom-gpe-task-base \
angstrom-gpe-task-settings \
- ${SPLASH} \
+ ${BOOTSPLASH} \
${ANGSTROM_EXTRA_INSTALL}"
IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
diff --git a/recipes/images/x11-jvm-image.bb b/recipes/images/x11-jvm-image.bb
index fd0e5f0..63c0652 100644
--- a/recipes/images/x11-jvm-image.bb
+++ b/recipes/images/x11-jvm-image.bb
@@ -28,7 +28,7 @@ IMAGE_INSTALL = "\
angstrom-x11-base-depends \
angstrom-gpe-task-base \
angstrom-gpe-task-settings \
- ${SPLASH} \
+ ${BOOTSPLASH} \
${ADD_JVM} \
${ADD_OTHER} \
${ANGSTROM_EXTRA_INSTALL}"
diff --git a/recipes/images/x11-office-image.bb b/recipes/images/x11-office-image.bb
index ecbc8a0..6d0d306 100644
--- a/recipes/images/x11-office-image.bb
+++ b/recipes/images/x11-office-image.bb
@@ -3,7 +3,7 @@
ANGSTROM_EXTRA_INSTALL += " \
"
XSERVER ?= "xserver-kdrive-fbdev"
-SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
+BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
export IMAGE_BASENAME = "x11-office-image"
@@ -22,7 +22,7 @@ IMAGE_INSTALL = "\
claws-mail claws-mail claws-plugin-mailmbox claws-plugin-rssyl \
midori minimo \
gphoto2 \
- ${SPLASH} \
+ ${BOOTSPLASH} \
${ANGSTROM_EXTRA_INSTALL}"
IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
diff --git a/recipes/images/x11-pimlico-image.bb b/recipes/images/x11-pimlico-image.bb
index cb8e78d..32ec989 100644
--- a/recipes/images/x11-pimlico-image.bb
+++ b/recipes/images/x11-pimlico-image.bb
@@ -3,7 +3,7 @@
ANGSTROM_EXTRA_INSTALL += " \
"
XSERVER ?= "xserver-kdrive-fbdev"
-SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
+BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
export IMAGE_BASENAME = "x11-pimlico-image"
@@ -17,7 +17,7 @@ IMAGE_INSTALL = "\
kernel-modules \
hal \
angstrom-ohand-task-pim \
- ${SPLASH} \
+ ${BOOTSPLASH} \
${ANGSTROM_EXTRA_INSTALL}"
IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: RFC: Sane default for SPLASH
2010-01-14 0:38 ` Rolf Leggewie
@ 2010-01-14 9:14 ` Koen Kooi
2010-01-14 13:48 ` Rolf Leggewie
2010-01-14 13:52 ` Michael 'Mickey' Lauer
0 siblings, 2 replies; 12+ messages in thread
From: Koen Kooi @ 2010-01-14 9:14 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
NAK, the needless SPLASH -> BOOTSPLASH will create too much work for
people to catch up to, and it messes up the docs on the subject.
On 14-01-10 01:38, Rolf Leggewie wrote:
> diff --git a/classes/image.bbclass b/classes/image.bbclass
> index ab58031..8f45aeb 100644
> --- a/classes/image.bbclass
> +++ b/classes/image.bbclass
> @@ -17,6 +17,9 @@ IMAGE_INITSCRIPTS ?= "initscripts"
> #
> IMAGE_LOGIN_MANAGER ?= "tinylogin"
>
> +# set sane default for the BOOTSPLASH variable
> +BOOTSPLASH ?= ""
> +
> IMAGE_KEEPROOTFS ?= ""
> IMAGE_KEEPROOTFS[doc] = "Set to non-empty to keep ${IMAGE_ROOTFS} around after image creation."
>
> diff --git a/recipes/images/beagleboard-demo-image.bb b/recipes/images/beagleboard-demo-image.bb
> index d83281c..a410263 100644
> --- a/recipes/images/beagleboard-demo-image.bb
> +++ b/recipes/images/beagleboard-demo-image.bb
> @@ -10,7 +10,7 @@ XSERVER ?= "xserver-xorg \
> "
>
> ANGSTROM_EXTRA_INSTALL ?= ""
> -SPLASH = "exquisite exquisite-themes exquisite-theme-angstrom"
> +BOOTSPLASH = "exquisite exquisite-themes exquisite-theme-angstrom"
>
> export IMAGE_BASENAME = "Beagleboard-demo-image"
>
> @@ -19,7 +19,7 @@ IMAGE_INSTALL = "\
> ${XSERVER} \
> ${ANGSTROM_EXTRA_INSTALL} \
> task-beagleboard-demo \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> "
>
> IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
> diff --git a/recipes/images/bootmanager-image.bb b/recipes/images/bootmanager-image.bb
> index db05437..21d11a1 100644
> --- a/recipes/images/bootmanager-image.bb
> +++ b/recipes/images/bootmanager-image.bb
> @@ -1,9 +1,9 @@
> #Angstrom bootmanager image
>
> -SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
> +BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
>
> DEPENDS = "task-angstrom"
> -IMAGE_INSTALL = "angstrom-base-depends angstrom-bootmanager ${SPLASH}"
> +IMAGE_INSTALL = "angstrom-base-depends angstrom-bootmanager ${BOOTSPLASH}"
>
> export IMAGE_BASENAME = "bootmanager-image"
>
> diff --git a/recipes/images/console-base-image.bb b/recipes/images/console-base-image.bb
> index d25a4fc..0b196b6 100644
> --- a/recipes/images/console-base-image.bb
> +++ b/recipes/images/console-base-image.bb
> @@ -4,17 +4,16 @@ IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
>
> ANGSTROM_EXTRA_INSTALL ?= ""
>
> -SPLASH ?= ""
> ZZAPSPLASH = ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-zap", "",d)}'
>
> DEPENDS = "task-base \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> ${ZZAPSPLASH} \
> "
>
> IMAGE_INSTALL = "task-base \
> ${ANGSTROM_EXTRA_INSTALL} \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> ${ZZAPSPLASH} \
> "
>
> diff --git a/recipes/images/gateway-image.bb b/recipes/images/gateway-image.bb
> index d7a77e0..061b6b0 100644
> --- a/recipes/images/gateway-image.bb
> +++ b/recipes/images/gateway-image.bb
> @@ -1,7 +1,7 @@
> #Angstrom gateway image
> #gives you a gateway with SMB, ssh and dnsmasqs
>
> -SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
> +BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
>
> ANGSTROM_EXTRA_INSTALL ?= ""
> DISTRO_SSH_DAEMON ?= "dropbear"
> @@ -13,7 +13,7 @@ IMAGE_INSTALL = "task-boot \
> dnsmasq \
> # vsftpd \
> angstrom-version \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> "
>
> export IMAGE_BASENAME = "gateway-image"
> diff --git a/recipes/images/gnuradio-image.bb b/recipes/images/gnuradio-image.bb
> index 53e79b8..0c9bfe2 100644
> --- a/recipes/images/gnuradio-image.bb
> +++ b/recipes/images/gnuradio-image.bb
> @@ -4,17 +4,16 @@ IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
>
> IMAGE_EXTRA_INSTALL ?= ""
>
> -SPLASH ?= ""
> ZZAPSPLASH = ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-zap", "",d)}'
>
> DEPENDS = "task-base-extended \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> ${ZZAPSPLASH} \
> "
>
> IMAGE_INSTALL = "task-base-extended \
> ${IMAGE_EXTRA_INSTALL} \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> ${ZZAPSPLASH} \
> oprofile \
> screen \
> diff --git a/recipes/images/gpe-image.bb b/recipes/images/gpe-image.bb
> index 768cc6b..df4a802 100644
> --- a/recipes/images/gpe-image.bb
> +++ b/recipes/images/gpe-image.bb
> @@ -8,7 +8,7 @@ XSERVER ?= "xserver-kdrive-fbdev"
> GPE_EXTRA_THEMES = "gpe-theme-industrial"
>
> # Select bootsplash
> -SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
> +BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
>
> # Select some useful things depending on the device capabilities
>
> @@ -29,7 +29,7 @@ GPE_EXTRA_INSTALL += "${GPE_BIGFLASH_INSTALL}"
>
>
> DEPENDS = "${MACHINE_TASK_PROVIDER} \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> task-gpe-base \
> task-gpe-apps \
> task-gpe-pim \
> @@ -44,7 +44,7 @@ IMAGE_INSTALL = "\
> task-gpe-settings \
> task-gpe-apps \
> ${XSERVER} \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> ${GPE_EXTRA_INSTALL}"
>
> ROOTFS_POSTPROCESS_COMMAND += '${@base_conditional("DISTRO_TYPE", "release", "zap_root_password; ", "",d)}'
> diff --git a/recipes/images/illume-image.bb b/recipes/images/illume-image.bb
> index 3ab006a..ca219f2 100644
> --- a/recipes/images/illume-image.bb
> +++ b/recipes/images/illume-image.bb
> @@ -5,7 +5,7 @@
> IMAGE_LINGUAS = "en-us de-de fr-fr pt-br ca-es zh-cn zh-tw bg-bg cs-cz da-dk nl-nl fi-fi hu-hu it-it ja-jp ko-kr nb-no pl-pl ru-ru sk-sk sl-si es-ar sv-se"
>
> # use exquisite splash
> -SPLASH = "exquisite exquisite-themes exquisite-theme-illume"
> +BOOTSPLASH = "exquisite exquisite-themes exquisite-theme-illume"
>
> # getting the base system up
> BASE_INSTALL = "\
> @@ -154,7 +154,7 @@ IMAGE_INSTALL = "\
> # ${ZHONE_INSTALL} \
> ${APPS_INSTALL} \
> ${DEV_INSTALL} \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> "
> inherit image
>
> diff --git a/recipes/images/minimal-gpe-image.bb b/recipes/images/minimal-gpe-image.bb
> index c37225d..de6a625 100644
> --- a/recipes/images/minimal-gpe-image.bb
> +++ b/recipes/images/minimal-gpe-image.bb
> @@ -3,7 +3,7 @@
> # Very angstrom and opkg centric
>
> XSERVER ?= "xserver-kdrive-fbdev"
> -SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
> +BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
>
> export IMAGE_BASENAME = "minimalist-gpe-image"
>
> @@ -18,7 +18,7 @@ IMAGE_INSTALL = "\
> gpe-terminal \
> angstrom-feed-configs \
> opkg-nogpg opkg-collateral \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> "
>
> #zap root password for release images
> diff --git a/recipes/images/minimal-image.bb b/recipes/images/minimal-image.bb
> index e9abcb3..3d5d3aa 100644
> --- a/recipes/images/minimal-image.bb
> +++ b/recipes/images/minimal-image.bb
> @@ -4,8 +4,6 @@
> ANGSTROM_EXTRA_INSTALL ?= ""
> DISTRO_SSH_DAEMON ?= "dropbear"
>
> -SPLASH ?= " "
> -
> IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
>
> IMAGE_INSTALL = "task-boot \
> @@ -13,7 +11,7 @@ IMAGE_INSTALL = "task-boot \
> ${DISTRO_SSH_DAEMON} \
> ${ANGSTROM_EXTRA_INSTALL} \
> angstrom-version \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> "
>
> export IMAGE_BASENAME = "minimalist-image"
> diff --git a/recipes/images/sdr-image.bb b/recipes/images/sdr-image.bb
> index 55a59a2..7c52553 100644
> --- a/recipes/images/sdr-image.bb
> +++ b/recipes/images/sdr-image.bb
> @@ -15,7 +15,7 @@ IMAGE_FSTYPES += "tar.bz2"
> ANGSTROM_EXTRA_INSTALL ?= ""
> DISTRO_SSH_DAEMON ?= "dropbear"
> XSERVER ?= "xserver-kdrive-fbdev"
> -SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
> +BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
>
> # Install "big" X if the target has a screen
> GUIPACKAGES_BIGX = " \
> @@ -44,7 +44,7 @@ IMAGE_INSTALL = " task-base-extended \
> uucp picocom \
> angstrom-zeroconf-audio avahi-utils \
> ${ANGSTROM_EXTRA_INSTALL} \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> "
>
> inherit image
> diff --git a/recipes/images/sugar-image.bb b/recipes/images/sugar-image.bb
> index e4513f6..01218ad 100644
> --- a/recipes/images/sugar-image.bb
> +++ b/recipes/images/sugar-image.bb
> @@ -1,5 +1,5 @@
> XSERVER ?= "xserver-kdrive-fbdev"
> -SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
> +BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
> ANGSTROM_EXTRA_INSTALL += ""
>
> export IMAGE_BASENAME = "sugar-image"
> @@ -12,7 +12,7 @@ IMAGE_INSTALL = "\
> angstrom-gpe-task-base \
> angstrom-gpe-task-settings \
> task-sugar-sucrose \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> ${ANGSTROM_EXTRA_INSTALL}"
>
> IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
> diff --git a/recipes/images/ti-demo-x11-image.bb b/recipes/images/ti-demo-x11-image.bb
> index e37d183..2ed9150 100644
> --- a/recipes/images/ti-demo-x11-image.bb
> +++ b/recipes/images/ti-demo-x11-image.bb
> @@ -10,7 +10,7 @@ XSERVER ?= "xserver-xorg \
> "
>
> ANGSTROM_EXTRA_INSTALL ?= ""
> -SPLASH = "exquisite exquisite-themes exquisite-theme-angstrom"
> +BOOTSPLASH = "exquisite exquisite-themes exquisite-theme-angstrom"
>
> export IMAGE_BASENAME = "ti-demo-x11-image"
>
> @@ -19,7 +19,7 @@ IMAGE_INSTALL = "\
> ${XSERVER} \
> ${ANGSTROM_EXTRA_INSTALL} \
> task-demo-x11 \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> "
>
> IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
> diff --git a/recipes/images/udumpty-image.bb b/recipes/images/udumpty-image.bb
> index 8f616d9..3cda81f 100644
> --- a/recipes/images/udumpty-image.bb
> +++ b/recipes/images/udumpty-image.bb
> @@ -1,6 +1,6 @@
> # Image that mimics the default desktop of a certain distro
>
> -SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
> +BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
> XSERVER ?= "xserver-xorg \
> xf86-input-evdev \
> xf86-input-mouse \
> @@ -44,7 +44,7 @@ IMAGE_INSTALL = "\
> gnome-control-center \
> gnome-settings-daemon \
> gnome-session \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> "
>
> IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
> diff --git a/recipes/images/x11-gpe-image.bb b/recipes/images/x11-gpe-image.bb
> index 837d94a..c3fc947 100644
> --- a/recipes/images/x11-gpe-image.bb
> +++ b/recipes/images/x11-gpe-image.bb
> @@ -3,7 +3,7 @@
> ANGSTROM_EXTRA_INSTALL += " \
> "
> XSERVER ?= "xserver-kdrive-fbdev"
> -SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
> +BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
>
> export IMAGE_BASENAME = "x11-gpe-image"
>
> @@ -17,7 +17,7 @@ IMAGE_INSTALL = "\
> kernel-modules \
> hal \
> angstrom-gpe-task-pim \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> ${ANGSTROM_EXTRA_INSTALL}"
>
>
> diff --git a/recipes/images/x11-gpe-java-image.bb b/recipes/images/x11-gpe-java-image.bb
> index 760fe52..e4b7998 100644
> --- a/recipes/images/x11-gpe-java-image.bb
> +++ b/recipes/images/x11-gpe-java-image.bb
> @@ -3,7 +3,7 @@
> ANGSTROM_EXTRA_INSTALL += " \
> "
> XSERVER ?= "xserver-kdrive-fbdev"
> -SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
> +BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
>
> export IMAGE_BASENAME = "x11-gpe-java-image"
>
> @@ -19,7 +19,7 @@ IMAGE_INSTALL = "\
> kernel-modules \
> hal \
> angstrom-gpe-task-pim \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> ${ANGSTROM_EXTRA_INSTALL}"
>
> IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
> diff --git a/recipes/images/x11-image.bb b/recipes/images/x11-image.bb
> index 7c632e3..552a8ab 100644
> --- a/recipes/images/x11-image.bb
> +++ b/recipes/images/x11-image.bb
> @@ -12,7 +12,7 @@ IMAGE_INSTALL = "\
> angstrom-x11-base-depends \
> angstrom-gpe-task-base \
> angstrom-gpe-task-settings \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> ${ANGSTROM_EXTRA_INSTALL}"
>
> IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
> diff --git a/recipes/images/x11-jvm-image.bb b/recipes/images/x11-jvm-image.bb
> index fd0e5f0..63c0652 100644
> --- a/recipes/images/x11-jvm-image.bb
> +++ b/recipes/images/x11-jvm-image.bb
> @@ -28,7 +28,7 @@ IMAGE_INSTALL = "\
> angstrom-x11-base-depends \
> angstrom-gpe-task-base \
> angstrom-gpe-task-settings \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> ${ADD_JVM} \
> ${ADD_OTHER} \
> ${ANGSTROM_EXTRA_INSTALL}"
> diff --git a/recipes/images/x11-office-image.bb b/recipes/images/x11-office-image.bb
> index ecbc8a0..6d0d306 100644
> --- a/recipes/images/x11-office-image.bb
> +++ b/recipes/images/x11-office-image.bb
> @@ -3,7 +3,7 @@
> ANGSTROM_EXTRA_INSTALL += " \
> "
> XSERVER ?= "xserver-kdrive-fbdev"
> -SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
> +BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
>
> export IMAGE_BASENAME = "x11-office-image"
>
> @@ -22,7 +22,7 @@ IMAGE_INSTALL = "\
> claws-mail claws-mail claws-plugin-mailmbox claws-plugin-rssyl \
> midori minimo \
> gphoto2 \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> ${ANGSTROM_EXTRA_INSTALL}"
>
> IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
> diff --git a/recipes/images/x11-pimlico-image.bb b/recipes/images/x11-pimlico-image.bb
> index cb8e78d..32ec989 100644
> --- a/recipes/images/x11-pimlico-image.bb
> +++ b/recipes/images/x11-pimlico-image.bb
> @@ -3,7 +3,7 @@
> ANGSTROM_EXTRA_INSTALL += " \
> "
> XSERVER ?= "xserver-kdrive-fbdev"
> -SPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
> +BOOTSPLASH ?= ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-angstrom", "",d)}'
>
> export IMAGE_BASENAME = "x11-pimlico-image"
>
> @@ -17,7 +17,7 @@ IMAGE_INSTALL = "\
> kernel-modules \
> hal \
> angstrom-ohand-task-pim \
> - ${SPLASH} \
> + ${BOOTSPLASH} \
> ${ANGSTROM_EXTRA_INSTALL}"
>
> IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFLTuBlMkyGM64RGpERAggfAJ4jsCjTf4LCqo57KrfzmCBmNxVT5ACeLeyn
qndQqKaZAyTOeRoig0+OoOc=
=yuDJ
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: RFC: Sane default for SPLASH
2010-01-14 9:14 ` Koen Kooi
@ 2010-01-14 13:48 ` Rolf Leggewie
2010-01-14 14:09 ` Koen Kooi
2010-01-14 15:18 ` Michael 'Mickey' Lauer
2010-01-14 13:52 ` Michael 'Mickey' Lauer
1 sibling, 2 replies; 12+ messages in thread
From: Rolf Leggewie @ 2010-01-14 13:48 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
Koen Kooi wrote:
> NAK, the needless SPLASH -> BOOTSPLASH will create too much work for
> people to catch up to, and it messes up the docs on the subject.
With respect to "needless", the reasons for the change were given in
this thread. Please revisit the discussion.
And in any case, the tremendous (LOL) amount of work can be
significantly reduced with the help of sed, as I'm sure you are aware.
With regard to docs:
$ rgrep SPLASH docs/
$
The wiki has nothing on it, either. Nothing but hot air?
This has become a non-core change, I don't feel bound by your NAK. That
being said, I know of your tendency of "my way or the highway" and have
prepared a new patch that omits the name change but is otherwise
identical. Since this addresses your "concerns" I await your ACK.
[-- Attachment #2: bootsplash.patch --]
[-- Type: text/x-patch, Size: 1691 bytes --]
diff --git a/classes/image.bbclass b/classes/image.bbclass
index ab58031..9dce609 100644
--- a/classes/image.bbclass
+++ b/classes/image.bbclass
@@ -17,6 +17,9 @@ IMAGE_INITSCRIPTS ?= "initscripts"
#
IMAGE_LOGIN_MANAGER ?= "tinylogin"
+# set sane default for the SPLASH variable
+SPLASH ?= ""
+
IMAGE_KEEPROOTFS ?= ""
IMAGE_KEEPROOTFS[doc] = "Set to non-empty to keep ${IMAGE_ROOTFS} around after image creation."
diff --git a/recipes/images/console-base-image.bb b/recipes/images/console-base-image.bb
index d25a4fc..9bd5031 100644
--- a/recipes/images/console-base-image.bb
+++ b/recipes/images/console-base-image.bb
@@ -4,7 +4,6 @@ IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
ANGSTROM_EXTRA_INSTALL ?= ""
-SPLASH ?= ""
ZZAPSPLASH = ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-zap", "",d)}'
DEPENDS = "task-base \
diff --git a/recipes/images/gnuradio-image.bb b/recipes/images/gnuradio-image.bb
index 53e79b8..6bccda0 100644
--- a/recipes/images/gnuradio-image.bb
+++ b/recipes/images/gnuradio-image.bb
@@ -4,7 +4,6 @@ IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
IMAGE_EXTRA_INSTALL ?= ""
-SPLASH ?= ""
ZZAPSPLASH = ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-zap", "",d)}'
DEPENDS = "task-base-extended \
diff --git a/recipes/images/minimal-image.bb b/recipes/images/minimal-image.bb
index e9abcb3..0bd8019 100644
--- a/recipes/images/minimal-image.bb
+++ b/recipes/images/minimal-image.bb
@@ -4,8 +4,6 @@
ANGSTROM_EXTRA_INSTALL ?= ""
DISTRO_SSH_DAEMON ?= "dropbear"
-SPLASH ?= " "
-
IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
IMAGE_INSTALL = "task-boot \
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: RFC: Sane default for SPLASH
2010-01-14 9:14 ` Koen Kooi
2010-01-14 13:48 ` Rolf Leggewie
@ 2010-01-14 13:52 ` Michael 'Mickey' Lauer
2010-01-14 14:12 ` Koen Kooi
1 sibling, 1 reply; 12+ messages in thread
From: Michael 'Mickey' Lauer @ 2010-01-14 13:52 UTC (permalink / raw)
To: openembedded-devel
Am Donnerstag, den 14.01.2010, 10:14 +0100 schrieb Koen Kooi:
> NAK, the needless SPLASH -> BOOTSPLASH will create too much work for
> people to catch up to, and it messes up the docs on the subject.
Could you expand on that reason? I find the patch quite a useful
refactoring. If we don't allow patches like this going in, we're
doomed into living with misnomers forever -- and we all know that
there are quite a few in OE metadata.
Cheers,
--
:M:
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: RFC: Sane default for SPLASH
2010-01-14 13:48 ` Rolf Leggewie
@ 2010-01-14 14:09 ` Koen Kooi
2010-01-14 15:18 ` Michael 'Mickey' Lauer
1 sibling, 0 replies; 12+ messages in thread
From: Koen Kooi @ 2010-01-14 14:09 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 14-01-10 14:48, Rolf Leggewie wrote:
> Koen Kooi wrote:
>> NAK, the needless SPLASH -> BOOTSPLASH will create too much work for
>> people to catch up to, and it messes up the docs on the subject.
>
> With respect to "needless", the reasons for the change were given in
> this thread. Please revisit the discussion.
Phil only said short names might clash, which I don't think 'SPLASH'
will ever do.
> And in any case, the tremendous (LOL) amount of work can be
> significantly reduced with the help of sed, as I'm sure you are aware.
You are assuming I have write access to everywhere and know about every
overlay in existence.
> With regard to docs:
>
> $ rgrep SPLASH docs/
> $
>
> The wiki has nothing on it, either. Nothing but hot air?
No, internal docs
> This has become a non-core change,
image.bbclass is considered 'core' or has that changed lately?
> I don't feel bound by your NAK.
If you don't feel bound by NAKs you shouldn't be sending patches for
review, one NAK is enough for it to get rejected.
> That
> being said, I know of your tendency of "my way or the highway" and have
> prepared a new patch that omits the name change but is otherwise
> identical. Since this addresses your "concerns" I await your ACK.
The patch below looks good to me:
Acked-by: Koen Kooi <koen@openembedded.org>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFLTyWjMkyGM64RGpERAiiiAJ4joUTu0ZqcGvukFTFSNsrmYk13OACgmhSj
BudTZxUtiG8ImtjfZ0HUOwA=
=Ix9Y
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: RFC: Sane default for SPLASH
2010-01-14 13:52 ` Michael 'Mickey' Lauer
@ 2010-01-14 14:12 ` Koen Kooi
2010-01-14 14:23 ` Philip Balister
0 siblings, 1 reply; 12+ messages in thread
From: Koen Kooi @ 2010-01-14 14:12 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 14-01-10 14:52, Michael 'Mickey' Lauer wrote:
> Am Donnerstag, den 14.01.2010, 10:14 +0100 schrieb Koen Kooi:
>> NAK, the needless SPLASH -> BOOTSPLASH will create too much work for
>> people to catch up to, and it messes up the docs on the subject.
>
> Could you expand on that reason? I find the patch quite a useful
> refactoring. If we don't allow patches like this going in, we're
> doomed into living with misnomers forever -- and we all know that
> there are quite a few in OE metadata.
If you want to fix such misnomers it needs to be done with more thought
and publicity to allow external repos to catch up. No need to stab
people in the eye to make 2 people feel better.
And FWIW, psplash runs at shutdown as well, so it isn't really a
bootsplash ;)
regards,
Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFLTyZIMkyGM64RGpERAqUXAKCsvCCu4AtWzl7ksBhuCzSKVhGaDgCfdKn6
GGBVwWvHLQGeyvYAe820rE0=
=K0dG
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: RFC: Sane default for SPLASH
2010-01-14 14:12 ` Koen Kooi
@ 2010-01-14 14:23 ` Philip Balister
0 siblings, 0 replies; 12+ messages in thread
From: Philip Balister @ 2010-01-14 14:23 UTC (permalink / raw)
To: openembedded-devel
On 01/14/2010 09:12 AM, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 14-01-10 14:52, Michael 'Mickey' Lauer wrote:
>> Am Donnerstag, den 14.01.2010, 10:14 +0100 schrieb Koen Kooi:
>>> NAK, the needless SPLASH -> BOOTSPLASH will create too much work for
>>> people to catch up to, and it messes up the docs on the subject.
>>
>> Could you expand on that reason? I find the patch quite a useful
>> refactoring. If we don't allow patches like this going in, we're
>> doomed into living with misnomers forever -- and we all know that
>> there are quite a few in OE metadata.
>
> If you want to fix such misnomers it needs to be done with more thought
> and publicity to allow external repos to catch up. No need to stab
> people in the eye to make 2 people feel better.
> And FWIW, psplash runs at shutdown as well, so it isn't really a
> bootsplash ;)
Trying to get this back on the issue at hand ....
It appears to me (who isn't really folloing the thread), there are two
issues, an immediate problem that Rolf's second patch addresses, and the
actual variable name issue, which appears worthy of further discussion
and thought.
It is always good to keep individual changes as simple as possible and
avoid mixing too many thoughts in one commit.
Philip
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: RFC: Sane default for SPLASH
2010-01-14 13:48 ` Rolf Leggewie
2010-01-14 14:09 ` Koen Kooi
@ 2010-01-14 15:18 ` Michael 'Mickey' Lauer
1 sibling, 0 replies; 12+ messages in thread
From: Michael 'Mickey' Lauer @ 2010-01-14 15:18 UTC (permalink / raw)
To: openembedded-devel
Acked-By: Michael 'Mickey' Lauer <mlauer@vanille-media.de>
--
:M:
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2010-01-14 15:19 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-13 23:31 RFC: Sane default for SPLASH Rolf Leggewie
2010-01-13 23:37 ` Richard Purdie
2010-01-13 23:47 ` Phil Blundell
2010-01-13 23:58 ` Richard Purdie
2010-01-14 0:38 ` Rolf Leggewie
2010-01-14 9:14 ` Koen Kooi
2010-01-14 13:48 ` Rolf Leggewie
2010-01-14 14:09 ` Koen Kooi
2010-01-14 15:18 ` Michael 'Mickey' Lauer
2010-01-14 13:52 ` Michael 'Mickey' Lauer
2010-01-14 14:12 ` Koen Kooi
2010-01-14 14:23 ` Philip Balister
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.