All of lore.kernel.org
 help / color / mirror / Atom feed
From: khalasa@piap.pl (Krzysztof Hałasa)
To: Tim Harvey <tharvey@gateworks.com>
Cc: "Lucas Stach" <l.stach@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Petr Štetiar" <ynezz@true.cz>,
	"Richard Zhu" <Richard.Zhu@freescale.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity
Date: Mon, 04 Apr 2016 12:37:07 +0200	[thread overview]
Message-ID: <m337r1irsc.fsf@t19.piap.pl> (raw)
In-Reply-To: <CAJ+vNU0iKSXrKmA6jzdw5R5K3TnR3qftVn-8Ou5chHdz5aTpTA@mail.gmail.com> (Tim Harvey's message of "Thu, 31 Mar 2016 09:19:31 -0700")

Tim,

> So perhaps there is something else going on with the tw8689
> device/driver that is causing it to not work with MSI. We have an
> avc8000 miniPCIe with tw8689 here and can test if you send me your
> patches that enable tw8689 with msi.

I think you can use this:
http://git.linuxtv.org/hverkuil/media_tree.git/log/?h=tw686x

> Regardless of MSI working in our tests we still disable it because of
> it breaking legacy irqs and for performance reasons.

So do I. However I'm also using Fedora 23 and this means I have to
recompile the kernel, since they build it with MSI enabled.
I think we should fix it, either by disabling in run time, or making it
work.

Performance-wise, I found it "surprising" that one can't have multiple
MSIs with separate hw vector for each.
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

WARNING: multiple messages have this Message-ID (diff)
From: khalasa@piap.pl (Krzysztof Hałasa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity
Date: Mon, 04 Apr 2016 12:37:07 +0200	[thread overview]
Message-ID: <m337r1irsc.fsf@t19.piap.pl> (raw)
In-Reply-To: <CAJ+vNU0iKSXrKmA6jzdw5R5K3TnR3qftVn-8Ou5chHdz5aTpTA@mail.gmail.com> (Tim Harvey's message of "Thu, 31 Mar 2016 09:19:31 -0700")

Tim,

> So perhaps there is something else going on with the tw8689
> device/driver that is causing it to not work with MSI. We have an
> avc8000 miniPCIe with tw8689 here and can test if you send me your
> patches that enable tw8689 with msi.

I think you can use this:
http://git.linuxtv.org/hverkuil/media_tree.git/log/?h=tw686x

> Regardless of MSI working in our tests we still disable it because of
> it breaking legacy irqs and for performance reasons.

So do I. However I'm also using Fedora 23 and this means I have to
recompile the kernel, since they build it with MSI enabled.
I think we should fix it, either by disabling in run time, or making it
work.

Performance-wise, I found it "surprising" that one can't have multiple
MSIs with separate hw vector for each.
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

  reply	other threads:[~2016-04-04 10:37 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-25 13:32 [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Krzysztof Hałasa
2016-03-25 13:32 ` Krzysztof Hałasa
2016-03-27 14:44 ` Fabio Estevam
2016-03-27 14:44   ` Fabio Estevam
2016-03-28  0:26   ` Fabio Estevam
2016-03-28  0:26     ` Fabio Estevam
2016-03-28 19:59     ` Tim Harvey
2016-03-28 19:59       ` Tim Harvey
2016-03-28 20:13       ` Fabio Estevam
2016-03-28 20:13         ` Fabio Estevam
2016-03-28 20:42         ` Tim Harvey
2016-03-28 20:42           ` Tim Harvey
2016-03-28 21:30           ` Fabio Estevam
2016-03-28 21:30             ` Fabio Estevam
2016-03-28 22:06             ` Tim Harvey
2016-03-28 22:06               ` Tim Harvey
2016-03-28 22:13               ` Fabio Estevam
2016-03-28 22:13                 ` Fabio Estevam
2016-03-29  5:40                 ` Krzysztof Hałasa
2016-03-29  5:40                   ` Krzysztof Hałasa
2016-03-29  5:43                   ` Krzysztof Hałasa
2016-03-29  5:43                     ` Krzysztof Hałasa
2016-03-29  5:29               ` Krzysztof Hałasa
2016-03-29  5:29                 ` Krzysztof Hałasa
2016-03-29  8:55               ` Lucas Stach
2016-03-29  8:55                 ` Lucas Stach
2016-03-29 10:39                 ` Krzysztof Hałasa
2016-03-29 10:39                   ` Krzysztof Hałasa
2016-03-29 10:55                   ` Lucas Stach
2016-03-29 10:55                     ` Lucas Stach
2016-03-29 13:12                     ` Arnd Bergmann
2016-03-29 13:12                       ` Arnd Bergmann
2016-03-29 13:32                     ` Tim Harvey
2016-03-29 13:32                       ` Tim Harvey
2016-03-29 13:52                       ` Arnd Bergmann
2016-03-29 13:52                         ` Arnd Bergmann
2016-03-29 14:29                         ` Tim Harvey
2016-03-29 14:29                           ` Tim Harvey
2016-03-29 14:50                           ` Arnd Bergmann
2016-03-29 14:50                             ` Arnd Bergmann
2016-03-29 15:10                             ` Tim Harvey
2016-03-29 15:10                               ` Tim Harvey
2016-03-29 15:24                               ` Arnd Bergmann
2016-03-29 15:24                                 ` Arnd Bergmann
2016-03-29 17:38                                 ` Tim Harvey
2016-03-29 17:38                                   ` Tim Harvey
2016-03-29 19:39                                   ` Arnd Bergmann
2016-03-29 19:39                                     ` Arnd Bergmann
2016-03-29 17:56                                 ` Marc Zyngier
2016-03-29 17:56                                   ` Marc Zyngier
2016-03-29 16:13                               ` Roberto Fichera
2016-03-29 16:13                                 ` Roberto Fichera
2016-03-29 16:40                                 ` Tim Harvey
2016-03-29 16:40                                   ` Tim Harvey
2016-03-29 16:44                                   ` Roberto Fichera
2016-03-29 16:44                                     ` Roberto Fichera
2016-03-29 17:31                                     ` Tim Harvey
2016-03-29 17:31                                       ` Tim Harvey
2016-03-30  8:00                                       ` Roberto Fichera
2016-03-30  8:00                                         ` Roberto Fichera
2016-03-30 10:10                                         ` Arnd Bergmann
2016-03-30 10:10                                           ` Arnd Bergmann
2016-03-30 12:50                                           ` Roberto Fichera
2016-03-30 12:50                                             ` Roberto Fichera
2016-03-30 13:38                                             ` Tim Harvey
2016-03-30 13:38                                               ` Tim Harvey
2016-03-30 15:20                                               ` Roberto Fichera
2016-03-30 15:20                                                 ` Roberto Fichera
2016-03-30  8:10                     ` Krzysztof Hałasa
2016-03-30  8:10                       ` Krzysztof Hałasa
2016-03-31 16:19                       ` Tim Harvey
2016-03-31 16:19                         ` Tim Harvey
2016-04-04 10:37                         ` Krzysztof Hałasa [this message]
2016-04-04 10:37                           ` Krzysztof Hałasa
2016-03-29 14:14                 ` Fabio Estevam
2016-03-29 14:14                   ` Fabio Estevam
2016-03-29  5:21           ` Krzysztof Hałasa
2016-03-29  5:21             ` Krzysztof Hałasa
2016-03-30 12:06 ` Petr Štetiar
2016-03-30 12:06   ` Petr Štetiar
2016-03-30 12:45   ` Fabio Estevam
2016-03-30 12:45     ` Fabio Estevam
2016-03-30 14:38   ` Marcel Ziswiler
2016-03-30 14:38     ` Marcel Ziswiler
2016-03-30 14:38     ` Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m337r1irsc.fsf@t19.piap.pl \
    --to=khalasa@piap.pl \
    --cc=Richard.Zhu@freescale.com \
    --cc=bhelgaas@google.com \
    --cc=festevam@gmail.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=tharvey@gateworks.com \
    --cc=ynezz@true.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.