All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Paul Jackson <pj@sgi.com>
Cc: akpm@osdl.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: Clean up of __alloc_pages
Date: 05 Nov 2005 18:09:14 +0100	[thread overview]
Message-ID: <p73oe4z2f9h.fsf@verdi.suse.de> (raw)
In-Reply-To: <20051029171630.04a69660.pj@sgi.com>

Paul Jackson <pj@sgi.com> writes:


Regarding cpumemset and alloc_pages. I recently rechecked
the cpumemset hooks in there and I must say they turned out
to be quite worse

In hindsight it would have been better to use the "generate
zonelists for all possible nodes" approach you originally had
and which I rejected (sorry) 

That would make the code much cleaner and faster.
Maybe it's not too late to switch for that?

If not then the fast path definitely needs to be tuned a bit.

-Andi


WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: Paul Jackson <pj@sgi.com>
Cc: akpm@osdl.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: Clean up of __alloc_pages
Date: 05 Nov 2005 18:09:14 +0100	[thread overview]
Message-ID: <p73oe4z2f9h.fsf@verdi.suse.de> (raw)
In-Reply-To: <20051029171630.04a69660.pj@sgi.com>

Paul Jackson <pj@sgi.com> writes:


Regarding cpumemset and alloc_pages. I recently rechecked
the cpumemset hooks in there and I must say they turned out
to be quite worse

In hindsight it would have been better to use the "generate
zonelists for all possible nodes" approach you originally had
and which I rejected (sorry) 

That would make the code much cleaner and faster.
Maybe it's not too late to switch for that?

If not then the fast path definitely needs to be tuned a bit.

-Andi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2005-11-05 17:09 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-29  1:33 [PATCH]: Clean up of __alloc_pages Rohit, Seth
2005-10-29  1:33 ` Rohit, Seth
2005-10-29  2:33 ` Nick Piggin
2005-10-29  2:33   ` Nick Piggin
2005-10-31 20:55   ` Rohit Seth
2005-10-31 20:55     ` Rohit Seth
2005-11-01  1:14     ` Nick Piggin
2005-11-01  1:14       ` Nick Piggin
2005-11-04 18:15       ` Rohit Seth
2005-11-04 18:15         ` Rohit Seth
2005-11-05  0:00         ` Nick Piggin
2005-11-05  0:00           ` Nick Piggin
2005-10-30  0:16 ` Paul Jackson
2005-10-30  0:16   ` Paul Jackson
2005-10-31 19:09   ` Rohit Seth
2005-10-31 19:09     ` Rohit Seth
2005-11-05 17:09   ` Andi Kleen [this message]
2005-11-05 17:09     ` Andi Kleen
2005-11-06  4:18     ` Paul Jackson
2005-11-06  4:18       ` Paul Jackson
2005-11-06 17:35       ` Andi Kleen
2005-11-06 17:35         ` Andi Kleen
2005-11-06 20:49         ` Paul Jackson
2005-11-06 20:49           ` Paul Jackson
2005-11-07  2:57           ` Nick Piggin
2005-11-07  2:57             ` Nick Piggin
2005-11-07  3:42             ` Andi Kleen
2005-11-07  3:42               ` Andi Kleen
2005-11-07  4:37               ` Paul Jackson
2005-11-07  4:37                 ` Paul Jackson
2005-11-07  6:08                 ` Nick Piggin
2005-11-07  6:08                   ` Nick Piggin
2005-11-07  9:46                   ` Paul Jackson
2005-11-07  9:46                     ` Paul Jackson
2005-11-07 10:17                     ` Nick Piggin
2005-11-07 10:17                       ` Nick Piggin
2005-11-07 14:41                       ` Paul Jackson
2005-11-07 14:41                         ` Paul Jackson
2005-11-07  3:44             ` Paul Jackson
2005-11-07  3:44               ` Paul Jackson
2005-10-30  1:47 ` Paul Jackson
2005-10-30  1:47   ` Paul Jackson
2005-10-30  2:01   ` Nick Piggin
2005-10-30  2:01     ` Nick Piggin
2005-10-30  2:19     ` Paul Jackson
2005-10-30  2:19       ` Paul Jackson
2005-10-30  2:32       ` Nick Piggin
2005-10-30  2:32         ` Nick Piggin
2005-10-30  3:06         ` Paul Jackson
2005-10-30  3:06           ` Paul Jackson
2005-10-30  3:53           ` Nick Piggin
2005-10-30  3:53             ` Nick Piggin
2005-10-30  2:26     ` Paul Jackson
2005-10-30  2:26       ` Paul Jackson
2005-10-30  2:36       ` Nick Piggin
2005-10-30  2:36         ` Nick Piggin
2005-10-30  3:09         ` Paul Jackson
2005-10-30  3:09           ` Paul Jackson
2005-10-30  3:55           ` Nick Piggin
2005-10-30  3:55             ` Nick Piggin
2005-10-30  4:11             ` Paul Jackson
2005-10-30  4:11               ` Paul Jackson
2005-10-31 21:20   ` Rohit Seth
2005-10-31 21:20     ` Rohit Seth
2005-10-31 21:28     ` Paul Jackson
2005-10-31 21:28       ` Paul Jackson
  -- strict thread matches above, loose matches on Subject: below --
2005-11-05  1:57 Seth, Rohit
2005-11-05  1:57 ` Seth, Rohit
2005-10-01 19:00 Seth, Rohit
2005-10-01 19:00 ` Seth, Rohit
2005-10-02  3:09 ` Nick Piggin
2005-10-02  3:09   ` Nick Piggin
2005-10-03 16:50   ` Rohit Seth
2005-10-03 16:50     ` Rohit Seth
2005-10-03 15:34 ` Christoph Lameter
2005-10-03 15:34   ` Christoph Lameter
2005-10-03 16:55   ` Rohit Seth
2005-10-03 16:55     ` Rohit Seth
2005-10-03 16:57     ` Christoph Lameter
2005-10-03 16:57       ` Christoph Lameter
2005-10-03 17:48       ` Rohit Seth
2005-10-03 17:48         ` Rohit Seth
2005-10-04 13:27         ` Andi Kleen
2005-10-04 13:27           ` Andi Kleen
2005-10-04 16:26           ` Ray Bryant
2005-10-04 16:26             ` Ray Bryant
2005-10-04 16:10             ` Martin J. Bligh
2005-10-04 16:10               ` Martin J. Bligh
2005-10-04 17:02               ` Ray Bryant
2005-10-04 17:02                 ` Ray Bryant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p73oe4z2f9h.fsf@verdi.suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pj@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.