Re: [PATCH 16/27] ext4: enable full feature coverage in fs/ext4/.kunitconfig

[sashiko-bot@kernel.org]

> Enable CONFIG_EXT4_FS_POSIX_ACL, CONFIG_EXT4_FS_SECURITY,
> CONFIG_FS_VERITY, CONFIG_FS_ENCRYPTION, CONFIG_QUOTA, CONFIG_QFMT_V2,
> and CONFIG_UNICODE in fs/ext4/.kunitconfig so conditional ext4 source
> files and feature-gated code paths (POSIX ACLs, security xattrs,
> fs-verity, fscrypt, quota accounting, and UTF-8 casefolding) are
> compiled and exercised during KUnit runs.
> 
> Fix mock superblock and test setup bugs in existing KUnit suites exposed
> by enabling these Kconfig options:
> 
> - Provide .get_dquots callbacks in mock super_operations under
>   CONFIG_QUOTA in block_validity-test.c, extents-test.c,
>   fast_commit-test.c, inline-test.c, inode-test.c, mballoc-test.c,
>   namei-test.c, and xattr-test.c so dquot_drop() does not dereference a
>   NULL callback during ext4_clear_inode().
> - Populate sb->s_cop = &ext4_cryptops under CONFIG_FS_ENCRYPTION in
>   balloc-test.c, extents-test.c, fast_commit-test.c, inline-test.c,
>   inode-test.c, mballoc-test.c, and xattr-test.c so
>   fscrypt_put_encryption_info() can resolve inode_info_offs safely on
>   eviction.
> - Fix test_namei_casefold_lookup_and_strict() under CONFIG_UNICODE in
>   namei-test.c to use SB_ENC_STRICT_MODE_FL (instead of undeclared
>   SB_STRICT_ENCODING) and propagate EXT4_INODE_CASEFOLD to S_CASEFOLD on
>   the VFS directory inode via ext4_set_inode_flags().
> 
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112040638.1576836-1-tytso@mit.edu?part=16