Re: [PATCH 17/27] ext4: add KUnit tests for fs/ext4/super.c

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] ext4: duplicate test symbol exports in super.c and mballoc.c
  break modpost
--

commit bd8448103700f2d8698fe8da1a5ea9c5b818c8f5
Author: Theodore Ts'o <tytso@mit.edu>

ext4: add KUnit tests for fs/ext4/super.c

This commit adds a KUnit test suite (ext4_super_test) for superblock
validation, geometry checks, metadata checksums, mount options, overhead
and statfs accounting, and error recording in fs/ext4/super.c, along with
test helper wrappers and symbol exports.

> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 88bd28cedd999..838dabda35c5d 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c

[ ... ]

> @@ -379,6 +381,7 @@ __u32 ext4_free_group_clusters(struct super_block *sb,
>  		(EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT ?
>  		 (__u32)le16_to_cpu(bg->bg_free_blocks_count_hi) << 16 : 0);
>  }
> +EXPORT_SYMBOL_FOR_EXT4_TEST(ext4_free_group_clusters);
>  
>  __u32 ext4_free_inodes_count(struct super_block *sb,
>  			      struct ext4_group_desc *bg)
> @@ -441,6 +444,7 @@ void ext4_free_group_clusters_set(struct super_block *sb,
>  	if (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT)
>  		bg->bg_free_blocks_count_hi = cpu_to_le16(count >> 16);
>  }
> +EXPORT_SYMBOL_FOR_EXT4_TEST(ext4_free_group_clusters_set);
>  
>  void ext4_free_inodes_set(struct super_block *sb,
>  			  struct ext4_group_desc *bg, __u32 count)

[Severity: High]
Does exporting ext4_free_group_clusters and ext4_free_group_clusters_set
here duplicate the existing exports in fs/ext4/mballoc.c?

fs/ext4/mballoc.c:
    ...
    EXPORT_SYMBOL_FOR_EXT4_TEST(ext4_free_group_clusters);
    EXPORT_SYMBOL_FOR_EXT4_TEST(ext4_free_group_clusters_set);
    ...

Because super.o and mballoc.o are linked into the same module or vmlinux,
builds with CONFIG_MODULES=y and CONFIG_EXT4_KUNIT_TESTS enabled fail in
modpost with "symbol ... exported twice".

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112040638.1576836-1-tytso@mit.edu?part=17