From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "Olaya, Margarita" <magi.olaya@ti.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: dapm: Add speaker driver widget.
Date: Mon, 06 Dec 2010 22:55:32 +0000 [thread overview]
Message-ID: <1291676132.3281.116.camel@odin> (raw)
In-Reply-To: <20101206224359.GB2862@opensource.wolfsonmicro.com>
On Mon, 2010-12-06 at 22:43 +0000, Mark Brown wrote:
> On Mon, Dec 06, 2010 at 04:34:37PM -0600, Olaya, Margarita wrote:
>
> > In some cases it was not possible to follow the appropiate power
> > ON/OFF sequence.
> > Add a widget to support speaker drivers where power ON/OFF
> > ordering is important.
>
> Why not use the existing speaker widget? It's at pretty much the same
> point in the sequence and is intended for use with external GPIO
> controlled speaker drivers. It'd be good to discuss this in the
> changelog.
>
In this case the driver block is on the CODEC IC and after the PGA in
the audio output path, hence this version is better suited than the
external GPIO version.
> > +#define SND_SOC_DAPM_DRV(wname, wreg, wshift, winvert,\
> > + wcontrols, wncontrols) \
> > +{ .id = snd_soc_dapm_drv, .name = wname, .reg = wreg, .shift = wshift, \
> > + .invert = winvert, .kcontrols = wcontrols, .num_kcontrols = wncontrols}
>
> The _DRV name seems rather opaque - I'd suggest _SPK as a name but
> obviously that's in use. If we do want this I guess _SPK_DRV or
> sommething.
I was thinking this too, but then I thought we may want to drive other
loads than just speakers here. e.g. haptic, vibra
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-12-06 22:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 22:34 [PATCH] ASoC: dapm: Add speaker driver widget Olaya, Margarita
2010-12-06 22:43 ` Mark Brown
2010-12-06 22:55 ` Liam Girdwood [this message]
2010-12-06 23:09 ` Mark Brown
2010-12-06 23:30 ` Liam Girdwood
2010-12-06 23:38 ` Mark Brown
2010-12-07 12:34 ` Liam Girdwood
2010-12-07 12:36 ` Mark Brown
2010-12-07 12:46 ` Liam Girdwood
2010-12-07 13:09 ` Mark Brown
2010-12-07 14:01 ` Liam Girdwood
2010-12-07 14:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291676132.3281.116.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=magi.olaya@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox