Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "Olaya, Margarita" <magi.olaya@ti.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: dapm: Add speaker driver widget.
Date: Mon, 06 Dec 2010 23:30:07 +0000	[thread overview]
Message-ID: <1291678207.3281.152.camel@odin> (raw)
In-Reply-To: <20101206230948.GH2862@opensource.wolfsonmicro.com>

On Mon, 2010-12-06 at 23:09 +0000, Mark Brown wrote:
> On Mon, Dec 06, 2010 at 10:55:32PM +0000, Liam Girdwood wrote:
> > On Mon, 2010-12-06 at 22:43 +0000, Mark Brown wrote:
> 
> > > Why not use the existing speaker widget?  It's at pretty much the same
> > > point in the sequence and is intended for use with external GPIO
> > > controlled speaker drivers.  It'd be good to discuss this in the
> > > changelog.
> 
> > In this case the driver block is on the CODEC IC and after the PGA in
> > the audio output path, hence this version is better suited than the
> > external GPIO version.
> 
> Sure, but it's fulfiling the same role in the system - it's just that
> these days a lot more CODECs are pulling speaker drivers directly into
> the CODEC die.  Mostly these have worked well handled as PGAs so it's
> not been an issue.
> 

In this case as we need to enable the PGA before the driver and disable
the driver before the PGA for pop reduction. Hence the current ordering
needs an addition/refactoring to deal with the newer generation of
CODECs here.

> I'd certainly expect to see it handled the same way from a DAPM
> sequencing point of view as it's fulfilling the same role in the system
> (so in the same slot rather than separately as the patch was doing).  Do
> we just need to refactor the existing external widgets to be able to
> exist in either register or GPIO based versions?
> 
> > > > +#define SND_SOC_DAPM_DRV(wname, wreg, wshift, winvert,\
> > > > +	 wcontrols, wncontrols) \
> > > > +{	.id = snd_soc_dapm_drv, .name = wname, .reg = wreg, .shift = wshift, \
> > > > +	.invert = winvert, .kcontrols = wcontrols, .num_kcontrols = wncontrols}
> 
> > > The _DRV name seems rather opaque - I'd suggest _SPK as a name but
> > > obviously that's in use.  If we do want this I guess _SPK_DRV or
> > > sommething.
> 
> > I was thinking this too, but then I thought we may want to drive other
> > loads than just speakers here. e.g. haptic, vibra
> 
> My main thing here is _DRV - it's not just that it's undescriptive, it's
> also that calling something a driver in a context like this is confusing.
> _OUT_DRV is another idea?  

Ok, lets go for OUT_DRV.

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

  reply	other threads:[~2010-12-06 23:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-06 22:34 [PATCH] ASoC: dapm: Add speaker driver widget Olaya, Margarita
2010-12-06 22:43 ` Mark Brown
2010-12-06 22:55   ` Liam Girdwood
2010-12-06 23:09     ` Mark Brown
2010-12-06 23:30       ` Liam Girdwood [this message]
2010-12-06 23:38         ` Mark Brown
2010-12-07 12:34           ` Liam Girdwood
2010-12-07 12:36             ` Mark Brown
2010-12-07 12:46               ` Liam Girdwood
2010-12-07 13:09                 ` Mark Brown
2010-12-07 14:01                   ` Liam Girdwood
2010-12-07 14:13                     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291678207.3281.152.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=magi.olaya@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox