From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: "Olaya, Margarita" <magi.olaya@ti.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: dapm: Add speaker driver widget.
Date: Tue, 7 Dec 2010 14:13:39 +0000 [thread overview]
Message-ID: <20101207141338.GY4698@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1291730484.3275.54.camel@odin>
On Tue, Dec 07, 2010 at 02:01:24PM +0000, Liam Girdwood wrote:
> On Tue, 2010-12-07 at 13:09 +0000, Mark Brown wrote:
> > You can say that for pretty much all of the widgets, though, including
> > the existing speaker and headphone widgets.
> You can only really say for the last widget in the sequence.
Pretty much anything might be the last widget in the chain, and
obviously you can need to do stuff like this within the CODEC as well as
the machine (after all that's exactly what this is about).
For full flexibility we need something like optional sorting within each
widget type.
> @@ -61,6 +61,7 @@ static int dapm_up_seq[] = {
> [snd_soc_dapm_mixer] = 7,
> [snd_soc_dapm_mixer_named_ctl] = 7,
> [snd_soc_dapm_pga] = 8,
> + [snd_soc_dapm_drv] = 9,
> [snd_soc_dapm_adc] = 9,
> [snd_soc_dapm_hp] = 10,
> [snd_soc_dapm_spk] = 10,
> This patch shares the ADC sequence number for the DRV on the power ON.
This isn't entirely great for digital bypass paths (the current setup
isn't ideal either but that's a separate issue and harder to fix as you
can get PGAs on both input and output paths). You'll power up your
output driver and only then start feeding through samples from the ADC,
meaning a sudden introduction of any DC offset in the analogue input
that the ADC is passing through rather than getting the benefit of any
soft start or DC offset correction the hardware does. I'd rather see us
ading the new widget at step 10, either with the existing speaker and
headphone driver widgets or moving them up a step.
> and inserts a new number as you suggested for power OFF. Imo, nothing
> wrong with this approach and since I don't have all day to discuss, Magi
> will change both the sequence numbers to use the same number as
> snd_soc_dapm_spk.
Right, the down sequence is fine.
prev parent reply other threads:[~2010-12-07 14:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 22:34 [PATCH] ASoC: dapm: Add speaker driver widget Olaya, Margarita
2010-12-06 22:43 ` Mark Brown
2010-12-06 22:55 ` Liam Girdwood
2010-12-06 23:09 ` Mark Brown
2010-12-06 23:30 ` Liam Girdwood
2010-12-06 23:38 ` Mark Brown
2010-12-07 12:34 ` Liam Girdwood
2010-12-07 12:36 ` Mark Brown
2010-12-07 12:46 ` Liam Girdwood
2010-12-07 13:09 ` Mark Brown
2010-12-07 14:01 ` Liam Girdwood
2010-12-07 14:13 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207141338.GY4698@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=magi.olaya@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox