Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "Olaya, Margarita" <magi.olaya@ti.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: dapm: Add speaker driver widget.
Date: Tue, 07 Dec 2010 14:01:24 +0000	[thread overview]
Message-ID: <1291730484.3275.54.camel@odin> (raw)
In-Reply-To: <20101207130914.GF4698@rakim.wolfsonmicro.main>

On Tue, 2010-12-07 at 13:09 +0000, Mark Brown wrote:
> On Tue, Dec 07, 2010 at 12:46:28PM +0000, Liam Girdwood wrote:
> 
> > Ok, but by sharing the number we take away some flexibility in the
> > sequence ordering. Say something has to be done in the machine driver
> > _after_ the spk/haptic/vibra driver is enabled in the CODEC driver ?
> 
> You can say that for pretty much all of the widgets, though, including
> the existing speaker and headphone widgets.  

You can only really say for the last widget in the sequence.

> I'd be a bit surprised if
> you had anything afterwards in this case, a driver is generally the high
> power stage wired directly to the transducer.
> 
> > I dont actually see any major issue of using a new number here unless
> > you have it reserved for something else ?
> 
> Adding a new number and renumbering all the subsequent ones wouldn't be
> so bad, the patch wasn't doing that.

@@ -61,6 +61,7 @@ static int dapm_up_seq[] = {
        [snd_soc_dapm_mixer] = 7,
        [snd_soc_dapm_mixer_named_ctl] = 7,
        [snd_soc_dapm_pga] = 8,
+       [snd_soc_dapm_drv] = 9,
        [snd_soc_dapm_adc] = 9,
        [snd_soc_dapm_hp] = 10,
        [snd_soc_dapm_spk] = 10,

This patch shares the ADC sequence number for the DRV on the power ON.

@@ -72,6 +73,7 @@ static int dapm_down_seq[] = {
        [snd_soc_dapm_adc] = 1,
        [snd_soc_dapm_hp] = 2,
        [snd_soc_dapm_spk] = 2,
+       [snd_soc_dapm_drv] = 3,
        [snd_soc_dapm_pga] = 4,
        [snd_soc_dapm_mixer_named_ctl] = 5,
        [snd_soc_dapm_mixer] = 5,

and inserts a new number as you suggested for power OFF. Imo, nothing
wrong with this approach and since I don't have all day to discuss, Magi
will change both the sequence numbers to use the same number as
snd_soc_dapm_spk.

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

  reply	other threads:[~2010-12-07 14:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-06 22:34 [PATCH] ASoC: dapm: Add speaker driver widget Olaya, Margarita
2010-12-06 22:43 ` Mark Brown
2010-12-06 22:55   ` Liam Girdwood
2010-12-06 23:09     ` Mark Brown
2010-12-06 23:30       ` Liam Girdwood
2010-12-06 23:38         ` Mark Brown
2010-12-07 12:34           ` Liam Girdwood
2010-12-07 12:36             ` Mark Brown
2010-12-07 12:46               ` Liam Girdwood
2010-12-07 13:09                 ` Mark Brown
2010-12-07 14:01                   ` Liam Girdwood [this message]
2010-12-07 14:13                     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291730484.3275.54.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=magi.olaya@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox