Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "Olaya, Margarita" <magi.olaya@ti.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: dapm: Add speaker driver widget.
Date: Tue, 07 Dec 2010 12:34:45 +0000	[thread overview]
Message-ID: <1291725285.3275.14.camel@odin> (raw)
In-Reply-To: <8C6859A9-36EF-4016-822B-DA67D7147E28@opensource.wolfsonmicro.com>

On Mon, 2010-12-06 at 23:38 +0000, Mark Brown wrote:
> On 6 Dec 2010, at 23:30, Liam Girdwood wrote:
> > On Mon, 2010-12-06 at 23:09 +0000, Mark Brown wrote:
> >> 
> 
> >> Sure, but it's fulfiling the same role in the system - it's just that
> >> these days a lot more CODECs are pulling speaker drivers directly into
> >> the CODEC die.  Mostly these have worked well handled as PGAs so it's
> >> not been an issue.
> 
> > In this case as we need to enable the PGA before the driver and disable
> > the driver before the PGA for pop reduction. Hence the current ordering
> > needs an addition/refactoring to deal with the newer generation of
> > CODECs here.
> 
> Well, what I'm saying is that...
> 
> >> I'd certainly expect to see it handled the same way from a DAPM
> >> sequencing point of view as it's fulfilling the same role in the system
> >> (so in the same slot rather than separately as the patch was doing).  Do
> >> we just need to refactor the existing external widgets to be able to
> >> exist in either register or GPIO based versions?
> 
> ...we don't need to change the ordering at all, we've already got a
> sequence point for this sort of widget we can use. We should just make
> the existing speaker and headphone widgets be in terms of one, I think.
> 

The only minor problem here is that the current sequence point is name
"snd_soc_dapm_spk" which would seem confusing to haptic/vibra driver
users. Although, I can live with this....

Liam

  reply	other threads:[~2010-12-07 12:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-06 22:34 [PATCH] ASoC: dapm: Add speaker driver widget Olaya, Margarita
2010-12-06 22:43 ` Mark Brown
2010-12-06 22:55   ` Liam Girdwood
2010-12-06 23:09     ` Mark Brown
2010-12-06 23:30       ` Liam Girdwood
2010-12-06 23:38         ` Mark Brown
2010-12-07 12:34           ` Liam Girdwood [this message]
2010-12-07 12:36             ` Mark Brown
2010-12-07 12:46               ` Liam Girdwood
2010-12-07 13:09                 ` Mark Brown
2010-12-07 14:01                   ` Liam Girdwood
2010-12-07 14:13                     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291725285.3275.14.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=magi.olaya@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox