amd-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Timur Kristóf" <timur.kristof@gmail.com>
To: amd-gfx@lists.freedesktop.org
Cc: alexander.deucher@amd.com, alex.hung@amd.com,
	harry.wentland@amd.com, siqueira@igalia.com,
	christian.koenig@amd.com,
	"Timur Kristóf" <timur.kristof@gmail.com>
Subject: [PATCH 3/3] drm/amd/display: Set stricter clock dividers on DCE 6-10
Date: Fri, 26 Sep 2025 20:26:14 +0200	[thread overview]
Message-ID: <20250926182614.26629-4-timur.kristof@gmail.com> (raw)
In-Reply-To: <20250926182614.26629-1-timur.kristof@gmail.com>

Set stricter dividers to stabilize the PLL's feedback loop.
In practice, the actual output isn't exactly the target
clock, but slowly oscillates around it. This makes it
more stable.

The values here are taken from the non-DC code.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
---
 drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c b/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
index b4f5b4a6331a..00f25e2ee081 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
@@ -1700,6 +1700,13 @@ bool dce110_clk_src_construct(
 			clk_src->cs_mask->PLL_POST_DIV_PIXCLK;
 	calc_pll_cs_init_data.min_pll_ref_divider =	1;
 	calc_pll_cs_init_data.max_pll_ref_divider =	clk_src->cs_mask->PLL_REF_DIV;
+
+	if (ctx->dce_version <= DCE_VERSION_10_0) {
+		/* Set stricter dividers to stabilize the PLL's feedback loop on old HW. */
+		calc_pll_cs_init_data.min_pix_clk_pll_post_divider = 2;
+		calc_pll_cs_init_data.min_pll_ref_divider = 2;
+	}
+
 	/* when 0 use minInputPxlClkPLLFrequencyInKHz from firmwareInfo*/
 	calc_pll_cs_init_data.min_override_input_pxl_clk_pll_freq_khz =	0;
 	/* when 0 use maxInputPxlClkPLLFrequencyInKHz from firmwareInfo*/
-- 
2.51.0


  parent reply	other threads:[~2025-09-26 18:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-26 18:26 [PATCH 0/3] More SI power management and PLL fixes Timur Kristóf
2025-09-26 18:26 ` [PATCH 1/3] drm/amd/pm: Disable MCLK switching on SI at high pixel clocks Timur Kristóf
2025-10-09 19:30   ` Alex Deucher
2025-09-26 18:26 ` [PATCH 2/3] drm/amd: Disable ASPM on SI Timur Kristóf
2025-10-09 19:31   ` Alex Deucher
2025-09-26 18:26 ` Timur Kristóf [this message]
2025-09-28 14:14   ` [PATCH 3/3] drm/amd/display: Set stricter clock dividers on DCE 6-10 Christian König
2025-09-28 23:33     ` timur.kristof
2025-10-09 19:38       ` Alex Deucher
2025-10-13  6:15         ` Timur Kristóf
2025-10-13 13:12           ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250926182614.26629-4-timur.kristof@gmail.com \
    --to=timur.kristof@gmail.com \
    --cc=alex.hung@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=harry.wentland@amd.com \
    --cc=siqueira@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).