Re: [PATCH 08/14] drm/amd/display: Delete dm_pp_clocks_state

["Timur Kristóf" <timur.kristof@gmail.com>]

On 2026. április 29., szerda 22:37:38 közép-európai nyári idő Melissa Wen 
wrote:
> On 23/04/2026 16:15, Timur Kristóf wrote:
> > It isn't used by anything anymore.
> > 
> > Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
> > ---
> > 
> >   .../drm/amd/display/dc/dm_services_types.h    | 27 -------------------
> >   1 file changed, 27 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/amd/display/dc/dm_services_types.h
> > b/drivers/gpu/drm/amd/display/dc/dm_services_types.h index
> > 44aa8d213d386..b3505d93503fd 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dm_services_types.h
> > +++ b/drivers/gpu/drm/amd/display/dc/dm_services_types.h
> > @@ -36,30 +36,7 @@ struct dm_pp_clock_range {
> > 
> >   	int max_khz;
> >   
> >   };
> > 
> > -enum dm_pp_clocks_state {
> > -	DM_PP_CLOCKS_STATE_INVALID,
> > -	DM_PP_CLOCKS_STATE_ULTRA_LOW,
> > -	DM_PP_CLOCKS_STATE_LOW,
> > -	DM_PP_CLOCKS_STATE_NOMINAL,
> > -	DM_PP_CLOCKS_STATE_PERFORMANCE,
> > -
> > -	/* Starting from DCE11, Max 8 levels of DPM state supported. */
> > -	DM_PP_CLOCKS_DPM_STATE_LEVEL_INVALID = DM_PP_CLOCKS_STATE_INVALID,
> > -	DM_PP_CLOCKS_DPM_STATE_LEVEL_0,
> > -	DM_PP_CLOCKS_DPM_STATE_LEVEL_1,
> > -	DM_PP_CLOCKS_DPM_STATE_LEVEL_2,
> > -	/* to be backward compatible */
> > -	DM_PP_CLOCKS_DPM_STATE_LEVEL_3,
> > -	DM_PP_CLOCKS_DPM_STATE_LEVEL_4,
> > -	DM_PP_CLOCKS_DPM_STATE_LEVEL_5,
> > -	DM_PP_CLOCKS_DPM_STATE_LEVEL_6,
> > -	DM_PP_CLOCKS_DPM_STATE_LEVEL_7,
> > -
> > -	DM_PP_CLOCKS_MAX_STATES
> > -};
> > -
> > 
> >   struct dm_pp_gpu_clock_range {
> > 
> > -	enum dm_pp_clocks_state clock_state;
> > 
> >   	struct dm_pp_clock_range sclk;
> >   	struct dm_pp_clock_range mclk;
> >   	struct dm_pp_clock_range eclk;
> > 
> > @@ -246,10 +223,6 @@ enum dm_acpi_display_type {
> > 
> >   	AcpiDisplayType_DFP6 = 12
> >   
> >   };
> > 
> > -struct dm_pp_power_level_change_request {
> > -	enum dm_pp_clocks_state power_level;
> > -};
> 
> Ah, okay, here is the dm_pp_power_level_change_request removal.
> I think it should be removed earlier.

Thanks. In the next version of the series I will move it to earlier.

> 
> Apart from that,
> 
> Reviewed-by: Melissa Wen <mwen@igalia.com>
> 
> > -
> > 
> >   struct dm_pp_clock_for_voltage_req {
> >   
> >   	enum dm_pp_clock_type clk_type;
> >   	uint32_t clocks_in_khz;