public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Sebastian Sewior <bigeasy@linutronix.de>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Peter Ziljstra <peterz@infradead.org>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
	Jiri Olsa <jolsa@kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: uprobe splat in PREEMP_RT
Date: Wed, 2 Apr 2025 16:12:46 +0200	[thread overview]
Message-ID: <20250402141245.GK22091@redhat.com> (raw)
In-Reply-To: <20250402122447.B3XIrQnG@linutronix.de>

On 04/02, Sebastian Sewior wrote:
>
> On 2025-04-02 14:18:51 [+0200], Oleg Nesterov wrote:
> > On 04/02, Sebastian Sewior wrote:
>
> I need to tell mutt to replace my name in case it is misspelled.

Hmm... have I misspelled your name somewhere?

If yes - my apologies.

> > > The preempted ri_timer() could stall a read_seqcount_begin().
> >
> > Again, nobody use read_seqcount_begin(utask->ri_seqcount).
> >
> > free_ret_instance() uses raw_seqcount_try_begin(utask->ri_seqcount),
> > which, since ri_seqcount is seqcount_t, is just smp_load_acquire().
> > This can't stall.
>
> Yes. This would work for here just to skip the check because of all
> details that are hard to express. Therefore I suggested to use
> raw_write_seqcount_begin() instead of write_seqcount_begin() in
> 20250402122158.j_8VoHQ-@linutronix.de. Would that work?

If this can work, then let me repeat: why can't we turn ->ri_seqcount
into a boolean?

That was my question. I don't understand the purpose of
"seqcount_t ri_seqcount" regardless of the reported problem.
This "WARNING: CPU: 0 PID: 16 at include/linux/seqlock.h:221" is another
issue.

Again, I must have missed something.

Oleg.


  reply	other threads:[~2025-04-02 14:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01 21:04 uprobe splat in PREEMP_RT Alexei Starovoitov
2025-04-01 21:22 ` Steven Rostedt
2025-04-01 22:01   ` Andrii Nakryiko
2025-04-02 10:33     ` Oleg Nesterov
2025-04-02 10:57       ` Sebastian Sewior
2025-04-02 11:23         ` Oleg Nesterov
2025-04-02 12:13           ` Sebastian Sewior
2025-04-02 12:18             ` Oleg Nesterov
2025-04-02 12:24               ` Sebastian Sewior
2025-04-02 14:12                 ` Oleg Nesterov [this message]
2025-04-03  7:37                   ` Sebastian Sewior
2025-04-03 12:27                     ` Oleg Nesterov
2025-04-03 16:04                       ` Andrii Nakryiko
2025-04-02 16:15       ` Andrii Nakryiko
2025-04-02 16:57         ` Oleg Nesterov
2025-04-02 12:21     ` Sebastian Sewior
2025-04-02  9:10 ` Oleg Nesterov
2025-04-02 10:54   ` Sebastian Sewior
2025-04-02 11:20     ` Oleg Nesterov
2025-04-02 11:31       ` Oleg Nesterov
2025-04-02 12:06         ` Sebastian Sewior
2025-04-02 12:12           ` Oleg Nesterov
2025-04-02 12:16             ` Sebastian Sewior
2025-04-02 13:56               ` Oleg Nesterov
2025-04-02 14:23                 ` Oleg Nesterov
2025-04-03  9:08                   ` Sebastian Sewior
2025-04-03 12:11                     ` Oleg Nesterov
2025-04-03 12:43                       ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250402141245.GK22091@redhat.com \
    --to=oleg@redhat.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=jolsa@kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox