From: "Cédric Marie" <cedric.marie@openmailbox.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: Remove KBUILD_VERBOSE and quiet
Date: Fri, 11 Sep 2015 09:52:07 +0200 [thread overview]
Message-ID: <003996441bb228c23d8e79202370f8d1@openmailbox.org> (raw)
In-Reply-To: <55EEE3F1.3000508@mind.be>
Hi,
I've just realized that this patch is breaking linux and busybox verbose
mode.
Exporting KBUILD_VERBOSE makes it available for linux and busybox
makefile. This makefile sets KBUILD_VERBOSE if V is set in the command
line, but it also uses KBUILD_VERBOSE if exported by the shell.
In fact it seems that the original idea was to export all variables that
could be understood by different build systems:
- KBUILD_VERBOSE for linux and busybox
- VERBOSE for CMake packages.
So, if we still want to handle verbosity in infrastructures (and some
packages that use generic infrastructure) - and I think we should:
I think the right way to forward verbose mode to linux and busybox is to
add V=1 in linux.mk and busybox.mk.
As a consequence, I believe it is not possible to split my patch into
different steps.
The patch must:
- remove quiet
- remove KBUILD_VERBOSE
- use VERBOSE but in a different way (not exported), as already
described
- handle VERBOSE in pkg-cmake.mk, pkg-autotools.mk, linux.mk,
busybox.mk, and qt.mk (this one is possibly already correct).
If you agree, I will provide a single patch that will cancel the two
previous ones (I will add patch version and log this time).
Regards,
--
C?dric
next prev parent reply other threads:[~2015-09-11 7:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 20:47 [Buildroot] [PATCH] Makefile: Remove KBUILD_VERBOSE and quiet Cédric Marie
2015-09-07 21:14 ` Arnout Vandecappelle
2015-09-08 12:14 ` Cédric Marie
2015-09-08 12:30 ` Arnout Vandecappelle
2015-09-08 13:01 ` Cédric Marie
2015-09-08 13:34 ` Arnout Vandecappelle
2015-09-11 7:52 ` Cédric Marie [this message]
2015-09-11 14:14 ` Arnout Vandecappelle
2015-09-20 13:11 ` Thomas Petazzoni
2015-09-20 20:43 ` Cédric Marie
2015-09-20 21:04 ` Thomas Petazzoni
2015-09-20 21:26 ` Arnout Vandecappelle
2015-09-21 10:23 ` Cédric Marie
2015-09-21 17:11 ` Arnout Vandecappelle
2015-10-02 15:52 ` Cédric Marie
2015-10-03 11:57 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=003996441bb228c23d8e79202370f8d1@openmailbox.org \
--to=cedric.marie@openmailbox.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox