From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: Remove KBUILD_VERBOSE and quiet
Date: Tue, 8 Sep 2015 14:30:02 +0200 [thread overview]
Message-ID: <55EED4CA.3040304@mind.be> (raw)
In-Reply-To: <d72ff365b4711836e5c1990f7b72923c@openmailbox.org>
On 08-09-15 14:14, C?dric Marie wrote:
> Hi,
>
> Le 2015-09-07 23:14, Arnout Vandecappelle a ?crit :
>> Don't forget to version your patches and keep a patch changelog...
>
> I had this remark in mind - you told me some time ago - but I intended to do it
> with the patch that will handle verbosity in infrastructures. I kind of
> considered this one as a new one.
> Since the patch has been split into several patches, should I increment the
> version for every new patch?
Yeah, that's more convenient. The goal of the version number is to make it
clear that something similar has come by before and that that previous thing is
superseded by the new thing.
>
>
>> I would already have introduced the VERBOSE construct in this patch, but I
>> guess this one is less controversial, so OK.
>
> I have tried to follow your guidelines:
>
>> 1. Remove KBUILD_VERBOSE and quiet (this one will be uncontroversial I think)
>> 2. Define VERBOSE based on V= passed on command line
>> 3. Use VERBOSE in autotools and cmake
>> 4. Update documentation.
Oops, you're right, I proposed that myself :-) But I didn't realise that the
VERBOSE variable existed already.
>
>
> Do you confirm I still should send two separate patches for steps 2 and 3?
No, since VERBOSE already exists, my proposed step 2 is useless.
Regards,
Arnout
>
> Regards,
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2015-09-08 12:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 20:47 [Buildroot] [PATCH] Makefile: Remove KBUILD_VERBOSE and quiet Cédric Marie
2015-09-07 21:14 ` Arnout Vandecappelle
2015-09-08 12:14 ` Cédric Marie
2015-09-08 12:30 ` Arnout Vandecappelle [this message]
2015-09-08 13:01 ` Cédric Marie
2015-09-08 13:34 ` Arnout Vandecappelle
2015-09-11 7:52 ` Cédric Marie
2015-09-11 14:14 ` Arnout Vandecappelle
2015-09-20 13:11 ` Thomas Petazzoni
2015-09-20 20:43 ` Cédric Marie
2015-09-20 21:04 ` Thomas Petazzoni
2015-09-20 21:26 ` Arnout Vandecappelle
2015-09-21 10:23 ` Cédric Marie
2015-09-21 17:11 ` Arnout Vandecappelle
2015-10-02 15:52 ` Cédric Marie
2015-10-03 11:57 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EED4CA.3040304@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox