From: "Cédric Marie" <cedric.marie@openmailbox.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: Remove KBUILD_VERBOSE and quiet
Date: Fri, 02 Oct 2015 17:52:00 +0200 [thread overview]
Message-ID: <62a2d08d2430eb10d07b3a87b6d42906@openmailbox.org> (raw)
In-Reply-To: <56003A45.8050306@mind.be>
Hi,
The more I try to fix it, the more I believe there is nothing to fix...
:)
Arnout has pointed out that KBUILD_VERBOSE should be kept, because it
was a nice way to set verbose level in Kbuild packages, without having
to modify any .mk files.
I have also recently realized that autotools infrastructure didn't need
anything more to have support for V=0 or 1.
When V is in the command line, it is exported to all sub-makes. As a
consequence, an autotools package already sees the value of V. It
doesn't check whether it comes from the command line or not.
I thought there was a problem because I first checked with autotools
packages that did not support verbose level, and couldn't see any
difference. With libpthsem, I have realized that V=0/1 was already
supported.
The fact that V is exported is not enough for Kbuild packages, because
they also check that it comes from the command line. That's why they
need KBUILD_VERBOSE to be exported. Autotools packages don't check that
V comes from the command line.
So, in the end, I think it would be stupid to convert V=0/1 into
VERBOSE=0/1, and then, in pkg-autotools.mk, convert VERBOSE=0/1 into
V=0/1 - which is already set and exported - again!...
So, to sum up:
- we keep KBUILD_VERBOSE for Kbuild packages
- we don't need to change anything for autotools packages
- If CMake is the only one that needs a conversion (from V to VERBOSE),
wouldn't it be more simple to keep on exporting VERBOSE as it is done
currently?
In the end, the only thing I could do, is just to remove "quiet" :)
I can still provide a patch for that, if it makes sense.
Sorry for the time we have spent on this subject, while there is -
almost - nothing to change in the end...
There are many subtleties in makefiles that I was not aware of, in the
first place.
--
C?dric
next prev parent reply other threads:[~2015-10-02 15:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 20:47 [Buildroot] [PATCH] Makefile: Remove KBUILD_VERBOSE and quiet Cédric Marie
2015-09-07 21:14 ` Arnout Vandecappelle
2015-09-08 12:14 ` Cédric Marie
2015-09-08 12:30 ` Arnout Vandecappelle
2015-09-08 13:01 ` Cédric Marie
2015-09-08 13:34 ` Arnout Vandecappelle
2015-09-11 7:52 ` Cédric Marie
2015-09-11 14:14 ` Arnout Vandecappelle
2015-09-20 13:11 ` Thomas Petazzoni
2015-09-20 20:43 ` Cédric Marie
2015-09-20 21:04 ` Thomas Petazzoni
2015-09-20 21:26 ` Arnout Vandecappelle
2015-09-21 10:23 ` Cédric Marie
2015-09-21 17:11 ` Arnout Vandecappelle
2015-10-02 15:52 ` Cédric Marie [this message]
2015-10-03 11:57 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62a2d08d2430eb10d07b3a87b6d42906@openmailbox.org \
--to=cedric.marie@openmailbox.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox