Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: Remove KBUILD_VERBOSE and quiet
Date: Sun, 20 Sep 2015 15:11:57 +0200	[thread overview]
Message-ID: <20150920151157.7dc9b021@free-electrons.com> (raw)
In-Reply-To: <1441658846-5786-1-git-send-email-cedric.marie@openmailbox.org>

C?dric,

On Mon,  7 Sep 2015 22:47:26 +0200, C?dric Marie wrote:
> KBUILD_VERBOSE and quiet variables are set and exported, but they are
> not used. We can safely remove them.
> 
> These variables are inherited from the Makefile of the Linux kernel,
> and are not used in Buildroot.
> 
> In support/scripts/mkmakefile, quiet value is checked, but the test is
> always true (quiet is never set to silent_), so the test can be removed
> as well.
> 
> Signed-off-by: C?dric Marie <cedric.marie@openmailbox.org>
> ---
>  Makefile                   | 20 ++++++--------------
>  support/scripts/mkmakefile |  4 +---
>  2 files changed, 7 insertions(+), 17 deletions(-)

Following the discussion you had with Arnout, and your own report that
this patch was breaking things in the Busybox and Linux kernel build, I
marked this patch as "Changes Requested" in patchwork.

Will you work on a new iteration of this patch?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-09-20 13:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07 20:47 [Buildroot] [PATCH] Makefile: Remove KBUILD_VERBOSE and quiet Cédric Marie
2015-09-07 21:14 ` Arnout Vandecappelle
2015-09-08 12:14   ` Cédric Marie
2015-09-08 12:30     ` Arnout Vandecappelle
2015-09-08 13:01       ` Cédric Marie
2015-09-08 13:34         ` Arnout Vandecappelle
2015-09-11  7:52           ` Cédric Marie
2015-09-11 14:14             ` Arnout Vandecappelle
2015-09-20 13:11 ` Thomas Petazzoni [this message]
2015-09-20 20:43   ` Cédric Marie
2015-09-20 21:04     ` Thomas Petazzoni
2015-09-20 21:26     ` Arnout Vandecappelle
2015-09-21 10:23       ` Cédric Marie
2015-09-21 17:11         ` Arnout Vandecappelle
2015-10-02 15:52           ` Cédric Marie
2015-10-03 11:57             ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150920151157.7dc9b021@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox