Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: Remove KBUILD_VERBOSE and quiet
Date: Sun, 20 Sep 2015 23:26:48 +0200	[thread overview]
Message-ID: <55FF2498.3060105@mind.be> (raw)
In-Reply-To: <55FF1A8A.5030507@openmailbox.org>

On 20-09-15 22:43, C?dric Marie wrote:
> Hi Thomas, Arnout, and all,
> 
> Le 20/09/2015 15:11, Thomas Petazzoni a ?crit :
>> Following the discussion you had with Arnout, and your own report that
>> this patch was breaking things in the Busybox and Linux kernel build, I
>> marked this patch as "Changes Requested" in patchwork.
>>
>> Will you work on a new iteration of this patch?
> 
> Yes, I've started to work on a new iteration. It is working fine with CMake,
> autotools, and Kbuild packages (I keep on exporting KBUILD_VERBOSE as suggested
> by Arnout).
> 
> I still have to:
> 
> - modify qt.mk because it currently enables verbose mode if VERBOSE is defined
> and not empty, but my modification implies that VERBOSE may be equal to 0, and
> it should not enable verbose mode in that case!...

 Well, just unset VERBOSE when V=0. So VERBOSE is either empty or 1. Similar
with how Config.in works.

> - check that no other package .mk file is using VERBOSE variable.

git grep -w VERBOSE
-> only in qt.mk

> - write clear comments and commit message.

 Yep, very important!

 Regards,
 Arnout

> 
> Sorry for the delay, but I've got only very occasional free time to spend on it.
> 
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  parent reply	other threads:[~2015-09-20 21:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07 20:47 [Buildroot] [PATCH] Makefile: Remove KBUILD_VERBOSE and quiet Cédric Marie
2015-09-07 21:14 ` Arnout Vandecappelle
2015-09-08 12:14   ` Cédric Marie
2015-09-08 12:30     ` Arnout Vandecappelle
2015-09-08 13:01       ` Cédric Marie
2015-09-08 13:34         ` Arnout Vandecappelle
2015-09-11  7:52           ` Cédric Marie
2015-09-11 14:14             ` Arnout Vandecappelle
2015-09-20 13:11 ` Thomas Petazzoni
2015-09-20 20:43   ` Cédric Marie
2015-09-20 21:04     ` Thomas Petazzoni
2015-09-20 21:26     ` Arnout Vandecappelle [this message]
2015-09-21 10:23       ` Cédric Marie
2015-09-21 17:11         ` Arnout Vandecappelle
2015-10-02 15:52           ` Cédric Marie
2015-10-03 11:57             ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55FF2498.3060105@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox