* [Buildroot] [PATCH] toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7
@ 2017-06-06 14:08 Jörg Krause
2017-06-06 15:32 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Jörg Krause @ 2017-06-06 14:08 UTC (permalink / raw)
To: buildroot
As GCC7 is now available in Buildroot, update the definition for
BR2_TOOLCHAIN_HAS_GCC_BUG_64735 as the bug #64735 is fixed in GCC 7.
Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
---
toolchain/toolchain-common.in | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in
index d670f44747..06986abdd2 100644
--- a/toolchain/toolchain-common.in
+++ b/toolchain/toolchain-common.in
@@ -13,10 +13,9 @@ comment "Toolchain Generic Options"
# ints before GCC 7
config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
bool
- default y if BR2_nios2
- default y if BR2_ARM_CPU_ARMV4
- default y if BR2_ARM_CPU_ARMV5
- default y if BR2_sparc_v8
+ default y if (BR2_nios2 || BR2_ARM_CPU_ARMV4 || \
+ BR2_ARM_CPU_ARMV5 || BR2_sparc_v8) && \
+ !BR2_TOOLCHAIN_GCC_AT_LEAST_7
config BR2_TOOLCHAIN_HAS_NATIVE_RPC
bool
--
2.13.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7
2017-06-06 14:08 [Buildroot] [PATCH] toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7 Jörg Krause
@ 2017-06-06 15:32 ` Thomas Petazzoni
2017-06-06 18:44 ` Jörg Krause
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2017-06-06 15:32 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 6 Jun 2017 16:08:50 +0200, J?rg Krause wrote:
> diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in
> index d670f44747..06986abdd2 100644
> --- a/toolchain/toolchain-common.in
> +++ b/toolchain/toolchain-common.in
> @@ -13,10 +13,9 @@ comment "Toolchain Generic Options"
> # ints before GCC 7
> config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
> bool
> - default y if BR2_nios2
> - default y if BR2_ARM_CPU_ARMV4
> - default y if BR2_ARM_CPU_ARMV5
> - default y if BR2_sparc_v8
> + default y if (BR2_nios2 || BR2_ARM_CPU_ARMV4 || \
> + BR2_ARM_CPU_ARMV5 || BR2_sparc_v8) && \
> + !BR2_TOOLCHAIN_GCC_AT_LEAST_7
This feels very complicated. What about just:
depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7
2017-06-06 15:32 ` Thomas Petazzoni
@ 2017-06-06 18:44 ` Jörg Krause
2017-06-06 19:23 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Jörg Krause @ 2017-06-06 18:44 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Tue, 2017-06-06 at 17:32 +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Tue, 6 Jun 2017 16:08:50 +0200, J?rg Krause wrote:
>
> > diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in
> > index d670f44747..06986abdd2 100644
> > --- a/toolchain/toolchain-common.in
> > +++ b/toolchain/toolchain-common.in
> > @@ -13,10 +13,9 @@ comment "Toolchain Generic Options"
> > # ints before GCC 7
> > config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
> > bool
> > - default y if BR2_nios2
> > - default y if BR2_ARM_CPU_ARMV4
> > - default y if BR2_ARM_CPU_ARMV5
> > - default y if BR2_sparc_v8
> > + default y if (BR2_nios2 || BR2_ARM_CPU_ARMV4 || \
> > + BR2_ARM_CPU_ARMV5 || BR2_sparc_v8) && \
> > + !BR2_TOOLCHAIN_GCC_AT_LEAST_7
>
> This feels very complicated. What about just:
>
> depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
Wouldn't that be rather:
"""
config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
"""
The package mpd chooses between version 0.19 and 0.20 depending on that
bug. For now, if mpd is build with GCC6 (and below) and an architecture
not affected by this bug, version 0.20 is selected. By not depending on
the architecture anymore, mpd version 0.19 would be selected instead.
J?rg
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7
2017-06-06 18:44 ` Jörg Krause
@ 2017-06-06 19:23 ` Thomas Petazzoni
2017-06-06 19:35 ` Jörg Krause
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2017-06-06 19:23 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 06 Jun 2017 20:44:05 +0200, J?rg Krause wrote:
> > > config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
> > > bool
> > > - default y if BR2_nios2
> > > - default y if BR2_ARM_CPU_ARMV4
> > > - default y if BR2_ARM_CPU_ARMV5
> > > - default y if BR2_sparc_v8
> > > + default y if (BR2_nios2 || BR2_ARM_CPU_ARMV4 || \
> > > + BR2_ARM_CPU_ARMV5 || BR2_sparc_v8) && \
> > > + !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> >
> > This feels very complicated. What about just:
> >
> > depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
>
> Wouldn't that be rather:
>
> """
> config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
> default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> """
No because that would make the option "y" as soon as you have gcc < 7.
But we want the option to be "y" only if you have gcc < 7 *and* you're
using one of nios2, ARMv4/v5 or sparc v8.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7
2017-06-06 19:23 ` Thomas Petazzoni
@ 2017-06-06 19:35 ` Jörg Krause
2017-06-06 19:42 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Jörg Krause @ 2017-06-06 19:35 UTC (permalink / raw)
To: buildroot
On Tue, 2017-06-06 at 21:23 +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Tue, 06 Jun 2017 20:44:05 +0200, J?rg Krause wrote:
>
> > > > config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
> > > > bool
> > > > - default y if BR2_nios2
> > > > - default y if BR2_ARM_CPU_ARMV4
> > > > - default y if BR2_ARM_CPU_ARMV5
> > > > - default y if BR2_sparc_v8
> > > > + default y if (BR2_nios2 || BR2_ARM_CPU_ARMV4 || \
> > > > + BR2_ARM_CPU_ARMV5 || BR2_sparc_v8) && \
> > > > + !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> > >
> > > This feels very complicated. What about just:
> > >
> > > depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> >
> > Wouldn't that be rather:
> >
> > """
> > config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
> > default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> > """
>
> No because that would make the option "y" as soon as you have gcc < 7.
> But we want the option to be "y" only if you have gcc < 7 *and* you're
> using one of nios2, ARMv4/v5 or sparc v8.
Sorry, I totally got you wrong. So, what you mean is:
"""
config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
bool
default y if BR2_nios2
default y if BR2_ARM_CPU_ARMV4
default y if BR2_ARM_CPU_ARMV5
default y if BR2_sparc_v8
depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
"""
Right?
J?rg
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7
2017-06-06 19:35 ` Jörg Krause
@ 2017-06-06 19:42 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2017-06-06 19:42 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 06 Jun 2017 21:35:04 +0200, J?rg Krause wrote:
> Sorry, I totally got you wrong. So, what you mean is:
>
>
> """
> config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
> bool
> default y if BR2_nios2
> default y if BR2_ARM_CPU_ARMV4
> default y if BR2_ARM_CPU_ARMV5
> default y if BR2_sparc_v8
> depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> """
>
> Right?
Yes, exactly!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-06-06 19:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-06 14:08 [Buildroot] [PATCH] toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7 Jörg Krause
2017-06-06 15:32 ` Thomas Petazzoni
2017-06-06 18:44 ` Jörg Krause
2017-06-06 19:23 ` Thomas Petazzoni
2017-06-06 19:35 ` Jörg Krause
2017-06-06 19:42 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox