[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[laird at uclibc.org]

Author: laird
Date: 2009-01-21 13:33:21 +0000 (Wed, 21 Jan 2009)
New Revision: 24937

Log:
package/multimedia/gst-plugins-good/gst-plugins-good.mk
package/multimedia/gst-plugins-good/Config.in

gst-plugins-good does not build unless some package dependencies are forced.
This patch allows you to turn off some of the plugins with these dependencies and hides
others that require some packages (like PNG/JPEG)

Signed-off-by: Daniel Laird <daniel.j.laird@nxp.com>



Modified:
   trunk/buildroot/package/multimedia/gst-plugins-good/Config.in
   trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk


Changeset:
Modified: trunk/buildroot/package/multimedia/gst-plugins-good/Config.in
===================================================================
--- trunk/buildroot/package/multimedia/gst-plugins-good/Config.in	2009-01-21 07:09:41 UTC (rev 24936)
+++ trunk/buildroot/package/multimedia/gst-plugins-good/Config.in	2009-01-21 13:33:21 UTC (rev 24937)
@@ -72,6 +72,7 @@
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MATROSKA
 	bool "matroska"
+	depends on BR2_PACKAGE_BZIP2 && BR2_PACKAGE_ZLIB
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MONOSCOPE
 	bool "monoscope"
@@ -119,4 +120,25 @@
 	bool "wavparse (*.wav audio)"
 	default y
 
+comment "plugins with external dependencies (more to come)"
+
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ANNODEX
+	bool "annodex (XML Library)"
+	default y
+
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ESD
+	bool "esdsink (ESounD sound daemon)"
+
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_JPEG
+	bool "jpeg (JPEG support)"
+	depends on BR2_PACKAGE_JPEG
+	default y
+
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_OSS
+	bool "ossaudio (OSS audio)"
+
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_PNG
+	bool "png (PNG support)"
+	depends on BR2_PACKAGE_LIBPNG
+	default y
 endif

Modified: trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk
===================================================================
--- trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk	2009-01-21 07:09:41 UTC (rev 24936)
+++ trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk	2009-01-21 13:33:21 UTC (rev 24937)
@@ -142,6 +142,7 @@
 
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MATROSKA),y)
 GST_PLUGINS_GOOD_CONF_OPT += --enable-matroska
+GST_PLUGINS_GOOD_DEPENDENCIES += zlib bzip2
 else
 GST_PLUGINS_GOOD_CONF_OPT += --disable-matroska
 endif
@@ -236,4 +237,36 @@
 GST_PLUGINS_GOOD_CONF_OPT += --disable-wavparse
 endif
 
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ANNODEX),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-annodex
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-annodex
+endif
+
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ESD),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-esd
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-esd
+endif
+
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_JPEG),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-jpeg
+GST_PLUGINS_GOOD_DEPENDENCIES += jpeg
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-jpeg
+endif
+
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_OSS),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-oss
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-oss
+endif
+
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_PNG),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-png
+GST_PLUGINS_GOOD_DEPENDENCIES += libpng
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-png
+endif
+
 $(eval $(call AUTOTARGETS,package/multimedia,gst-plugins-good))

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[Peter Korsgaard]

>>>>> "laird" == laird  <laird@uclibc.org> writes:

 laird> Author: laird
 laird> Date: 2009-01-21 13:33:21 +0000 (Wed, 21 Jan 2009)
 laird> New Revision: 24937

 laird> Log:
 laird> package/multimedia/gst-plugins-good/gst-plugins-good.mk
 laird> package/multimedia/gst-plugins-good/Config.in

 laird> gst-plugins-good does not build unless some package dependencies are forced.
 laird> This patch allows you to turn off some of the plugins with these dependencies and hides
 laird> others that require some packages (like PNG/JPEG)

 laird> Signed-off-by: Daniel Laird <daniel.j.laird@nxp.com>


 laird>  config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MATROSKA
 laird>  	bool "matroska"
 laird> +	depends on BR2_PACKAGE_BZIP2 && BR2_PACKAGE_ZLIB

I prefer to use select for library dependencies. How is the user
supposed to know that bzip2 and zlib needs to be enabled to even see
the matroska option.

 laird>  config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MONOSCOPE
 laird>  	bool "monoscope"
 laird> @@ -119,4 +120,25 @@
 laird>  	bool "wavparse (*.wav audio)"
 laird>  	default y
 
 laird> +comment "plugins with external dependencies (more to come)"
 laird> +

What is this comment supposed to mean? That these things don't build
right now?

-- 
Bye, Peter Korsgaard

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[Daniel Laird]

Ok I will change to use select.

regarding:
laird> +comment "plugins with external dependencies (more to come)"
 laird> +

The package has a number of plugins with external dependencies the 5 I have
added are ones that seems to end up being built by default but then fail due
to missing dependencies (ESD being first culprit).  The others plugins I
have not added as I have not tested them yet and the out of box 'untar;
configure; make' did not try making them.  I was trying to limit the scope
of the change with RC being done. 

-----Original Message-----
From: buildroot-bounces@busybox.net [mailto:buildroot-bounces at busybox.net]
On Behalf Of Peter Korsgaard
Sent: 2009 Jan 21 13:40
To: buildroot at uclibc.org
Subject: Re: [Buildroot] svn commit:
trunk/buildroot/package/multimedia/gst-plugins-good

>>>>> "laird" == laird  <laird@uclibc.org> writes:

 laird> Author: laird
 laird> Date: 2009-01-21 13:33:21 +0000 (Wed, 21 Jan 2009)
 laird> New Revision: 24937

 laird> Log:
 laird> package/multimedia/gst-plugins-good/gst-plugins-good.mk
 laird> package/multimedia/gst-plugins-good/Config.in

 laird> gst-plugins-good does not build unless some package dependencies are
forced.
 laird> This patch allows you to turn off some of the plugins with these
dependencies and hides
 laird> others that require some packages (like PNG/JPEG)

 laird> Signed-off-by: Daniel Laird <daniel.j.laird@nxp.com>


 laird>  config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MATROSKA
 laird>  	bool "matroska"
 laird> +	depends on BR2_PACKAGE_BZIP2 && BR2_PACKAGE_ZLIB

I prefer to use select for library dependencies. How is the user
supposed to know that bzip2 and zlib needs to be enabled to even see
the matroska option.

 laird>  config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MONOSCOPE
 laird>  	bool "monoscope"
 laird> @@ -119,4 +120,25 @@
 laird>  	bool "wavparse (*.wav audio)"
 laird>  	default y
 
 laird> +comment "plugins with external dependencies (more to come)"
 laird> +

What is this comment supposed to mean? That these things don't build
right now?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[Markus Heidelberg]

Daniel Laird, 21.01.2009:
> Ok I will change to use select.
> 
> regarding:
> laird> +comment "plugins with external dependencies (more to come)"
>  laird> +
> 
> The package has a number of plugins with external dependencies the 5 I have
> added are ones that seems to end up being built by default but then fail due
> to missing dependencies (ESD being first culprit).

I encountered similiar problems, when working on the gstreamer packages.
The plugins that caused problems, I simple --disable-d in the .mk files.
Same can be done with esdsink and ossaudio, instead of introducing
config options, that won't work for anyone if enabled. If somebody needs
specific plugins, he can work on getting the package deps right.

I guess these problems are influenced by the host configuration, at
least I hit some strange issues. Do you have esd installed?

Markus

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[Daniel James Laird]

Cheers for the feedback, What I will do is:
Move JPEG and PNG to top on Config.in
Disable ESD and OSS automatically in .mk file (as not yet available in buildroot)

I shall await your patch for the bzip2 etc stuff and then if you do not have direct access will test and apply.
is this ok?

Dan

-----Original Message-----
From: markus.heidelberg@web.de [mailto:markus.heidelberg at web.de] 
Sent: 2009 Jan 22 09:17
To: buildroot at uclibc.org
Cc: Daniel Laird; 'Peter Korsgaard'
Subject: Re: [Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

Daniel Laird, 21.01.2009:
> Ok I will change to use select.
> 
> regarding:
> laird> +comment "plugins with external dependencies (more to come)"
>  laird> +
> 
> The package has a number of plugins with external dependencies the 5 I have
> added are ones that seems to end up being built by default but then fail due
> to missing dependencies (ESD being first culprit).

I encountered similiar problems, when working on the gstreamer packages.
The plugins that caused problems, I simple --disable-d in the .mk files.
Same can be done with esdsink and ossaudio, instead of introducing
config options, that won't work for anyone if enabled. If somebody needs
specific plugins, he can work on getting the package deps right.

I guess these problems are influenced by the host configuration, at
least I hit some strange issues. Do you have esd installed?

Markus

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[Markus Heidelberg]

Daniel James Laird, 22.01.2009:
> Cheers for the feedback, What I will do is:
> Move JPEG and PNG to top on Config.in

For consistency with bz2 and zlib from my patch, since they aren't
plugins, it would be nice to also remove the "PLUGIN_":

BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_JPEG -> BR2_PACKAGE_GST_PLUGINS_GOOD_JPEG
BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_PNG  -> BR2_PACKAGE_GST_PLUGINS_GOOD_PNG

> Disable ESD and OSS automatically in .mk file (as not yet available in
> buildroot)

Yes.

And don't forget the dependency for annodex. Since you enabled it per
default (which I'd sugest to change as well), it looks like you have
used it.

> I shall await your patch for the bzip2 etc stuff and then if you do
> not have direct access will test and apply.
> is this ok?

Sure.

Markus

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[Markus Heidelberg]

Markus Heidelberg, 22.01.2009:
> Daniel James Laird, 22.01.2009:
> 
> BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_JPEG -> BR2_PACKAGE_GST_PLUGINS_GOOD_JPEG
> BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_PNG  -> BR2_PACKAGE_GST_PLUGINS_GOOD_PNG
> 
> > Disable ESD and OSS automatically in .mk file (as not yet available in
> > buildroot)
> 
> Yes.

Oh, wait. Why did I say so? Rubbish. I used osssink myself. I just
didn't thought about it. I didn't find a package that could be a
dependency, but of course the kernel headers are. So if the osssink
plugin causes problems for you (OSS disabled in the kernel config?),
please keep it as a config option. What should be used as dependency?
Nothing, just a note?

Markus

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[Markus Heidelberg]

laird at uclibc.org, 21.01.2009:
> Author: laird
> Date: 2009-01-21 13:33:21 +0000 (Wed, 21 Jan 2009)
> New Revision: 24937
> 
> Log:
> package/multimedia/gst-plugins-good/gst-plugins-good.mk
> package/multimedia/gst-plugins-good/Config.in
> 
> gst-plugins-good does not build unless some package dependencies are forced.
> This patch allows you to turn off some of the plugins with these dependencies and hides
> others that require some packages (like PNG/JPEG)
> 
> Signed-off-by: Daniel Laird <daniel.j.laird@nxp.com>
> 
> 
> 
> Modified:
>    trunk/buildroot/package/multimedia/gst-plugins-good/Config.in
>    trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk
> 
> 
> Changeset:
> Modified: trunk/buildroot/package/multimedia/gst-plugins-good/Config.in
> ===================================================================
> --- trunk/buildroot/package/multimedia/gst-plugins-good/Config.in	2009-01-21 07:09:41 UTC (rev 24936)
> +++ trunk/buildroot/package/multimedia/gst-plugins-good/Config.in	2009-01-21 13:33:21 UTC (rev 24937)
> @@ -72,6 +72,7 @@
>  
>  config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MATROSKA
>  	bool "matroska"
> +	depends on BR2_PACKAGE_BZIP2 && BR2_PACKAGE_ZLIB
>  
>  config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MONOSCOPE
>  	bool "monoscope"

This plugin is listed at the dependency-less plugins, so it should not
need to depend on any external library. Looking at
gst/matroska/matroska-demux.c, I can see that it is an optional
dependency with #ifdef HAVE_ZLIB and #ifdef HAVE_BZ2.

There are the --disable-zlib and --disable-bz2 configure options,
probably these should be used? I'll send a patch.

> @@ -119,4 +120,25 @@
>  	bool "wavparse (*.wav audio)"
>  	default y
>  
> +comment "plugins with external dependencies (more to come)"
> +
> +config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ANNODEX
> +	bool "annodex (XML Library)"
> +	default y

This is listed at the plugins with external dependencies. Looking at
Gentoo's ebuild, libxml2 is required. So there should be a "select
BR2_PACKAGE_LIBXML2" and and additional entry in the .mk file.

But why "default y"? In the initial patch, I just enabled the plugins
(all were dependency-less), that were mandatory for audio and video
playback. I think this should be kept.

> +config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ESD
> +	bool "esdsink (ESounD sound daemon)"

Also missing dependency. But I guess you put this here because it was
selected during configure. But since esd is not available in Buildroot,
it can be disabled completely.

> +config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_JPEG
> +	bool "jpeg (JPEG support)"
> +	depends on BR2_PACKAGE_JPEG
> +	default y

Again, I'd suggest to remove "default y". And as this is not a plugin, I
would not put it into the "external plugins" section, but at the top.

> +config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_OSS
> +	bool "ossaudio (OSS audio)"

Same as esdsink.

> +config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_PNG
> +	bool "png (PNG support)"
> +	depends on BR2_PACKAGE_LIBPNG
> +	default y
>  endif

Same as jpeg, please remove "default y" and put it at the top of
Config.in.

Markus

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[Peter Korsgaard]

>>>>> "Markus" == Markus Heidelberg <markus.heidelberg@web.de> writes:

Hi,

 Markus> This plugin is listed at the dependency-less plugins, so it
 Markus> should not need to depend on any external library. Looking at
 Markus> gst/matroska/matroska-demux.c, I can see that it is an
 Markus> optional dependency with #ifdef HAVE_ZLIB and #ifdef
 Markus> HAVE_BZ2.

 Markus> There are the --disable-zlib and --disable-bz2 configure
 Markus> options, probably these should be used? I'll send a patch.

Please do. I agree with all your comments.

-- 
Bye, Peter Korsgaard

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[laird at uclibc.org]

Author: laird
Date: 2009-01-22 08:09:53 +0000 (Thu, 22 Jan 2009)
New Revision: 24953

Log:
package/multimedia/gst-plugins-good/Config.in

Use select instead of depends on as it makes clear what people 
need rather than hiding options based on choices they dont
know they need to make.

Signed-off-by: Daniel Laird <daniel.j.laird@nxp.com>



Modified:
   trunk/buildroot/package/multimedia/gst-plugins-good/Config.in


Changeset:
Modified: trunk/buildroot/package/multimedia/gst-plugins-good/Config.in
===================================================================
--- trunk/buildroot/package/multimedia/gst-plugins-good/Config.in	2009-01-22 07:53:24 UTC (rev 24952)
+++ trunk/buildroot/package/multimedia/gst-plugins-good/Config.in	2009-01-22 08:09:53 UTC (rev 24953)
@@ -72,7 +72,8 @@
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MATROSKA
 	bool "matroska"
-	depends on BR2_PACKAGE_BZIP2 && BR2_PACKAGE_ZLIB
+	select BR2_PACKAGE_BZIP2
+	select BR2_PACKAGE_ZLIB
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MONOSCOPE
 	bool "monoscope"
@@ -131,7 +132,7 @@
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_JPEG
 	bool "jpeg (JPEG support)"
-	depends on BR2_PACKAGE_JPEG
+	select BR2_PACKAGE_JPEG
 	default y
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_OSS
@@ -139,6 +140,6 @@
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_PNG
 	bool "png (PNG support)"
-	depends on BR2_PACKAGE_LIBPNG
+	select BR2_PACKAGE_LIBPNG
 	default y
 endif

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[laird at uclibc.org]

Author: laird
Date: 2009-01-22 11:01:56 +0000 (Thu, 22 Jan 2009)
New Revision: 24960

Log:
package/multimedia/gst-plugins-good/Config.in
package/multimedia/gst-plugins-good/gst-plugins-good.mk

Always disable ESD
Move JPEG/PNG
Add BZIP2/ZLIB options as posted by Markus
Add LIBXML2 dependency for annodex

Signed-off-by: Daniel Laird <daniel.j.laird@nxp.com>



Modified:
   trunk/buildroot/package/multimedia/gst-plugins-good/Config.in
   trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk


Changeset:
Modified: trunk/buildroot/package/multimedia/gst-plugins-good/Config.in
===================================================================
--- trunk/buildroot/package/multimedia/gst-plugins-good/Config.in	2009-01-22 10:15:46 UTC (rev 24959)
+++ trunk/buildroot/package/multimedia/gst-plugins-good/Config.in	2009-01-22 11:01:56 UTC (rev 24960)
@@ -10,6 +10,30 @@
 
 if BR2_PACKAGE_GST_PLUGINS_GOOD
 
+config BR2_PACKAGE_GST_PLUGINS_GOOD_JPEG
+	bool "jpeg (JPEG support)"
+	select BR2_PACKAGE_JPEG
+
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PNG
+	bool "png (PNG support)"
+	select BR2_PACKAGE_LIBPNG
+
+config BR2_PACKAGE_GST_PLUGINS_GOOD_BZ2
+	bool "bz2 support"
+	depends on BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MATROSKA
+	select BR2_PACKAGE_BZIP2
+	help
+	  Enable bz2 support for the following plugins:
+	  matroska
+
+config BR2_PACKAGE_GST_PLUGINS_GOOD_ZLIB
+	bool "zlib support"
+	depends on BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_QTDEMUX || BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ID3DEMUX || BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MATROSKA
+	select BR2_PACKAGE_ZLIB
+	help
+	  Enable zlib support for the following plugins:
+	  id3demux, qtdemux, matroska
+
 comment "dependency-less plugins"
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_VIDEOFILTER
@@ -72,8 +96,6 @@
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MATROSKA
 	bool "matroska"
-	select BR2_PACKAGE_BZIP2
-	select BR2_PACKAGE_ZLIB
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MONOSCOPE
 	bool "monoscope"
@@ -121,25 +143,13 @@
 	bool "wavparse (*.wav audio)"
 	default y
 
-comment "plugins with external dependencies (more to come)"
+comment "plugins with external dependencies"
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ANNODEX
 	bool "annodex (XML Library)"
-	default y
+	select BR2_PACKAGE_LIBXML2
 
-config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ESD
-	bool "esdsink (ESounD sound daemon)"
-
-config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_JPEG
-	bool "jpeg (JPEG support)"
-	select BR2_PACKAGE_JPEG
-	default y
-
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_OSS
 	bool "ossaudio (OSS audio)"
 
-config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_PNG
-	bool "png (PNG support)"
-	select BR2_PACKAGE_LIBPNG
-	default y
 endif

Modified: trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk
===================================================================
--- trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk	2009-01-22 10:15:46 UTC (rev 24959)
+++ trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk	2009-01-22 11:01:56 UTC (rev 24960)
@@ -22,10 +22,39 @@
 		--disable-aalibtest \
 		--disable-esdtest \
 		--disable-shout2 \
-		--disable-shout2test
+		--disable-shout2test \
+		--disable-esd 
 
 GST_PLUGINS_GOOD_DEPENDENCIES = gstreamer gst-plugins-base
 
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_BZ2),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-bz2
+GST_PLUGINS_GOOD_DEPENDENCIES += bzip2
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-bz2
+endif
+
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_ZLIB),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-zlib
+GST_PLUGINS_GOOD_DEPENDENCIES += zlib
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-zlib
+endif
+
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_JPEG),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-jpeg
+GST_PLUGINS_GOOD_DEPENDENCIES += jpeg
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-jpeg
+endif
+
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PNG),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-png
+GST_PLUGINS_GOOD_DEPENDENCIES += libpng
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-png
+endif
+
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_VIDEOFILTER),y)
 GST_PLUGINS_GOOD_CONF_OPT += --enable-videofilter
 else
@@ -239,34 +268,15 @@
 
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ANNODEX),y)
 GST_PLUGINS_GOOD_CONF_OPT += --enable-annodex
+GST_PLUGINS_GOOD_DEPENDENCIES += libxml2
 else
 GST_PLUGINS_GOOD_CONF_OPT += --disable-annodex
 endif
 
-ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ESD),y)
-GST_PLUGINS_GOOD_CONF_OPT += --enable-esd
-else
-GST_PLUGINS_GOOD_CONF_OPT += --disable-esd
-endif
-
-ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_JPEG),y)
-GST_PLUGINS_GOOD_CONF_OPT += --enable-jpeg
-GST_PLUGINS_GOOD_DEPENDENCIES += jpeg
-else
-GST_PLUGINS_GOOD_CONF_OPT += --disable-jpeg
-endif
-
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_OSS),y)
 GST_PLUGINS_GOOD_CONF_OPT += --enable-oss
 else
 GST_PLUGINS_GOOD_CONF_OPT += --disable-oss
 endif
 
-ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_PNG),y)
-GST_PLUGINS_GOOD_CONF_OPT += --enable-png
-GST_PLUGINS_GOOD_DEPENDENCIES += libpng
-else
-GST_PLUGINS_GOOD_CONF_OPT += --disable-png
-endif
-
 $(eval $(call AUTOTARGETS,package/multimedia,gst-plugins-good))

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[Markus Heidelberg]

laird at uclibc.org, 22.01.2009:
> Author: laird
> Date: 2009-01-22 11:01:56 +0000 (Thu, 22 Jan 2009)
> New Revision: 24960
> 
> Log:
> package/multimedia/gst-plugins-good/Config.in
> package/multimedia/gst-plugins-good/gst-plugins-good.mk

It probably doesn't make sense to include the filenames in the commit
message, let alone full paths. The VCS knows them anyway.

> +ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PNG),y)
> +GST_PLUGINS_GOOD_CONF_OPT += --enable-png
> +GST_PLUGINS_GOOD_DEPENDENCIES += libpng
> +else
> +GST_PLUGINS_GOOD_CONF_OPT += --disable-png
> +endif

I just saw this in configure:
  --disable-libpng             disable Portable Network Graphics library: png

libpng instead of png


Also, please keep the order of the config options identically between
the files for Kconfig and Make.
In Config.in you have : jpeg, png, bz2, zlib
In gst-plugins-good.mk: bz2, zlib, jpeg, png

With this big amount of options, it could get distracting, when
extending the package or searching for bugs.

Markus

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[Peter Korsgaard]

>>>>> "Markus" == Markus Heidelberg <markus.heidelberg@web.de> writes:

 >> Log:
 >> package/multimedia/gst-plugins-good/Config.in
 >> package/multimedia/gst-plugins-good/gst-plugins-good.mk

 Markus> It probably doesn't make sense to include the filenames in the commit
 Markus> message, let alone full paths. The VCS knows them anyway.

I agree - It's good to prefix the commit message with what's it about
(E.G. gst-plugins-good:) to make it easy to find back (E.G. in gitk),
but not the individual file names.

 Markus> Also, please keep the order of the config options identically between
 Markus> the files for Kconfig and Make.
 Markus> In Config.in you have : jpeg, png, bz2, zlib
 Markus> In gst-plugins-good.mk: bz2, zlib, jpeg, png

 Markus> With this big amount of options, it could get distracting, when
 Markus> extending the package or searching for bugs.

Agree.

-- 
Bye, Peter Korsgaard

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[laird at uclibc.org]

Author: laird
Date: 2009-01-23 10:39:35 +0000 (Fri, 23 Jan 2009)
New Revision: 24979

Log:
gst-plugins-good: Fix style issues and use of --disable-png.

Update ordering and configure options.

Signed-off-by: Daniel Laird <daniel.j.laird@nxp.com>



Modified:
   trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk


Changeset:
Modified: trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk
===================================================================
--- trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk	2009-01-23 02:07:14 UTC (rev 24978)
+++ trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk	2009-01-23 10:39:35 UTC (rev 24979)
@@ -27,6 +27,20 @@
 
 GST_PLUGINS_GOOD_DEPENDENCIES = gstreamer gst-plugins-base
 
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_JPEG),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-jpeg
+GST_PLUGINS_GOOD_DEPENDENCIES += jpeg
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-jpeg
+endif
+
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PNG),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-libpng
+GST_PLUGINS_GOOD_DEPENDENCIES += libpng
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-libpng
+endif
+
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_BZ2),y)
 GST_PLUGINS_GOOD_CONF_OPT += --enable-bz2
 GST_PLUGINS_GOOD_DEPENDENCIES += bzip2
@@ -41,20 +55,6 @@
 GST_PLUGINS_GOOD_CONF_OPT += --disable-zlib
 endif
 
-ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_JPEG),y)
-GST_PLUGINS_GOOD_CONF_OPT += --enable-jpeg
-GST_PLUGINS_GOOD_DEPENDENCIES += jpeg
-else
-GST_PLUGINS_GOOD_CONF_OPT += --disable-jpeg
-endif
-
-ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PNG),y)
-GST_PLUGINS_GOOD_CONF_OPT += --enable-png
-GST_PLUGINS_GOOD_DEPENDENCIES += libpng
-else
-GST_PLUGINS_GOOD_CONF_OPT += --disable-png
-endif
-
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_VIDEOFILTER),y)
 GST_PLUGINS_GOOD_CONF_OPT += --enable-videofilter
 else

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[jacmet at uclibc.org]

Author: jacmet
Date: 2009-02-25 19:51:46 +0000 (Wed, 25 Feb 2009)
New Revision: 25456

Log:
gstreamer: flac plugin support

Patch by Sven Neumann. Closes #99.

Modified:
   trunk/buildroot/package/multimedia/gst-plugins-good/Config.in
   trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk


Changeset:
Modified: trunk/buildroot/package/multimedia/gst-plugins-good/Config.in
===================================================================
--- trunk/buildroot/package/multimedia/gst-plugins-good/Config.in	2009-02-25 19:51:41 UTC (rev 25455)
+++ trunk/buildroot/package/multimedia/gst-plugins-good/Config.in	2009-02-25 19:51:46 UTC (rev 25456)
@@ -149,6 +149,10 @@
 	bool "annodex (XML Library)"
 	select BR2_PACKAGE_LIBXML2
 
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_FLAC
+	bool "flac (libFLAC)"
+	select BR2_PACKAGE_FLAC
+
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_OSS
 	bool "ossaudio (OSS audio)"
 

Modified: trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk
===================================================================
--- trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk	2009-02-25 19:51:41 UTC (rev 25455)
+++ trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk	2009-02-25 19:51:46 UTC (rev 25456)
@@ -273,6 +273,12 @@
 GST_PLUGINS_GOOD_CONF_OPT += --disable-annodex
 endif
 
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_FLAC),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-flac
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-flac
+endif
+
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_OSS),y)
 GST_PLUGINS_GOOD_CONF_OPT += --enable-oss
 else

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[jacmet at uclibc.org]

Author: jacmet
Date: 2009-02-26 08:05:07 +0000 (Thu, 26 Feb 2009)
New Revision: 25457

Log:
gst-plugins-good: add missing FLAC dependency

Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>

Modified:
   trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk


Changeset:
Modified: trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk
===================================================================
--- trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk	2009-02-25 19:51:46 UTC (rev 25456)
+++ trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk	2009-02-26 08:05:07 UTC (rev 25457)
@@ -275,6 +275,7 @@
 
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_FLAC),y)
 GST_PLUGINS_GOOD_CONF_OPT += --enable-flac
+GST_PLUGINS_GOOD_DEPENDENCIES += flac
 else
 GST_PLUGINS_GOOD_CONF_OPT += --disable-flac
 endif

[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

[jacmet at uclibc.org]

Author: jacmet
Date: 2009-02-26 08:05:14 +0000 (Thu, 26 Feb 2009)
New Revision: 25458

Log:
gst-plugins-good: remove dependencies for matroska plugin

This was forgotten when adding config options for zlib and bzip2. The
matroska plugin doesn't need these dependencies, they are optional.

Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>

Modified:
   trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk


Changeset:
Modified: trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk
===================================================================
--- trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk	2009-02-26 08:05:07 UTC (rev 25457)
+++ trunk/buildroot/package/multimedia/gst-plugins-good/gst-plugins-good.mk	2009-02-26 08:05:14 UTC (rev 25458)
@@ -171,7 +171,6 @@
 
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MATROSKA),y)
 GST_PLUGINS_GOOD_CONF_OPT += --enable-matroska
-GST_PLUGINS_GOOD_DEPENDENCIES += zlib bzip2
 else
 GST_PLUGINS_GOOD_CONF_OPT += --disable-matroska
 endif