[Buildroot] [PATCH 0/4] package/libegl: introduce egl-wayland (branch yem/egl-wayland)

[Buildroot] [PATCH 0/4] package/libegl: introduce egl-wayland (branch yem/egl-wayland)

[Yann E. MORIN]

Hello All!

This series introduces support for EGL-wayland.

For Wayland, EGL implementations needs to provide a few specific
extensions so that Wayland servers and clients can easily exchange
surfaces, from a client to a server, so that the server can compose them
on screen, in a zero-copy fashion, but with the surfaces context (size,
depth...).

So far, the only such provider was mesa3d, so any package that needed
EGL with Wayland extensions would have to depend on mesa3d.

But nowadays, more and more EGL implementations do provide those
externsions. For example, the NVidia proprietary driver does. As well,
some non-public implementation may also provide them.

This series introduces a new option to the virtual package libegl,
libegl-wayland, that EGL prioviders that do implement those externsions
can state so, so that users of those externsions can properly depend on
it.

nvidia-driver is also bumped and made a provider of egl-wayland.

Regards,
Yann E. MORIN.


The following changes since commit 03f12377178e209f599f00b3fafb33dfa649abc7

  docs/manual: Document the variable $(PKG)_DL_OPTS (2016-08-23 14:59:01 +0200)


are available in the git repository at:

  git://git.buildroot.org/~ymorin/git/buildroot.git

for you to fetch changes up to 0addd1f1dd9b75f20f96877f05d8bdcc98b44533

  package/nvidia-driver: update version (2016-08-23 18:06:44 +0200)


----------------------------------------------------------------
Yann E. MORIN (4):
      package/libegl: add option for wayland extensions
      package/mesa3d: also implements the EGL wayland extensions
      package/libgtk3: needs OpenGL-EGL/wayland
      package/nvidia-driver: update version

 package/libgtk3/Config.in                    |   8 +-
 package/mesa3d/Config.in                     |   1 +
 package/nvidia-driver/0001-use-LDFLAGS.patch |  48 +++++++
 package/nvidia-driver/Config.in              |   6 +-
 package/nvidia-driver/nvidia-driver.hash     |   4 +-
 package/nvidia-driver/nvidia-driver.mk       | 206 ++++++++++++++-------------
 package/opengl/libegl/Config.in              |   4 +
 7 files changed, 171 insertions(+), 106 deletions(-)
 create mode 100644 package/nvidia-driver/0001-use-LDFLAGS.patch

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/4] package/libegl: add option for wayland extensions

[Yann E. MORIN]

Wayland requires that an OpenGL/EGL implementation provides a few
extensions, so that wayland servers and clients can exchange buffers.

Currently, only one OpenGL/EGL implementation provides those extensions:
mesa3d.

However, other implementations are catching up, especially the
proprietary NVidia driver, which has as of late introduced those
extensions. Other, non-public implementations may also provide those
extensions.

A lot of wayland-related packages require those extensions, and
currently they have to depend on mesa3d to provide OpenGL/EGL, which
precludes using those packages when a non-mesa3d provider is enabled,
even when that providers implements the necessary extensions.

Add an option to the libegl virtual package, that providers on
OpenGL/EGL can select to state they provide those extensions.

Pacakges that need those extensions can additionally depend on this new
option, instead of the existing libegl package.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/opengl/libegl/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/opengl/libegl/Config.in b/package/opengl/libegl/Config.in
index 8401bb2..f756fbe 100644
--- a/package/opengl/libegl/Config.in
+++ b/package/opengl/libegl/Config.in
@@ -1,6 +1,10 @@
 config BR2_PACKAGE_HAS_LIBEGL
 	bool
 
+config BR2_PACKAGE_HAS_LIBEGL_WAYLAND
+	bool
+	depends on BR2_PACKAGE_HAS_LIBEGL
+
 config BR2_PACKAGE_PROVIDES_LIBEGL
 	depends on BR2_PACKAGE_HAS_LIBEGL
 	string
-- 
2.7.4

[Buildroot] [PATCH 2/4] package/mesa3d: also implements the EGL wayland extensions

[Yann E. MORIN]

mesa3d implements the EGL extensions for wayland. State so.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/mesa3d/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index 45ca69c..6f60ee1 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -150,6 +150,7 @@ comment "Additional API Support"
 config BR2_PACKAGE_MESA3D_OPENGL_EGL
 	bool "OpenGL EGL"
 	select BR2_PACKAGE_HAS_LIBEGL
+	select BR2_PACKAGE_HAS_LIBEGL_WAYLAND
 	help
 	  Use the Khronos EGL APIs. EGL is a window manager for OpenGL applications
 	  similar to GLX, for X, and WGL, for Windows.
-- 
2.7.4

[Buildroot] [PATCH 3/4] package/libgtk3: needs OpenGL-EGL/wayland

[Yann E. MORIN]

Currently, libgtk3 depends on either a full OpenGL stack, or on a
OpenGL-EGL stack provided by mesa3d.

This is because, when using the wayland backend, libgtk3 needs an
OpenGL-EGL stack tht provides the wayland extensions. So far, only
mesa3d would provide those extensions.

But now, those extensions are trickling down to other implementations,
like the Nvidia driver or other (even non-public) implementations.

Change the condition to be on the recently introduced libegl-wayland
option.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/libgtk3/Config.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/libgtk3/Config.in b/package/libgtk3/Config.in
index 39105ac..2dd6dfa 100644
--- a/package/libgtk3/Config.in
+++ b/package/libgtk3/Config.in
@@ -4,10 +4,10 @@ comment "libgtk3 needs a toolchain w/ wchar, threads, C++"
 	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_TOOLCHAIN_HAS_THREADS
 
-comment "libgtk3 needs an OpenGL or OpenGL EGL backend provided by mesa3d"
+comment "libgtk3 needs an OpenGL or an OpenGL-EGL/wayland backend"
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
-	depends on !BR2_PACKAGE_MESA3D_OPENGL_EGL && \
+	depends on !BR2_PACKAGE_HAS_LIBEGL_WAYLAND && \
 		!BR2_PACKAGE_HAS_LIBGL
 
 config BR2_PACKAGE_LIBGTK3
@@ -29,7 +29,7 @@ config BR2_PACKAGE_LIBGTK3
 	depends on BR2_USE_MMU # glib2
 	depends on BR2_INSTALL_LIBSTDCPP # pango
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pango -> harfbuzz
-	depends on BR2_PACKAGE_MESA3D_OPENGL_EGL || \
+	depends on BR2_PACKAGE_HAS_LIBEGL_WAYLANDD || \
 		BR2_PACKAGE_HAS_LIBGL
 	help
 	  The GTK+ version 3 graphical user interface library
@@ -65,7 +65,7 @@ comment "Wayland GDK backend needs an OpenGL EGL backend provided by mesa3d w/ h
 config BR2_PACKAGE_LIBGTK3_WAYLAND
 	bool "Wayland GDK backend"
 	default y
-	depends on BR2_PACKAGE_MESA3D_OPENGL_EGL
+	depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17
 	select BR2_PACKAGE_WAYLAND
 	select BR2_PACKAGE_WAYLAND_PROTOCOLS
-- 
2.7.4

[Buildroot] [PATCH 4/4] package/nvidia-driver: update version

[Yann E. MORIN]

This new version brings in support for egl-wayland, the EGL extensions
aimed at making it possible to implement Wayland servers and clients. As
such, nvidia-driver becoms the seconf EGL implementation in Buildroot
that can act as a libegl provider with egl-wayland extensions.

In this version, it becomes possible to use our kernel-module infra,
with just a little few minor tricks: we need just specify the Linux
source and build trees (they are the same for us) and the list of
modules to build. We still need a little patch against the Kbuild files.

We also get rid of the LIBS_NO_VERSION trick and always use complete
filenames, as more libs are now packaged with different version in their
filenames, and even some with no version at all.

When installing libs, we switch from a shell loop to a make foreach
loop, which is easier to handle. It has the side-effect (and advantage)
of displyaing the install commands for each library, rather than a
single biggish one, so it is easier to see what goes wrong. This also
means that an error in each phase of the install (the copy of the files
then each symlink) can be caught more easily (it was not previously):
each sequence is now its own make command; we need not use "|| exit 1"
after each command, even in a if block, because the if blocks returns
with the exit code of the last command in it; e.g. if an ln fails, the
if-block in which it is enclosed will return the exit code of ln, and
make will catch it.

Similarly for the X driver modules and each of the programs installed:
we now can catch any failure in the isntall of those.

All of this somewhat simplifies the .mk. It is a little bit longer, but
the structure is saner and more explicit.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/nvidia-driver/0001-use-LDFLAGS.patch |  48 +++++++
 package/nvidia-driver/Config.in              |   6 +-
 package/nvidia-driver/nvidia-driver.hash     |   4 +-
 package/nvidia-driver/nvidia-driver.mk       | 206 ++++++++++++++-------------
 4 files changed, 162 insertions(+), 102 deletions(-)
 create mode 100644 package/nvidia-driver/0001-use-LDFLAGS.patch

diff --git a/package/nvidia-driver/0001-use-LDFLAGS.patch b/package/nvidia-driver/0001-use-LDFLAGS.patch
new file mode 100644
index 0000000..7b7df80
--- /dev/null
+++ b/package/nvidia-driver/0001-use-LDFLAGS.patch
@@ -0,0 +1,48 @@
+kernel: use LDFLAGS when linking modules
+
+Currently, linking module objects is simply using $(LD), assuming that
+the default emulation is correct for the current architecture.
+
+However, that might not be the case when the toolchain default is not
+the same as the current arch. For example, if the toolchain defaults to
+i386 and is capable of x86_64, and we're targetting x86_64 (or the
+opposite), the link would fail because the ld emulation is incorrect:
+
+    .../i686-pc-linux-gnu-ld: Relocatable linking with relocations from
+    format elf64-x86-64 (.../nvidia-driver-370.23/kernel/nvidia/nv-frontend.o)
+    to format elf32-i386 (.../nvidia-driver-370.23/kernel/nvidia/nv-interface.o)
+    is not supported
+
+Add use of $(LDFLAGS) when doing the link, as the kernel provides the
+proper emulation in those.
+
+Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
+
+---
+Issue reported upstream:
+    https://devtalk.nvidia.com/default/topic/958653/
+
+diff -durN nvidia-driver-370.23.orig/kernel/nvidia/nvidia.Kbuild nvidia-driver-370.23/kernel/nvidia/nvidia.Kbuild
+--- nvidia-driver-370.23.orig/kernel/nvidia/nvidia.Kbuild	2016-08-09 01:57:50.000000000 +0200
++++ nvidia-driver-370.23/kernel/nvidia/nvidia.Kbuild	2016-08-20 12:25:02.780233423 +0200
+@@ -87,7 +87,7 @@
+ always += $(NVIDIA_INTERFACE)
+ 
+ $(obj)/$(NVIDIA_INTERFACE): $(addprefix $(obj)/,$(NVIDIA_OBJECTS))
+-	$(LD) -r -o $@ $^
++	$(LD) $(LDFLAGS) -r -o $@ $^
+ 
+ 
+ #
+diff -durN nvidia-driver-370.23.orig/kernel/nvidia-modeset/nvidia-modeset.Kbuild nvidia-driver-370.23/kernel/nvidia-modeset/nvidia-modeset.Kbuild
+--- nvidia-driver-370.23.orig/kernel/nvidia-modeset/nvidia-modeset.Kbuild	2016-08-09 01:43:19.000000000 +0200
++++ nvidia-driver-370.23/kernel/nvidia-modeset/nvidia-modeset.Kbuild	2016-08-20 12:25:39.596772662 +0200
+@@ -70,7 +70,7 @@
+ always += $(NVIDIA_MODESET_INTERFACE)
+ 
+ $(obj)/$(NVIDIA_MODESET_INTERFACE): $(addprefix $(obj)/,$(NVIDIA_MODESET_OBJECTS))
+-	$(LD) -r -o $@ $^
++	$(LD) $(LDFLAGS) -r -o $@ $^
+ 
+ #
+ # Register the conftests needed by nvidia-modeset.ko
diff --git a/package/nvidia-driver/Config.in b/package/nvidia-driver/Config.in
index 04499f6..1105ec6 100644
--- a/package/nvidia-driver/Config.in
+++ b/package/nvidia-driver/Config.in
@@ -22,10 +22,11 @@ config BR2_PACKAGE_NVIDIA_DRIVER_XORG
 	default y
 	depends on BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR
 	select BR2_PACKAGE_MESA3D_HEADERS
-	select BR2_PACKAGE_XLIB_LIBX11
-	select BR2_PACKAGE_XLIB_LIBXEXT
+	select BR2_PACKAGE_XLIB_LIBX11 # runtime
+	select BR2_PACKAGE_XLIB_LIBXEXT # runtime
 	select BR2_PACKAGE_HAS_LIBGL
 	select BR2_PACKAGE_HAS_LIBEGL
+	select BR2_PACKAGE_HAS_LIBEGL_WAYLAND
 	select BR2_PACKAGE_HAS_LIBGLES
 
 if BR2_PACKAGE_NVIDIA_DRIVER_XORG
@@ -62,7 +63,6 @@ config BR2_PACKAGE_NVIDIA_DRIVER_OPENCL
 
 config BR2_PACKAGE_NVIDIA_DRIVER_CUDA_PROGS
 	bool "CUDA MPS server and control"
-	depends on BR2_x86_64
 	help
 	  Say 'y' here if you need to run more than one program
 	  doing CUDA at the same time. The MPS server will be
diff --git a/package/nvidia-driver/nvidia-driver.hash b/package/nvidia-driver/nvidia-driver.hash
index ba2f555..9427ffb 100644
--- a/package/nvidia-driver/nvidia-driver.hash
+++ b/package/nvidia-driver/nvidia-driver.hash
@@ -1,3 +1,3 @@
 # Locally computed
-sha256	d3a2842cbfb1163e20c658fbfaf5a235d5c9f035cd2d657f15df8a14b3fe80b1	NVIDIA-Linux-x86-358.16.run
-sha256	a942cdb29ed715ff1ce25beb06b6c2490126b98ef8bee5d9973967b557596bf2	NVIDIA-Linux-x86_64-358.16.run
+sha256  38cb22fa85ef74ea960d3e5d644838cd961984ffc32bb0d052414cc7fa32e315  NVIDIA-Linux-x86-367.35.run
+sha256  d2df3fcb1a145984b9de4f2f38a90e353469e9d12279cf5e2c67c553b112d075  NVIDIA-Linux-x86_64-367.35.run
diff --git a/package/nvidia-driver/nvidia-driver.mk b/package/nvidia-driver/nvidia-driver.mk
index 7e67020..c1fc986 100644
--- a/package/nvidia-driver/nvidia-driver.mk
+++ b/package/nvidia-driver/nvidia-driver.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-NVIDIA_DRIVER_VERSION = 358.16
+NVIDIA_DRIVER_VERSION = 367.35
 NVIDIA_DRIVER_SUFFIX = $(if $(BR2_x86_64),_64)
 NVIDIA_DRIVER_SITE = ftp://download.nvidia.com/XFree86/Linux-x86$(NVIDIA_DRIVER_SUFFIX)/$(NVIDIA_DRIVER_VERSION)
 NVIDIA_DRIVER_SOURCE = NVIDIA-Linux-x86$(NVIDIA_DRIVER_SUFFIX)-$(NVIDIA_DRIVER_VERSION).run
@@ -20,25 +20,56 @@ ifeq ($(BR2_PACKAGE_NVIDIA_DRIVER_XORG),y)
 # are build dependencies of packages that depend on nvidia-driver, so
 # they should be built prior to those packages, and the only simple
 # way to do so is to make nvidia-driver depend on them.
-NVIDIA_DRIVER_DEPENDENCIES = mesa3d-headers xlib_libX11 xlib_libXext
+NVIDIA_DRIVER_DEPENDENCIES = mesa3d-headers
 NVIDIA_DRIVER_PROVIDES = libgl libegl libgles
 
-# We have two variables that contains a list of libraries to install:
-#   NVIDIA_DRIVER_LIBS
-#       contains the libraries whose filename end up in .so.$(VERSION); rather
-#       than duplicate the version string for all of them, we just store their
-#       basename, and append the version string below.
-#   NVIDIA_DRIVER_LIBS_NO_VERSION
-#       contains all libraries the do not use the NVidia version; since there
-#       is currently only one such library, we store its full name.
-
-# Each line corresponds to a specific set of libraries
+# libGL.so.$(NVIDIA_DRIVER_VERSION) is the legacy libGL.so library; it
+# has been replaced with libGL.so.1.0.0. Installing both is technically
+# possible, but great care must be taken to ensure they do not conflict,
+# so that EGL still works. The legacy library exposes an NVidia-specific
+# API, so it should not be needed, except for legacy, binary-only
+# applications (in other words: we don't care).
+#
+# libGL.so.1.0.0 is the new vendor-neutral library, aimed at replacing
+# the old libGL.so.$(NVIDIA_DRIVER_VERSION) library. The latter contains
+# NVidia extensions (which is deemed bad now), while the former follows
+# the newly-introduced vendor-neutral "dispatching" API/ABI:
+#   https://github.com/aritger/linux-opengl-abi-proposal/blob/master/linux-opengl-abi-proposal.txt
+# However, this is not very usefull to us, as we don't support multiple
+# GL providers at the same time on the system, which this proposal is
+# aimed at supporting.
+#
+# So we only install the legacy library for now.
+NVIDIA_DRIVER_LIBS_GL = \
+	libGLX.so.0 \
+	libGL.so.$(NVIDIA_DRIVER_VERSION) \
+	libGLX_nvidia.so.$(NVIDIA_DRIVER_VERSION) \
+
+NVIDIA_DRIVER_LIBS_EGL = \
+	libEGL.so.1 \
+	libGLdispatch.so.0 \
+	libEGL_nvidia.so.$(NVIDIA_DRIVER_VERSION) \
+
+NVIDIA_DRIVER_LIBS_GLES = \
+	libGLESv1_CM.so.1 \
+	libGLESv2.so.2 \
+	libGLESv1_CM_nvidia.so.$(NVIDIA_DRIVER_VERSION) \
+	libGLESv2_nvidia.so.$(NVIDIA_DRIVER_VERSION) \
+
+NVIDIA_DRIVER_LIBS_MISC = \
+	libnvidia-eglcore.so.$(NVIDIA_DRIVER_VERSION) \
+	libnvidia-egl-wayland.so.$(NVIDIA_DRIVER_VERSION) \
+	libnvidia-glcore.so.$(NVIDIA_DRIVER_VERSION) \
+	libnvidia-glsi.so.$(NVIDIA_DRIVER_VERSION) \
+	tls/libnvidia-tls.so.$(NVIDIA_DRIVER_VERSION) \
+	libvdpau_nvidia.so.$(NVIDIA_DRIVER_VERSION) \
+	libnvidia-ml.so.$(NVIDIA_DRIVER_VERSION) \
+
 NVIDIA_DRIVER_LIBS = \
-	libEGL libGLESv1_CM libGLESv2 libGL \
-	libnvidia-glcore libnvidia-eglcore libnvidia-glsi \
-	tls/libnvidia-tls \
-	libvdpau libvdpau_nvidia \
-	libnvidia-ml
+	$(NVIDIA_DRIVER_LIBS_GL) \
+	$(NVIDIA_DRIVER_LIBS_EGL) \
+	$(NVIDIA_DRIVER_LIBS_GLES) \
+	$(NVIDIA_DRIVER_LIBS_MISC) \
 
 # Install the gl.pc file
 define NVIDIA_DRIVER_INSTALL_GL_DEV
@@ -54,110 +85,91 @@ endef
 # on using those libraries (e.g. if the user has such an agreement, or
 # wants to run a third-party program developped under such an agreement).
 ifeq ($(BR2_PACKAGE_NVIDIA_DRIVER_PRIVATE_LIBS),y)
-NVIDIA_DRIVER_LIBS += libnvidia-ifr libnvidia-fbc
+NVIDIA_DRIVER_LIBS += \
+	libnvidia-ifr.so.$(NVIDIA_DRIVER_VERSION) \
+	libnvidia-fbc.so.$(NVIDIA_DRIVER_VERSION)
 endif
 
 # We refer to the destination path; the origin file has no directory component
-NVIDIA_DRIVER_X_MODS = drivers/nvidia_drv.so \
+NVIDIA_DRIVER_X_MODS = \
+	drivers/nvidia_drv.so \
 	extensions/libglx.so.$(NVIDIA_DRIVER_VERSION) \
 	libnvidia-wfb.so.$(NVIDIA_DRIVER_VERSION)
 
 endif # X drivers
 
 ifeq ($(BR2_PACKAGE_NVIDIA_DRIVER_CUDA),y)
-NVIDIA_DRIVER_LIBS += libcuda libnvidia-compiler libnvcuvid libnvidia-encode
+NVIDIA_DRIVER_LIBS += \
+	libcuda.so.$(NVIDIA_DRIVER_VERSION) \
+	libnvidia-compiler.so.$(NVIDIA_DRIVER_VERSION) \
+	libnvcuvid.so.$(NVIDIA_DRIVER_VERSION) \
+	libnvidia-fatbinaryloader.so.$(NVIDIA_DRIVER_VERSION) \
+	libnvidia-ptxjitcompiler.so.$(NVIDIA_DRIVER_VERSION) \
+	libnvidia-encode.so.$(NVIDIA_DRIVER_VERSION)
 ifeq ($(BR2_PACKAGE_NVIDIA_DRIVER_CUDA_PROGS),y)
 NVIDIA_DRIVER_PROGS = nvidia-cuda-mps-control nvidia-cuda-mps-server
 endif
 endif
 
 ifeq ($(BR2_PACKAGE_NVIDIA_DRIVER_OPENCL),y)
-NVIDIA_DRIVER_LIBS_NO_VERSION += libOpenCL.so.1.0.0
-NVIDIA_DRIVER_LIBS += libnvidia-opencl
+NVIDIA_DRIVER_LIBS += \
+	libOpenCL.so.1.0.0 \
+	libnvidia-opencl.so.$(NVIDIA_DRIVER_VERSION)
 endif
 
+# Build and install the kernel modules if needed
+ifeq ($(BR2_PACKAGE_NVIDIA_DRIVER_MODULE),y)
+
+NVIDIA_DRIVER_MODULES = nvidia nvidia-modeset nvidia-drm
+ifeq ($(BR2_x86_64),y)
+NVIDIA_DRIVER_MODULES += nvidia-uvm
+endif
+
+# They can't do everything like everyone. They need those variables,
+# because they don't recognise the usual variables set by the kernel
+# build system. We also need to tell them what modules to build.
+NVIDIA_DRIVER_MODULE_MAKE_OPTS = \
+	NV_KERNEL_SOURCES="$(LINUX_DIR)" \
+	NV_KERNEL_OUTPUT="$(LINUX_DIR)" \
+	NV_KERNEL_MODULES="$(NVIDIA_DRIVER_MODULES)"
+
+NVIDIA_DRIVER_MODULE_SUBDIRS = kernel
+
+$(eval $(kernel-module))
+
+endif # BR2_PACKAGE_NVIDIA_DRIVER_MODULE == y
+
 # The downloaded archive is in fact an auto-extract script. So, it can run
 # virtually everywhere, and it is fine enough to provide useful options.
 # Except it can't extract into an existing (even empty) directory.
 define NVIDIA_DRIVER_EXTRACT_CMDS
 	$(SHELL) $(DL_DIR)/$(NVIDIA_DRIVER_SOURCE) --extract-only --target \
 		$(@D)/tmp-extract
+	chmod u+w -R $(@D)
 	mv $(@D)/tmp-extract/* $(@D)/tmp-extract/.manifest $(@D)
 	rm -rf $(@D)/tmp-extract
 endef
 
-# Build and install the kernel modules if needed
-ifeq ($(BR2_PACKAGE_NVIDIA_DRIVER_MODULE),y)
-
-NVIDIA_DRIVER_DEPENDENCIES += linux
-
-# NVidia uses the legacy naming scheme for the x86 architecture, when i386
-# and x86_64 were still considered two separate architectures in the Linux
-# kernel.
-NVIDIA_DRIVER_ARCH = $(if $(BR2_i386),i386,$(BR2_ARCH))
-
-NVIDIA_DRIVER_MOD_DIRS = kernel
-NVIDIA_DRIVER_MOD_FILES = kernel/nvidia.ko
-# nvidia-uvm.ko only available for x86_64
-ifeq ($(BR2_x86_64)$(BR2_PACKAGE_NVIDIA_DRIVER_CUDA),yy)
-NVIDIA_DRIVER_MOD_DIRS += kernel/uvm
-NVIDIA_DRIVER_MOD_FILES += kernel/uvm/nvidia-uvm.ko
-endif
-
-# We can not use '$(MAKE) -C $(@D)/$${dir}' because NVidia's uses its own
-# Makefile to build a kernel module, which includes a lot of assumptions
-# on where to find its own sub-Makefile fragments, and fails if make is
-# not run from the directory where the module's source files are. Hence
-# our little trick to cd in there first.
-# That's also the reason why we do not use LINUX_MAKE_FLAGS or the other
-# linux-specific variables, since NVidia's Makefile does not understand
-# them.
-define NVIDIA_DRIVER_BUILD_CMDS
-	for dir in $(NVIDIA_DRIVER_MOD_DIRS); do \
-		(cd $(@D)/$${dir} && \
-		  $(MAKE) SYSSRC="$(LINUX_DIR)" SYSOUT="$(LINUX_DIR)" \
-				CC="$(TARGET_CC)" LD="$(TARGET_LD)" HOSTCC="$(HOSTCC)" \
-				ARCH=$(NVIDIA_DRIVER_ARCH) module) || exit 1; \
-	done
-endef
-
-# We do not use module-install because NVidia's Makefile requires root.
-# Also, we do not install it in the expected location (in nvidia/ rather
-# than in kernel/drivers/video/)
-define NVIDIA_DRIVER_INSTALL_KERNEL_MODULE
-	for mod in $(NVIDIA_DRIVER_MOD_FILES); do \
-		$(INSTALL) -D -m 0644 $(@D)/$${mod} \
-			$(TARGET_DIR)/lib/modules/$(LINUX_VERSION_PROBED)/nvidia/$${mod##*/} \
-		|| exit 1; \
-	done
-	$(HOST_DIR)/sbin/depmod -a -b $(TARGET_DIR) $(LINUX_VERSION_PROBED)
-endef
-
-endif # BR2_PACKAGE_NVIDIA_DRIVER_MODULE == y
-
 # Helper to install libraries
 # $1: destination directory (target or staging)
 #
-# For all libraries that need it, we append the NVidia version string.
-# Then for all libraries, we install them and create a symlink using
-# their SONAME, so we can link to them at runtime; we also create the
-# no-version symlink, so we can link to them at build time.
+# For all libraries, we install them and create a symlink using
+# their SONAME, so we can link to them at runtime; we also create
+# the no-version symlink, so we can link to them at build time.
 define NVIDIA_DRIVER_INSTALL_LIBS
-	for libpath in $(addsuffix .so.$(NVIDIA_DRIVER_VERSION),$(NVIDIA_DRIVER_LIBS)) \
-		$(NVIDIA_DRIVER_LIBS_NO_VERSION); \
-	do \
-		libname="$${libpath##*/}"; \
-		$(INSTALL) -D -m 0644 $(@D)/$${libpath} $(1)/usr/lib/$${libname}; \
-		libsoname="$$( $(TARGET_READELF) -d "$(@D)/$${libpath}" \
+	$(foreach lib,$(NVIDIA_DRIVER_LIBS),\
+		$(INSTALL) -D -m 0644 $(@D)/$(lib) $(1)/usr/lib/$(notdir $(lib))
+		libsoname="$$( $(TARGET_READELF) -d "$(@D)/$(lib)" \
 		       |sed -r -e '/.*\(SONAME\).*\[(.*)\]$$/!d; s//\1/;' )"; \
-		if [ -n "$${libsoname}" -a "$${libsoname}" != "$${libname}" ]; then \
-			ln -sf $${libname} $(1)/usr/lib/$${libsoname}; \
-		fi; \
-		baseso="$${libname/.so*}.so"; \
-		if [ -n "$${baseso}" -a "$${baseso}" != "$${libname}" ]; then \
-			ln -sf $${libname} $(1)/usr/lib/$${baseso}; \
-		fi; \
-	done
+		if [ -n "$${libsoname}" -a "$${libsoname}" != "$(notdir $(lib))" ]; then \
+			ln -sf $(notdir $(lib)) \
+				$(1)/usr/lib/$${libsoname}; \
+		fi
+		baseso=$(firstword $(subst .,$(space),$(notdir $(lib)))).so; \
+		if [ -n "$${baseso}" -a "$${baseso}" != "$(notdir $(lib))" ]; then \
+			ln -sf $(notdir $(lib)) $(1)/usr/lib/$${baseso}; \
+		fi
+	)
 endef
 
 # For staging, install libraries and development files
@@ -169,14 +181,14 @@ endef
 # For target, install libraries and X.org modules
 define NVIDIA_DRIVER_INSTALL_TARGET_CMDS
 	$(call NVIDIA_DRIVER_INSTALL_LIBS,$(TARGET_DIR))
-	for m in $(NVIDIA_DRIVER_X_MODS); do \
-		$(INSTALL) -D -m 0644 $(@D)/$${m##*/} \
-			$(TARGET_DIR)/usr/lib/xorg/modules/$${m}; \
-	done
-	for p in $(NVIDIA_DRIVER_PROGS); do \
-		$(INSTALL) -D -m 0755 $(@D)/$${p} \
-			$(TARGET_DIR)/usr/bin/$${p}; \
-	done
+	$(foreach m,$(NVIDIA_DRIVER_X_MODS), \
+		$(INSTALL) -D -m 0644 $(@D)/$(notdir $(m)) \
+			$(TARGET_DIR)/usr/lib/xorg/modules/$(m)
+	)
+	$(foreach p,$(NVIDIA_DRIVER_PROGS), \
+		$(INSTALL) -D -m 0755 $(@D)/$(p) \
+			$(TARGET_DIR)/usr/bin/$(p)
+	)
 	$(NVIDIA_DRIVER_INSTALL_KERNEL_MODULE)
 endef
 
-- 
2.7.4

[Buildroot] [PATCH 1/4] package/libegl: add option for wayland extensions

[Thomas Petazzoni]

Hello,

On Tue, 23 Aug 2016 18:26:32 +0200, Yann E. MORIN wrote:
> Wayland requires that an OpenGL/EGL implementation provides a few
> extensions, so that wayland servers and clients can exchange buffers.
> 
> Currently, only one OpenGL/EGL implementation provides those extensions:
> mesa3d.
> 
> However, other implementations are catching up, especially the
> proprietary NVidia driver, which has as of late introduced those
> extensions. Other, non-public implementations may also provide those
> extensions.
> 
> A lot of wayland-related packages require those extensions, and
> currently they have to depend on mesa3d to provide OpenGL/EGL, which
> precludes using those packages when a non-mesa3d provider is enabled,
> even when that providers implements the necessary extensions.
> 
> Add an option to the libegl virtual package, that providers on
> OpenGL/EGL can select to state they provide those extensions.
> 
> Pacakges that need those extensions can additionally depend on this new
> option, instead of the existing libegl package.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  package/opengl/libegl/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to next, thanks.

One thing that surprises me though is that weston itself doesn't use
this new option, and still has:

config BR2_PACKAGE_WESTON_DRM
        bool "DRM compositor"
        depends on BR2_PACKAGE_MESA3D_OPENGL_EGL
        select BR2_PACKAGE_LIBDRM
        select BR2_PACKAGE_WESTON_HAS_COMPOSITOR

# Uses libgbm from mesa3d
comment "DRM compositor needs an OpenGL EGL backend provided by mesa3d"
        depends on !BR2_PACKAGE_MESA3D_OPENGL_EGL

So it's weird to have a new OpenGL implementation that is said to be
Wayland capable, but doesn't allow to build the reference Wayland
implementation.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 2/4] package/mesa3d: also implements the EGL wayland extensions

[Thomas Petazzoni]

Hello,

On Tue, 23 Aug 2016 18:26:33 +0200, Yann E. MORIN wrote:
> mesa3d implements the EGL extensions for wayland. State so.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  package/mesa3d/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Applied to next, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 3/4] package/libgtk3: needs OpenGL-EGL/wayland

[Thomas Petazzoni]

Hello,

On Tue, 23 Aug 2016 18:26:34 +0200, Yann E. MORIN wrote:
> Currently, libgtk3 depends on either a full OpenGL stack, or on a
> OpenGL-EGL stack provided by mesa3d.
> 
> This is because, when using the wayland backend, libgtk3 needs an
> OpenGL-EGL stack tht provides the wayland extensions. So far, only
> mesa3d would provide those extensions.
> 
> But now, those extensions are trickling down to other implementations,
> like the Nvidia driver or other (even non-public) implementations.
> 
> Change the condition to be on the recently introduced libegl-wayland
> option.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  package/libgtk3/Config.in | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied to next, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/4] package/libegl: add option for wayland extensions

[Yann E. MORIN]

Thomas, All,

On 2016-08-23 22:02 +0200, Thomas Petazzoni spake thusly:
> On Tue, 23 Aug 2016 18:26:32 +0200, Yann E. MORIN wrote:
> > Wayland requires that an OpenGL/EGL implementation provides a few
> > extensions, so that wayland servers and clients can exchange buffers.
> > 
> > Currently, only one OpenGL/EGL implementation provides those extensions:
> > mesa3d.
> > 
> > However, other implementations are catching up, especially the
> > proprietary NVidia driver, which has as of late introduced those
> > extensions. Other, non-public implementations may also provide those
> > extensions.
> > 
> > A lot of wayland-related packages require those extensions, and
> > currently they have to depend on mesa3d to provide OpenGL/EGL, which
> > precludes using those packages when a non-mesa3d provider is enabled,
> > even when that providers implements the necessary extensions.
> > 
> > Add an option to the libegl virtual package, that providers on
> > OpenGL/EGL can select to state they provide those extensions.
> > 
> > Pacakges that need those extensions can additionally depend on this new
> > option, instead of the existing libegl package.
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> >  package/opengl/libegl/Config.in | 4 ++++
> >  1 file changed, 4 insertions(+)
> 
> Applied to next, thanks.
> 
> One thing that surprises me though is that weston itself doesn't use
> this new option, and still has:
> 
> config BR2_PACKAGE_WESTON_DRM
>         bool "DRM compositor"
>         depends on BR2_PACKAGE_MESA3D_OPENGL_EGL
>         select BR2_PACKAGE_LIBDRM
>         select BR2_PACKAGE_WESTON_HAS_COMPOSITOR
> 
> # Uses libgbm from mesa3d
> comment "DRM compositor needs an OpenGL EGL backend provided by mesa3d"
>         depends on !BR2_PACKAGE_MESA3D_OPENGL_EGL
> 
> So it's weird to have a new OpenGL implementation that is said to be
> Wayland capable, but doesn't allow to build the reference Wayland
> implementation.

That's because not everything was converted. Yet.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/4] package/libegl: add option for wayland extensions

[Thomas Petazzoni]

Hello,

On Tue, 23 Aug 2016 23:43:51 +0200, Yann E. MORIN wrote:

> > One thing that surprises me though is that weston itself doesn't use
> > this new option, and still has:
> > 
> > config BR2_PACKAGE_WESTON_DRM
> >         bool "DRM compositor"
> >         depends on BR2_PACKAGE_MESA3D_OPENGL_EGL
> >         select BR2_PACKAGE_LIBDRM
> >         select BR2_PACKAGE_WESTON_HAS_COMPOSITOR
> > 
> > # Uses libgbm from mesa3d
> > comment "DRM compositor needs an OpenGL EGL backend provided by mesa3d"
> >         depends on !BR2_PACKAGE_MESA3D_OPENGL_EGL
> > 
> > So it's weird to have a new OpenGL implementation that is said to be
> > Wayland capable, but doesn't allow to build the reference Wayland
> > implementation.  
> 
> That's because not everything was converted. Yet.

OK, this is definitely a good explanation. So I should take it that you
expect Weston to build and work with the latest version of the NVidia
driver?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 1/4] package/libegl: add option for wayland extensions

[Yann E. MORIN]

Thomas, All,

On 2016-08-23 23:58 +0200, Thomas Petazzoni spake thusly:
> On Tue, 23 Aug 2016 23:43:51 +0200, Yann E. MORIN wrote:
> 
> > > One thing that surprises me though is that weston itself doesn't use
> > > this new option, and still has:
> > > 
> > > config BR2_PACKAGE_WESTON_DRM
> > >         bool "DRM compositor"
> > >         depends on BR2_PACKAGE_MESA3D_OPENGL_EGL
> > >         select BR2_PACKAGE_LIBDRM
> > >         select BR2_PACKAGE_WESTON_HAS_COMPOSITOR
> > > 
> > > # Uses libgbm from mesa3d
> > > comment "DRM compositor needs an OpenGL EGL backend provided by mesa3d"
> > >         depends on !BR2_PACKAGE_MESA3D_OPENGL_EGL
> > > 
> > > So it's weird to have a new OpenGL implementation that is said to be
> > > Wayland capable, but doesn't allow to build the reference Wayland
> > > implementation.  
> > 
> > That's because not everything was converted. Yet.
> 
> OK, this is definitely a good explanation. So I should take it that you
> expect Weston to build and work with the latest version of the NVidia
> driver?

Eventually. Eventually... ;-)

To be honest, this is not my highest priority for 2016.11; I have multi
br2-external and systemd skeleton to handle first.

This quick egl-wayland series (which I did not expect would be applied
so fast!) was just a little distraction along the way. ;-) But at least,
it paves the way toward more egl-wayland providers and users.

As for Weston and the DRM compositor, I guess Gustavo did with what we
had at the time... And I'm not totally up-to-speed with all the
complexity of the graphics stack...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/4] package/libegl: add option for wayland extensions

[Thomas Petazzoni]

Hello,

On Wed, 24 Aug 2016 00:06:12 +0200, Yann E. MORIN wrote:

> > OK, this is definitely a good explanation. So I should take it that you
> > expect Weston to build and work with the latest version of the NVidia
> > driver?  
> 
> Eventually. Eventually... ;-)
> 
> To be honest, this is not my highest priority for 2016.11; I have multi
> br2-external and systemd skeleton to handle first.

Sure, makes perfect. I was certainly not asking for this to be *done*,
but more on what is the general direction we are going to.

> This quick egl-wayland series (which I did not expect would be applied
> so fast!) was just a little distraction along the way. ;-) But at least,
> it paves the way toward more egl-wayland providers and users.

Sure. IMO it also makes the libgtk3 dependency a little bit easier to
understand, which is also why I applied it quickly.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 4/4] package/nvidia-driver: update version

[Thomas Petazzoni]

Hello,

On Tue, 23 Aug 2016 18:26:35 +0200, Yann E. MORIN wrote:
> This new version brings in support for egl-wayland, the EGL extensions
> aimed at making it possible to implement Wayland servers and clients. As
> such, nvidia-driver becoms the seconf EGL implementation in Buildroot
> that can act as a libegl provider with egl-wayland extensions.
> 
> In this version, it becomes possible to use our kernel-module infra,
> with just a little few minor tricks: we need just specify the Linux
> source and build trees (they are the same for us) and the list of
> modules to build. We still need a little patch against the Kbuild files.
> 
> We also get rid of the LIBS_NO_VERSION trick and always use complete
> filenames, as more libs are now packaged with different version in their
> filenames, and even some with no version at all.
> 
> When installing libs, we switch from a shell loop to a make foreach
> loop, which is easier to handle. It has the side-effect (and advantage)
> of displyaing the install commands for each library, rather than a
> single biggish one, so it is easier to see what goes wrong. This also
> means that an error in each phase of the install (the copy of the files
> then each symlink) can be caught more easily (it was not previously):
> each sequence is now its own make command; we need not use "|| exit 1"
> after each command, even in a if block, because the if blocks returns
> with the exit code of the last command in it; e.g. if an ln fails, the
> if-block in which it is enclosed will return the exit code of ln, and
> make will catch it.
> 
> Similarly for the X driver modules and each of the programs installed:
> we now can catch any failure in the isntall of those.
> 
> All of this somewhat simplifies the .mk. It is a little bit longer, but
> the structure is saner and more explicit.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  package/nvidia-driver/0001-use-LDFLAGS.patch |  48 +++++++
>  package/nvidia-driver/Config.in              |   6 +-
>  package/nvidia-driver/nvidia-driver.hash     |   4 +-
>  package/nvidia-driver/nvidia-driver.mk       | 206 ++++++++++++++-------------
>  4 files changed, 162 insertions(+), 102 deletions(-)
>  create mode 100644 package/nvidia-driver/0001-use-LDFLAGS.patch

I just fixed a few minor typos in the commit log, and applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com