Re: [Buildroot] [PATCH 1/7] package/opensc: new package

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: "José Pekkarinen" <jose.pekkarinen@unikie.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/7] package/opensc: new package
Date: Fri, 10 Dec 2021 18:06:23 +0100	[thread overview]
Message-ID: <20211210170623.GH2603@scaer> (raw)
In-Reply-To: <23c2c119-b051-ddff-877f-34a34c51b0ac@benettiengineering.com>

Giulio, All,

On 2021-12-10 15:49 +0100, Giulio Benetti spake thusly:
> On 10/12/21 15:12, José Pekkarinen wrote:
> >The patch will add a basic opensc package to build
> >on buildroot.
[--SNIP--]
> >diff --git a/package/opensc/opensc.mk b/package/opensc/opensc.mk
> >new file mode 100644
> >index 0000000000..7221eee944
> >--- /dev/null
> >+++ b/package/opensc/opensc.mk
> >@@ -0,0 +1,14 @@
> >+################################################################################
> >+#
> >+# opensc
> >+#
> >+################################################################################
> >+
> >+OPENSC_VERSION = 0.22.0
> >+OPENSC_SITE = https://github.com/OpenSC/OpenSC/releases/download/$(OPENSC_VERSION)
> Please use github wrapper ^^^

Actually, no. The github helper is only to download arbitrary hashes and
tags, where the archives are generated on the fly by Github.

In the case of opensc, there are actual releases, which were uploaded to
Gihub by the opensc maintainer, and so this is the archive we want to
use, not the autogenerated one.

> >+OPENSC_LICENSE = LGPL-2.1+
> >+OPENSC_LICENSE_FILES = COPYING
> >+OPENSC_DEPENDENCIES = openssl pcsc-lite
> >+OPENSC_INSTALL_STAGING = YES
> Do we need to install to staging?

OpenSC installs at least one library, libopensc, so presumably, yes, we
need to install in staging...

Regards,
Yann E. MORIN.

> >+
> >+$(eval $(autotools-package))
> >
> 
> Best regards
> -- 
> Giulio Benetti
> Benetti Engineering sas
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot