Re: [Buildroot] [PATCH 3/7] package/bmx7: new package

From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "José Pekkarinen" <jose.pekkarinen@unikie.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 3/7] package/bmx7: new package
Date: Wed, 5 Jan 2022 23:23:48 +0100	[thread overview]
Message-ID: <20220105232348.68986536@windsurf> (raw)
In-Reply-To: <20211210141209.1812043-3-jose.pekkarinen@unikie.com>

Hello José,

On Fri, 10 Dec 2021 16:12:05 +0200
José Pekkarinen <jose.pekkarinen@unikie.com> wrote:

> This patch will provide an initial package
> for bmx7 project.
> 
> Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>

I have applied this patch, with a few changes (see below). But I must
say I hesitated. Do you really use this? This project has not seen any
updates since July 2019, there is a simple pull request fixing the
SIOCGSTAMP issue that has never been looked at, and there are
alternatives such as olsr and batman-adv which are actively maintained.

Also, gcc generates tons and tons of warnings, which is quite worrying,
as gcc tends to become more and more strict, and upstream is no longer
active.

So I've applied, but I really hesitated.

> diff --git a/package/bmx7/Config.in b/package/bmx7/Config.in
> new file mode 100644
> index 0000000000..3c13c047e9
> --- /dev/null
> +++ b/package/bmx7/Config.in
> @@ -0,0 +1,16 @@
> +config BR2_PACKAGE_BMX7
> +	bool "bmx7"
> +	depends on !BR2_STATIC_LIBS # dlopen()
> +	select BR2_PACKAGE_ZLIB
> +	select BR2_PACKAGE_LIBZLIB

I dropped that, and tested it builds fine with zlib-ng.

> +BMX7_VERSION = v7.1.1
> +BMX7_SOURCE = $(BMX7_VERSION).tar.gz
> +BMX7_SITE = https://github.com/bmx-routing/bmx7/archive/refs/tags

Changed that to use the github macro that we have in Buildroot.

> +BMX7_LICENSE = GPL-2

Changed to GPL-2.0.

> +BMX7_LICENSE_FILES = LICENSE
> +BMX7_DEPENDENCIES = zlib mbedtls wireless_tools
> +
> +define BMX7_BUILD_CMDS
> +	(cd $(@D); \
> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/$(d)/src CC="$(TARGET_CC)")

Changed to:

        $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/$(d)/src

I.e, not need to cd into $(@D), and then using $(TARGET_CONFIGURE_OPTS)
to pass all variables, not just CC.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot