Re: [Buildroot] [PATCH 1/7] package/opensc: new package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

José, All,

On 2021-12-10 15:32 +0100, Giulio Benetti spake thusly:
> > Il giorno 10 dic 2021, alle ore 15:12, José Pekkarinen <jose.pekkarinen@unikie.com> ha scritto:
> > 
> > The patch will add a basic opensc package to build
> > on buildroot.
> 
> Please as pointed previously reword like this:
> “This patch adds opensc package”

Yes, please use the present form.

Additionally, we like that the commit log explains the packaging, like
the reason for the patches for example.

> > Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>
> > ---
[--SNIP--]
> > diff --git a/package/opensc/0001-Fix-maybe-uninitialized-errors.patch b/package/opensc/0001-Fix-maybe-uninitialized-errors.patch
> > new file mode 100644
> > index 0000000000..17ef43a984
> > --- /dev/null
> > +++ b/package/opensc/0001-Fix-maybe-uninitialized-errors.patch
> > @@ -0,0 +1,81 @@
> > +From b74a624f21db3bfd45e0cb6ed017ceda9f29adfc Mon Sep 17 00:00:00 2001
> > +From: =?UTF-8?q?Jos=C3=A9=20Pekkarinen?= <jose.pekkarinen@unikie.com>
> > +Date: Fri, 10 Dec 2021 13:54:26 +0200
> > +Subject: [PATCH] Fix maybe uninitialized errors
> > +MIME-Version: 1.0
> > +Content-Type: text/plain; charset=UTF-8
> > +Content-Transfer-Encoding: 8bit
> > +
> 
> Here commit log is missing. In the case it is trivial, please repeat the summary in the commit log body, like:
> “Fix maybe uninitialized errors”

Also, please submit those changes upstream; if that's already done, then
add an URL to the upstream PR/MR. If this is is a backport, then say so
and point to the upstream commit (b74a624f21db3bfd45e0cb6ed017ceda9f29adfc
does not appear to be an upstream commit).

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot