Re: [Buildroot] [PATCH 5/7] package/aexpect: new package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Arnout, José, All,

On 2021-12-11 09:43 +0100, Arnout Vandecappelle spake thusly:
> On 10/12/2021 21:11, Yann E. MORIN wrote:
> >José, All,
> >
> >On 2021-12-10 16:12 +0200, José Pekkarinen spake thusly:
> >>Add package to avocado framework's aexpect.
> >>
> >>Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>
> >[--SNIP--]
> >>diff --git a/package/aexpect/Config.in b/package/aexpect/Config.in
> >>new file mode 100644
> >>index 0000000000..efa2be8b91
> >>--- /dev/null
> >>+++ b/package/aexpect/Config.in
> >>@@ -0,0 +1,12 @@
> >>+config BR2_PACKAGE_AEXPECT
> >>+	bool "aexpect"
> >>+	depends on !BR2_STATIC_LIBS # dlopen()
> >>+	select BR2_PACKAGE_PYTHON
> >
> >Do not select python, depend on it.
> 
>  Why not? Currently we have the following packages that select python(3):
> cifs-utils, docker-compose, dstat, glslsandbox-player, gpsd, jack2,
> libsigrokdecode, midori, opkg-utils, ranger.

None selects python (aka python2, which is what I implied when writing
'python'):

    $ git grep -E 'select BR2_PACKAGE_PYTHON\>'
    [none, naught, nix, zilch]

Yes, they do however select python3.

And since we do want to get rid of python (aka python2), it would be
very disapointing to introduce a new package that is python2-only, or
that inconsiderately selects it.

>  Actually, ranger is a great example: it's also a tool that is just a tool
> and just happens to be implemented in python. So select is appropriate, like
> we do for any tool that happens to be implemented in Go, Rust, ...
> 
>  However, note that you need either
> 
> 	select BR2_PACKAGE_PYTHON3 if !BR2_PACKAGE_PYTHON
> or
> 	depends on !BR2_PACKAGE_PYTHON
> 	select BR2_PACKAGE_PYTHON3

Yes, this is what should be done.

But definitely do not select python (aka python2).

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot