Re: [Buildroot] [PATCH 3/7] package/bmx7: new package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

José, All,

On 2021-12-10 16:12 +0200, José Pekkarinen spake thusly:
> This patch will provide an initial package
> for bmx7 project.
> 
> Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>
[--SNIP--]
> diff --git a/package/bmx7/Config.in b/package/bmx7/Config.in
> new file mode 100644
> index 0000000000..3c13c047e9
> --- /dev/null
> +++ b/package/bmx7/Config.in
> @@ -0,0 +1,16 @@
> +config BR2_PACKAGE_BMX7
> +	bool "bmx7"
> +	depends on !BR2_STATIC_LIBS # dlopen()
> +	select BR2_PACKAGE_ZLIB
> +	select BR2_PACKAGE_LIBZLIB

You can't select BR2_PACKAGE_LIBZLIB, because it is an entry of a
choice.

If your package can work with any zlib, then selecting BR2_PACKAGE_ZLIB
as you did is enough. But if your package really require the original
zlib, then you must depend on BR2_PACKAGE_LIBZLIB (and not select
BR2_PACKAGE_ZLIB).

[--SNIP--]
> diff --git a/package/bmx7/bmx7.mk b/package/bmx7/bmx7.mk
> new file mode 100644
> index 0000000000..58b0044aec
> --- /dev/null
> +++ b/package/bmx7/bmx7.mk
> @@ -0,0 +1,23 @@
> +################################################################################
> +#
> +# bmx7
> +#
> +################################################################################
> +
> +BMX7_VERSION = v7.1.1
> +BMX7_SOURCE = $(BMX7_VERSION).tar.gz
> +BMX7_SITE = https://github.com/bmx-routing/bmx7/archive/refs/tags
> +BMX7_LICENSE = GPL-2
> +BMX7_LICENSE_FILES = LICENSE
> +BMX7_DEPENDENCIES = zlib mbedtls wireless_tools
> +
> +define BMX7_BUILD_CMDS
> +	(cd $(@D); \
> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/$(d)/src CC="$(TARGET_CC)")

Again, no need for the enclosing parentheses.

Regards,
Yann E. MORIN.

> +endef
> +
> +define BMX7_INSTALL_TARGET_CMDS
> +	$(INSTALL) -m 0755 -D $(@D)/src/bmx7 $(TARGET_DIR)/usr/bin/bmx7
> +endef
> +
> +$(eval $(generic-package))
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot