* [Buildroot] [PATCH] package/qt5: fix build failure due to libressl use @ 2022-09-28 20:24 Giulio Benetti 2022-09-28 20:55 ` Yann E. MORIN 0 siblings, 1 reply; 10+ messages in thread From: Giulio Benetti @ 2022-09-28 20:24 UTC (permalink / raw) To: buildroot; +Cc: Giulio Benetti, Julien Corjon Qt5 only supports openssl, check [0] and [1]. So in qt5base.mk let's check if BR2_PACKAGE_LIBOPENSSL is enabled instead of BR2_PACKAGE_OPENSSL(that could be openssl or libressl) and for qt5enginio and qt5webkit let's select specifically BR2_PACKAGE_LIBOPENSSL instead of only BR2_PACKAGE_OPENSSL. This way we make sure that only openssl is selected and not libressl or other future openssl-like implementations. Fixes: http://autobuild.buildroot.net/results/a956b48b782dbaa055d7146360465e2493a809d9/ [0]: https://doc.qt.io/qt-5/ssl.html#enabling-and-disabling-ssl-support [1]: https://bugreports.qt.io/browse/QTBUG-68374 Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- package/qt5/qt5base/qt5base.mk | 4 ++-- package/qt5/qt5enginio/Config.in | 1 + package/qt5/qt5webkit/Config.in | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk index a81892422c..efa0e16e9a 100644 --- a/package/qt5/qt5base/qt5base.mk +++ b/package/qt5/qt5base/qt5base.mk @@ -229,8 +229,8 @@ else QT5BASE_CONFIGURE_OPTS += -no-eglfs endif -QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_OPENSSL),-openssl,-no-openssl) -QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_OPENSSL),openssl) +QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_LIBOPENSSL),-openssl,-no-openssl) +QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBOPENSSL),openssl) QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_QT5BASE_FONTCONFIG),-fontconfig,-no-fontconfig) QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_QT5BASE_FONTCONFIG),fontconfig) diff --git a/package/qt5/qt5enginio/Config.in b/package/qt5/qt5enginio/Config.in index b738f0db7c..d421972392 100644 --- a/package/qt5/qt5enginio/Config.in +++ b/package/qt5/qt5enginio/Config.in @@ -1,6 +1,7 @@ config BR2_PACKAGE_QT5ENGINIO bool "qt5enginio" select BR2_PACKAGE_OPENSSL + select BR2_PACKAGE_LIBOPENSSL # Only openssl is supported by qt5 select BR2_PACKAGE_QT5BASE_GUI select BR2_PACKAGE_QT5BASE_NETWORK help diff --git a/package/qt5/qt5webkit/Config.in b/package/qt5/qt5webkit/Config.in index 26c3897d1d..035e8b19b8 100644 --- a/package/qt5/qt5webkit/Config.in +++ b/package/qt5/qt5webkit/Config.in @@ -16,6 +16,7 @@ config BR2_PACKAGE_QT5WEBKIT select BR2_PACKAGE_LEVELDB select BR2_PACKAGE_LIBPNG select BR2_PACKAGE_OPENSSL + select BR2_PACKAGE_LIBOPENSSL # Only openssl is supported by qt5 select BR2_PACKAGE_QT5BASE_ICU select BR2_PACKAGE_QT5BASE_GUI select BR2_PACKAGE_QT5BASE_WIDGETS -- 2.34.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH] package/qt5: fix build failure due to libressl use 2022-09-28 20:24 [Buildroot] [PATCH] package/qt5: fix build failure due to libressl use Giulio Benetti @ 2022-09-28 20:55 ` Yann E. MORIN 2022-09-28 21:25 ` Giulio Benetti ` (2 more replies) 0 siblings, 3 replies; 10+ messages in thread From: Yann E. MORIN @ 2022-09-28 20:55 UTC (permalink / raw) To: Giulio Benetti; +Cc: Julien Corjon, buildroot Giulio, All, On 2022-09-28 22:24 +0200, Giulio Benetti spake thusly: > Qt5 only supports openssl, check [0] and [1]. So in qt5base.mk let's check > if BR2_PACKAGE_LIBOPENSSL is enabled instead of BR2_PACKAGE_OPENSSL(that > could be openssl or libressl) and for qt5enginio and qt5webkit let's select > specifically BR2_PACKAGE_LIBOPENSSL instead of only BR2_PACKAGE_OPENSSL. > This way we make sure that only openssl is selected and not libressl or > other future openssl-like implementations. > > Fixes: > http://autobuild.buildroot.net/results/a956b48b782dbaa055d7146360465e2493a809d9/ > > [0]: https://doc.qt.io/qt-5/ssl.html#enabling-and-disabling-ssl-support > [1]: https://bugreports.qt.io/browse/QTBUG-68374 > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > package/qt5/qt5base/qt5base.mk | 4 ++-- > package/qt5/qt5enginio/Config.in | 1 + > package/qt5/qt5webkit/Config.in | 1 + > 3 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk > index a81892422c..efa0e16e9a 100644 > --- a/package/qt5/qt5base/qt5base.mk > +++ b/package/qt5/qt5base/qt5base.mk > @@ -229,8 +229,8 @@ else > QT5BASE_CONFIGURE_OPTS += -no-eglfs > endif > > -QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_OPENSSL),-openssl,-no-openssl) > -QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_OPENSSL),openssl) > +QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_LIBOPENSSL),-openssl,-no-openssl) > +QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBOPENSSL),openssl) > > QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_QT5BASE_FONTCONFIG),-fontconfig,-no-fontconfig) > QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_QT5BASE_FONTCONFIG),fontconfig) > diff --git a/package/qt5/qt5enginio/Config.in b/package/qt5/qt5enginio/Config.in > index b738f0db7c..d421972392 100644 > --- a/package/qt5/qt5enginio/Config.in > +++ b/package/qt5/qt5enginio/Config.in > @@ -1,6 +1,7 @@ > config BR2_PACKAGE_QT5ENGINIO > bool "qt5enginio" > select BR2_PACKAGE_OPENSSL > + select BR2_PACKAGE_LIBOPENSSL # Only openssl is supported by qt5 BR2_PACKAGE_LIBOPENSSL is part of a choice, so you can't select it. However, you can achieve the same with: select BR2_PACKAGE_OPENSSL select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL By the way, we have a single package, gitlab-runner, that selects BR2_PACKAGE_LIBOPENSSL, so this should be fixed. Regards, Yann E. MORIN. > select BR2_PACKAGE_QT5BASE_GUI > select BR2_PACKAGE_QT5BASE_NETWORK > help > diff --git a/package/qt5/qt5webkit/Config.in b/package/qt5/qt5webkit/Config.in > index 26c3897d1d..035e8b19b8 100644 > --- a/package/qt5/qt5webkit/Config.in > +++ b/package/qt5/qt5webkit/Config.in > @@ -16,6 +16,7 @@ config BR2_PACKAGE_QT5WEBKIT > select BR2_PACKAGE_LEVELDB > select BR2_PACKAGE_LIBPNG > select BR2_PACKAGE_OPENSSL > + select BR2_PACKAGE_LIBOPENSSL # Only openssl is supported by qt5 > select BR2_PACKAGE_QT5BASE_ICU > select BR2_PACKAGE_QT5BASE_GUI > select BR2_PACKAGE_QT5BASE_WIDGETS > -- > 2.34.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH] package/qt5: fix build failure due to libressl use 2022-09-28 20:55 ` Yann E. MORIN @ 2022-09-28 21:25 ` Giulio Benetti 2022-09-29 10:46 ` [Buildroot] [PATCH v2] " Giulio Benetti 2022-09-29 11:18 ` [Buildroot] [PATCH] package/gitlab-runner: fix forcing openssl Giulio Benetti 2 siblings, 0 replies; 10+ messages in thread From: Giulio Benetti @ 2022-09-28 21:25 UTC (permalink / raw) To: Yann E. MORIN; +Cc: Julien Corjon, buildroot Hi Yann, > Il giorno 28 set 2022, alle ore 22:55, Yann E. MORIN <yann.morin.1998@free.fr> ha scritto: > > Giulio, All, > > On 2022-09-28 22:24 +0200, Giulio Benetti spake thusly: >> Qt5 only supports openssl, check [0] and [1]. So in qt5base.mk let's check >> if BR2_PACKAGE_LIBOPENSSL is enabled instead of BR2_PACKAGE_OPENSSL(that >> could be openssl or libressl) and for qt5enginio and qt5webkit let's select >> specifically BR2_PACKAGE_LIBOPENSSL instead of only BR2_PACKAGE_OPENSSL. >> This way we make sure that only openssl is selected and not libressl or >> other future openssl-like implementations. >> >> Fixes: >> http://autobuild.buildroot.net/results/a956b48b782dbaa055d7146360465e2493a809d9/ >> >> [0]: https://doc.qt.io/qt-5/ssl.html#enabling-and-disabling-ssl-support >> [1]: https://bugreports.qt.io/browse/QTBUG-68374 >> >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >> --- >> package/qt5/qt5base/qt5base.mk | 4 ++-- >> package/qt5/qt5enginio/Config.in | 1 + >> package/qt5/qt5webkit/Config.in | 1 + >> 3 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk >> index a81892422c..efa0e16e9a 100644 >> --- a/package/qt5/qt5base/qt5base.mk >> +++ b/package/qt5/qt5base/qt5base.mk >> @@ -229,8 +229,8 @@ else >> QT5BASE_CONFIGURE_OPTS += -no-eglfs >> endif >> >> -QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_OPENSSL),-openssl,-no-openssl) >> -QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_OPENSSL),openssl) >> +QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_LIBOPENSSL),-openssl,-no-openssl) >> +QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBOPENSSL),openssl) >> >> QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_QT5BASE_FONTCONFIG),-fontconfig,-no-fontconfig) >> QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_QT5BASE_FONTCONFIG),fontconfig) >> diff --git a/package/qt5/qt5enginio/Config.in b/package/qt5/qt5enginio/Config.in >> index b738f0db7c..d421972392 100644 >> --- a/package/qt5/qt5enginio/Config.in >> +++ b/package/qt5/qt5enginio/Config.in >> @@ -1,6 +1,7 @@ >> config BR2_PACKAGE_QT5ENGINIO >> bool "qt5enginio" >> select BR2_PACKAGE_OPENSSL >> + select BR2_PACKAGE_LIBOPENSSL # Only openssl is supported by qt5 > > BR2_PACKAGE_LIBOPENSSL is part of a choice, so you can't select it. > > However, you can achieve the same with: > select BR2_PACKAGE_OPENSSL > select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL Thanks for pointing, I was not 100% sure of my approach. > > By the way, we have a single package, gitlab-runner, that selects > BR2_PACKAGE_LIBOPENSSL, so this should be fixed. Ok, I’ll create a patch for it too tomorrow then. Best regards Giulio > > Regards, > Yann E. MORIN. > >> select BR2_PACKAGE_QT5BASE_GUI >> select BR2_PACKAGE_QT5BASE_NETWORK >> help >> diff --git a/package/qt5/qt5webkit/Config.in b/package/qt5/qt5webkit/Config.in >> index 26c3897d1d..035e8b19b8 100644 >> --- a/package/qt5/qt5webkit/Config.in >> +++ b/package/qt5/qt5webkit/Config.in >> @@ -16,6 +16,7 @@ config BR2_PACKAGE_QT5WEBKIT >> select BR2_PACKAGE_LEVELDB >> select BR2_PACKAGE_LIBPNG >> select BR2_PACKAGE_OPENSSL >> + select BR2_PACKAGE_LIBOPENSSL # Only openssl is supported by qt5 >> select BR2_PACKAGE_QT5BASE_ICU >> select BR2_PACKAGE_QT5BASE_GUI >> select BR2_PACKAGE_QT5BASE_WIDGETS >> -- >> 2.34.1 >> >> _______________________________________________ >> buildroot mailing list >> buildroot@buildroot.org >> https://lists.buildroot.org/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2] package/qt5: fix build failure due to libressl use 2022-09-28 20:55 ` Yann E. MORIN 2022-09-28 21:25 ` Giulio Benetti @ 2022-09-29 10:46 ` Giulio Benetti 2023-02-06 22:45 ` Thomas Petazzoni via buildroot 2022-09-29 11:18 ` [Buildroot] [PATCH] package/gitlab-runner: fix forcing openssl Giulio Benetti 2 siblings, 1 reply; 10+ messages in thread From: Giulio Benetti @ 2022-09-29 10:46 UTC (permalink / raw) To: buildroot; +Cc: Giulio Benetti, Julien Corjon, Yann E . MORIN Qt5 only supports openssl, check [0] and [1]. So in qt5base.mk let's check if BR2_PACKAGE_LIBOPENSSL is enabled instead of BR2_PACKAGE_OPENSSL(that could be openssl or libressl) and for qt5enginio and qt5webkit let's select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL instead of only BR2_PACKAGE_OPENSSL. This way we make sure that only openssl is selected and not libressl or other future openssl-like implementations. Fixes: http://autobuild.buildroot.net/results/a956b48b782dbaa055d7146360465e2493a809d9/ [0]: https://doc.qt.io/qt-5/ssl.html#enabling-and-disabling-ssl-support [1]: https://bugreports.qt.io/browse/QTBUG-68374 Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- V1->V2: * select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL instead of BR2_PACKAGE_LIBOPENSSL --- package/qt5/qt5base/qt5base.mk | 4 ++-- package/qt5/qt5enginio/Config.in | 1 + package/qt5/qt5webkit/Config.in | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk index a81892422c..efa0e16e9a 100644 --- a/package/qt5/qt5base/qt5base.mk +++ b/package/qt5/qt5base/qt5base.mk @@ -229,8 +229,8 @@ else QT5BASE_CONFIGURE_OPTS += -no-eglfs endif -QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_OPENSSL),-openssl,-no-openssl) -QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_OPENSSL),openssl) +QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_LIBOPENSSL),-openssl,-no-openssl) +QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBOPENSSL),openssl) QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_QT5BASE_FONTCONFIG),-fontconfig,-no-fontconfig) QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_QT5BASE_FONTCONFIG),fontconfig) diff --git a/package/qt5/qt5enginio/Config.in b/package/qt5/qt5enginio/Config.in index b738f0db7c..f758548eb5 100644 --- a/package/qt5/qt5enginio/Config.in +++ b/package/qt5/qt5enginio/Config.in @@ -1,6 +1,7 @@ config BR2_PACKAGE_QT5ENGINIO bool "qt5enginio" select BR2_PACKAGE_OPENSSL + select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL # Only openssl is supported by qt5 select BR2_PACKAGE_QT5BASE_GUI select BR2_PACKAGE_QT5BASE_NETWORK help diff --git a/package/qt5/qt5webkit/Config.in b/package/qt5/qt5webkit/Config.in index 26c3897d1d..e52374550c 100644 --- a/package/qt5/qt5webkit/Config.in +++ b/package/qt5/qt5webkit/Config.in @@ -16,6 +16,7 @@ config BR2_PACKAGE_QT5WEBKIT select BR2_PACKAGE_LEVELDB select BR2_PACKAGE_LIBPNG select BR2_PACKAGE_OPENSSL + select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL # Only openssl is supported by qt5 select BR2_PACKAGE_QT5BASE_ICU select BR2_PACKAGE_QT5BASE_GUI select BR2_PACKAGE_QT5BASE_WIDGETS -- 2.34.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v2] package/qt5: fix build failure due to libressl use 2022-09-29 10:46 ` [Buildroot] [PATCH v2] " Giulio Benetti @ 2023-02-06 22:45 ` Thomas Petazzoni via buildroot 2023-02-22 19:52 ` Peter Korsgaard 0 siblings, 1 reply; 10+ messages in thread From: Thomas Petazzoni via buildroot @ 2023-02-06 22:45 UTC (permalink / raw) To: Giulio Benetti; +Cc: Julien Corjon, Yann E . MORIN, buildroot On Thu, 29 Sep 2022 12:46:48 +0200 Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > Qt5 only supports openssl, check [0] and [1]. So in qt5base.mk let's check > if BR2_PACKAGE_LIBOPENSSL is enabled instead of BR2_PACKAGE_OPENSSL(that > could be openssl or libressl) and for qt5enginio and qt5webkit let's select > BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL instead of only BR2_PACKAGE_OPENSSL. > This way we make sure that only openssl is selected and not libressl or > other future openssl-like implementations. > > Fixes: > http://autobuild.buildroot.net/results/a956b48b782dbaa055d7146360465e2493a809d9/ > > [0]: https://doc.qt.io/qt-5/ssl.html#enabling-and-disabling-ssl-support > [1]: https://bugreports.qt.io/browse/QTBUG-68374 > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > V1->V2: > * select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL instead of BR2_PACKAGE_LIBOPENSSL > --- > package/qt5/qt5base/qt5base.mk | 4 ++-- > package/qt5/qt5enginio/Config.in | 1 + > package/qt5/qt5webkit/Config.in | 1 + > 3 files changed, 4 insertions(+), 2 deletions(-) Applied to master, thanks. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v2] package/qt5: fix build failure due to libressl use 2023-02-06 22:45 ` Thomas Petazzoni via buildroot @ 2023-02-22 19:52 ` Peter Korsgaard 0 siblings, 0 replies; 10+ messages in thread From: Peter Korsgaard @ 2023-02-22 19:52 UTC (permalink / raw) To: Thomas Petazzoni via buildroot Cc: Giulio Benetti, Julien Corjon, Thomas Petazzoni, Yann E . MORIN >>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes: > On Thu, 29 Sep 2022 12:46:48 +0200 > Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: >> Qt5 only supports openssl, check [0] and [1]. So in qt5base.mk let's check >> if BR2_PACKAGE_LIBOPENSSL is enabled instead of BR2_PACKAGE_OPENSSL(that >> could be openssl or libressl) and for qt5enginio and qt5webkit let's select >> BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL instead of only BR2_PACKAGE_OPENSSL. >> This way we make sure that only openssl is selected and not libressl or >> other future openssl-like implementations. >> >> Fixes: >> http://autobuild.buildroot.net/results/a956b48b782dbaa055d7146360465e2493a809d9/ >> >> [0]: https://doc.qt.io/qt-5/ssl.html#enabling-and-disabling-ssl-support >> [1]: https://bugreports.qt.io/browse/QTBUG-68374 >> >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >> --- V1-> V2: >> * select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL instead of BR2_PACKAGE_LIBOPENSSL >> --- >> package/qt5/qt5base/qt5base.mk | 4 ++-- >> package/qt5/qt5enginio/Config.in | 1 + >> package/qt5/qt5webkit/Config.in | 1 + >> 3 files changed, 4 insertions(+), 2 deletions(-) > Applied to master, thanks. Committed to 2022.11.x and 2022.02.x, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH] package/gitlab-runner: fix forcing openssl 2022-09-28 20:55 ` Yann E. MORIN 2022-09-28 21:25 ` Giulio Benetti 2022-09-29 10:46 ` [Buildroot] [PATCH v2] " Giulio Benetti @ 2022-09-29 11:18 ` Giulio Benetti 2022-09-29 11:20 ` Giulio Benetti 2022-10-01 16:29 ` Yann E. MORIN 2 siblings, 2 replies; 10+ messages in thread From: Giulio Benetti @ 2022-09-29 11:18 UTC (permalink / raw) To: buildroot; +Cc: Giulio Benetti, Romain Naour, Marcin Niestroj, Yann E . MORIN BR2_PACKAGE_LIBOPENSSL doesn't force selecting libopenssl, to achieve this we need to use BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL. So let's modify accordingly and improve a bit the comment. Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- package/gitlab-runner/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/gitlab-runner/Config.in b/package/gitlab-runner/Config.in index 72c2742562..bfa79ac80e 100644 --- a/package/gitlab-runner/Config.in +++ b/package/gitlab-runner/Config.in @@ -13,7 +13,7 @@ config BR2_PACKAGE_GITLAB_RUNNER select BR2_PACKAGE_LIBCURL_CURL # runtime select BR2_PACKAGE_LIBCURL_OPENSSL # runtime, for ca-certificates. select BR2_PACKAGE_OPENSSL # runtime - select BR2_PACKAGE_LIBOPENSSL # runtime + select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL # runtime, force using libopenssl select BR2_PACKAGE_LIBOPENSSL_BIN # runtime select BR2_PACKAGE_TAR # runtime help -- 2.34.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH] package/gitlab-runner: fix forcing openssl 2022-09-29 11:18 ` [Buildroot] [PATCH] package/gitlab-runner: fix forcing openssl Giulio Benetti @ 2022-09-29 11:20 ` Giulio Benetti 2022-10-01 16:30 ` Yann E. MORIN 2022-10-01 16:29 ` Yann E. MORIN 1 sibling, 1 reply; 10+ messages in thread From: Giulio Benetti @ 2022-09-29 11:20 UTC (permalink / raw) To: buildroot; +Cc: Romain Naour, Marcin Niestroj, Yann E . MORIN Forgotten, On 29/09/22 13:18, Giulio Benetti wrote: > BR2_PACKAGE_LIBOPENSSL doesn't force selecting libopenssl, to achieve this > we need to use BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL. So let's modify > accordingly and improve a bit the comment. > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Suggested-by: Yann E. MORIN <yann.morin.1998@free.fr> -- Giulio Benetti CEO/CTO@Benetti Engineering sas > --- > package/gitlab-runner/Config.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/gitlab-runner/Config.in b/package/gitlab-runner/Config.in > index 72c2742562..bfa79ac80e 100644 > --- a/package/gitlab-runner/Config.in > +++ b/package/gitlab-runner/Config.in > @@ -13,7 +13,7 @@ config BR2_PACKAGE_GITLAB_RUNNER > select BR2_PACKAGE_LIBCURL_CURL # runtime > select BR2_PACKAGE_LIBCURL_OPENSSL # runtime, for ca-certificates. > select BR2_PACKAGE_OPENSSL # runtime > - select BR2_PACKAGE_LIBOPENSSL # runtime > + select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL # runtime, force using libopenssl > select BR2_PACKAGE_LIBOPENSSL_BIN # runtime > select BR2_PACKAGE_TAR # runtime > help _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH] package/gitlab-runner: fix forcing openssl 2022-09-29 11:20 ` Giulio Benetti @ 2022-10-01 16:30 ` Yann E. MORIN 0 siblings, 0 replies; 10+ messages in thread From: Yann E. MORIN @ 2022-10-01 16:30 UTC (permalink / raw) To: Giulio Benetti; +Cc: Romain Naour, Marcin Niestroj, buildroot Giulio, All, On 2022-09-29 13:20 +0200, Giulio Benetti spake thusly: > Forgotten, > > On 29/09/22 13:18, Giulio Benetti wrote: > >BR2_PACKAGE_LIBOPENSSL doesn't force selecting libopenssl, to achieve this > >we need to use BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL. So let's modify > >accordingly and improve a bit the comment. > > > >Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > > Suggested-by: Yann E. MORIN <yann.morin.1998@free.fr> Thanks, I added that, but as a Reported-by tag, because that's a bug that I reported. Regards, Yann E. MORIN. > -- > Giulio Benetti > CEO/CTO@Benetti Engineering sas > > >--- > > package/gitlab-runner/Config.in | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/package/gitlab-runner/Config.in b/package/gitlab-runner/Config.in > >index 72c2742562..bfa79ac80e 100644 > >--- a/package/gitlab-runner/Config.in > >+++ b/package/gitlab-runner/Config.in > >@@ -13,7 +13,7 @@ config BR2_PACKAGE_GITLAB_RUNNER > > select BR2_PACKAGE_LIBCURL_CURL # runtime > > select BR2_PACKAGE_LIBCURL_OPENSSL # runtime, for ca-certificates. > > select BR2_PACKAGE_OPENSSL # runtime > >- select BR2_PACKAGE_LIBOPENSSL # runtime > >+ select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL # runtime, force using libopenssl > > select BR2_PACKAGE_LIBOPENSSL_BIN # runtime > > select BR2_PACKAGE_TAR # runtime > > help > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH] package/gitlab-runner: fix forcing openssl 2022-09-29 11:18 ` [Buildroot] [PATCH] package/gitlab-runner: fix forcing openssl Giulio Benetti 2022-09-29 11:20 ` Giulio Benetti @ 2022-10-01 16:29 ` Yann E. MORIN 1 sibling, 0 replies; 10+ messages in thread From: Yann E. MORIN @ 2022-10-01 16:29 UTC (permalink / raw) To: Giulio Benetti; +Cc: Romain Naour, Marcin Niestroj, buildroot Giulio, All, On 2022-09-29 13:18 +0200, Giulio Benetti spake thusly: > BR2_PACKAGE_LIBOPENSSL doesn't force selecting libopenssl, to achieve this > we need to use BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL. So let's modify > accordingly and improve a bit the comment. I've reworded the commit log, and drop the comment change: the symbol name is explicit enough as to what it does. > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Applied to master, thanks. Regards, Yann E. MORIN. > --- > package/gitlab-runner/Config.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/gitlab-runner/Config.in b/package/gitlab-runner/Config.in > index 72c2742562..bfa79ac80e 100644 > --- a/package/gitlab-runner/Config.in > +++ b/package/gitlab-runner/Config.in > @@ -13,7 +13,7 @@ config BR2_PACKAGE_GITLAB_RUNNER > select BR2_PACKAGE_LIBCURL_CURL # runtime > select BR2_PACKAGE_LIBCURL_OPENSSL # runtime, for ca-certificates. > select BR2_PACKAGE_OPENSSL # runtime > - select BR2_PACKAGE_LIBOPENSSL # runtime > + select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL # runtime, force using libopenssl > select BR2_PACKAGE_LIBOPENSSL_BIN # runtime > select BR2_PACKAGE_TAR # runtime > help > -- > 2.34.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-02-22 19:52 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-09-28 20:24 [Buildroot] [PATCH] package/qt5: fix build failure due to libressl use Giulio Benetti 2022-09-28 20:55 ` Yann E. MORIN 2022-09-28 21:25 ` Giulio Benetti 2022-09-29 10:46 ` [Buildroot] [PATCH v2] " Giulio Benetti 2023-02-06 22:45 ` Thomas Petazzoni via buildroot 2023-02-22 19:52 ` Peter Korsgaard 2022-09-29 11:18 ` [Buildroot] [PATCH] package/gitlab-runner: fix forcing openssl Giulio Benetti 2022-09-29 11:20 ` Giulio Benetti 2022-10-01 16:30 ` Yann E. MORIN 2022-10-01 16:29 ` Yann E. MORIN
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox