Re: [Buildroot] [PATCH 1/1] package/pkg-generic.mk: fix typo in make target .stamp_built

["Yann E. MORIN" <yann.morin.1998@free.fr>]

On 2023-08-18 22:03 +0200, Thomas Petazzoni via buildroot spake thusly:
> On Fri, 18 Aug 2023 17:16:08 +0200
> Bernd Kuhls <bernd@kuhls.net> wrote:
> 
> > This fix can be backported because the offending line was added in 2009.

What is actualy broken?

As you noticed, the does has been there for moer than 14 years now, so
if something obvious was broken, we'd have notriced by now.

So, if this is broken, it is not obvious, and we need to udnerstand how
it is broken and why the fix is correct.

Regards,
Yann E. MORIN.

> > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> > ---
> >  package/pkg-generic.mk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> > index 5d1c1da128..9d40754939 100644
> > --- a/package/pkg-generic.mk
> > +++ b/package/pkg-generic.mk
> > @@ -286,7 +286,7 @@ $(BUILD_DIR)/%/.stamp_configured:
> >  	$(Q)touch $@
> >  
> >  # Build
> > -$(BUILD_DIR)/%/.stamp_built::
> > +$(BUILD_DIR)/%/.stamp_built:
> 
> Note that double colon rules have a specific meaning in make:
> 
>   https://www.gnu.org/software/make/manual/html_node/Double_002dColon.html
> 
> I've read a few times the page, but I'm not sure I fully grasp what it
> says, so I don't know if the double colon was intended (and needed at
> the time) or was a typo.
> 
> Thomas
> -- 
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot