From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Bernd Kuhls <bernd@kuhls.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/pkg-generic.mk: fix typo in make target .stamp_built
Date: Fri, 18 Aug 2023 22:44:29 +0200 [thread overview]
Message-ID: <20230818224429.618b7dd1@windsurf> (raw)
In-Reply-To: <20230818202434.GA1134940@scaer>
On Fri, 18 Aug 2023 22:24:34 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> On 2023-08-18 22:03 +0200, Thomas Petazzoni via buildroot spake thusly:
> > On Fri, 18 Aug 2023 17:16:08 +0200
> > Bernd Kuhls <bernd@kuhls.net> wrote:
> >
> > > This fix can be backported because the offending line was added in 2009.
>
> What is actualy broken?
>
> As you noticed, the does has been there for moer than 14 years now, so
> if something obvious was broken, we'd have notriced by now.
>
> So, if this is broken, it is not obvious, and we need to udnerstand how
> it is broken and why the fix is correct.
I don't think Bernd claimed anywhere that something is broken. He
claims there is a typo. I've also seen this double colon several times,
and it isn't consistent across the other similar make targets, and I
always wondered if it was needed or not. If it is not needed, we should
remove it to make this rule consistent with others. If it's needed, it
should be explained in a comment above it because it's not obvious
what's going on.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-18 20:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 15:16 [Buildroot] [PATCH 1/1] package/pkg-generic.mk: fix typo in make target .stamp_built Bernd Kuhls
2023-08-18 20:03 ` Thomas Petazzoni via buildroot
2023-08-18 20:24 ` Yann E. MORIN
2023-08-18 20:44 ` Thomas Petazzoni via buildroot [this message]
2023-08-18 21:18 ` Yann E. MORIN
[not found] ` <20230818220314.3178c964__25218.2109326654$1692389025$gmane$org@windsurf>
2023-08-18 20:47 ` Bernd Kuhls
2023-08-21 13:13 ` Thomas Petazzoni via buildroot
2024-07-12 19:47 ` Arnout Vandecappelle via buildroot
2024-08-07 8:54 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818224429.618b7dd1@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox